All of lore.kernel.org
 help / color / mirror / Atom feed
From: julia.lawall@lip6.fr (Julia Lawall)
To: cocci@systeme.lip6.fr
Subject: [Cocci] malloc/calloc/strup adding missing NULL checks
Date: Fri, 16 Dec 2016 15:33:58 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.10.1612161531110.6500@hadrien> (raw)
In-Reply-To: <20161216141242.3tisfzykz5zxcdtu@fbsd-laptop>



On Fri, 16 Dec 2016, Thomas Adam wrote:

> On Fri, Dec 16, 2016 at 02:54:42PM +0100, Julia Lawall wrote:
> > Could you send me the original .c file, preferably cut down to show only
> > the error?
> >
> > For --parse-c, most of the interestingoutput is on stderr.
>
> Hi Julia,
>
> Yes -- stderr was redirected to those files anyway.
>
> Please see the attached .c file which just contains a sample function which
> isn't being matched.

For me, the attached file seems to work fine.  But the function is quite
big and contains many strdups.  If there is one that is not getting
matched, perhaps you could make a smaller example that illustrates the
problem.

>From the type-c output, I have the impression that it is pkg_adddep that
is not getting processed.  That has no type annotations at all.  The other
functions seem to have annotations on some variables.  When Coccinelle
doesn't know the type, it will put /**/.  But that means that it processed
the code but doesn't know the type, not that it did not process the code
at all.

julia

  reply	other threads:[~2016-12-16 14:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-16 11:34 [Cocci] malloc/calloc/strup adding missing NULL checks Thomas Adam
2016-12-16 11:44 ` Julia Lawall
2016-12-16 13:13   ` Thomas Adam
2016-12-16 13:54     ` Julia Lawall
2016-12-16 14:12       ` Thomas Adam
2016-12-16 14:33         ` Julia Lawall [this message]
2016-12-16 14:46           ` Thomas Adam
     [not found]             ` <alpine.DEB.2.10.1612161549220.6500@hadrien>
2016-12-16 17:08               ` Thomas Adam
     [not found]                 ` <alpine.DEB.2.10.1612161929450.3239@hadrien>
2016-12-16 18:37                   ` Thomas Adam
2016-12-16 19:05                     ` Julia Lawall
2016-12-16 19:10                       ` Thomas Adam
2016-12-16 19:21                         ` Julia Lawall
2016-12-16 19:31                           ` Thomas Adam
2016-12-16 19:33                             ` Julia Lawall
2016-12-16 21:55                               ` Thomas Adam
2016-12-20 19:45                                 ` [Cocci] … " SF Markus Elfring
2016-12-22 22:53                                   ` Thomas Adam
2016-12-23  6:43                                     ` Julia Lawall
2016-12-23  6:54                                     ` SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1612161531110.6500@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.