From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751413AbdAMKJ6 (ORCPT ); Fri, 13 Jan 2017 05:09:58 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:35491 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751386AbdAMKJz (ORCPT ); Fri, 13 Jan 2017 05:09:55 -0500 Date: Fri, 13 Jan 2017 02:09:53 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Andrew Morton cc: Michal Hocko , Johannes Weiner , Vladimir Davydov , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch v2] mm, memcg: do not retry precharge charges In-Reply-To: <20170113084014.GB25212@dhcp22.suse.cz> Message-ID: References: <20170113084014.GB25212@dhcp22.suse.cz> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When memory.move_charge_at_immigrate is enabled and precharges are depleted during move, mem_cgroup_move_charge_pte_range() will attempt to increase the size of the precharge. Prevent precharges from ever looping by setting __GFP_NORETRY. This was probably the intention of the GFP_KERNEL & ~__GFP_NORETRY, which is pointless as written. Fixes: 0029e19ebf84 ("mm: memcontrol: remove explicit OOM parameter in charge path") Acked-by: Michal Hocko Signed-off-by: David Rientjes --- mm/memcontrol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -4353,9 +4353,9 @@ static int mem_cgroup_do_precharge(unsigned long count) return ret; } - /* Try charges one by one with reclaim */ + /* Try charges one by one with reclaim, but do not retry */ while (count--) { - ret = try_charge(mc.to, GFP_KERNEL & ~__GFP_NORETRY, 1); + ret = try_charge(mc.to, GFP_KERNEL | __GFP_NORETRY, 1); if (ret) return ret; mc.precharge++; From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Rientjes Subject: Re: [patch v2] mm, memcg: do not retry precharge charges Date: Fri, 13 Jan 2017 02:09:53 -0800 (PST) Message-ID: References: <20170113084014.GB25212@dhcp22.suse.cz> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=4fxP14oAC2QqjTbPz63gS3/Gm7CshUhk/e0qb852LEQ=; b=bOYfI35v9BAs3E6kI47BIn6kjezpOgl9Tkmuoe30TIaP5No/kj1a+ku4O46M/WTaTI fszgfQ7z4HNoKFb3Q8qNbRtrRRFJWU7+5h55jmYbkvcyjdySseYwnsflszAUcqdJMvDh Xyt3a8hKlvYRLiN8FAvFaixTh9+Pgh4lDd7BOdzcZSxViOsKEBSoIHgrk2t8rtJo8oey Cz1+d2/48tM/tXmFk1vBNrTLGchcfHixnpkX/QNrjvr443pEFFYazBvB1O1uOp6i3NPK +zUjsKZkKRrFSdx/VLBgvLVsC9C4hBRSUCmK6AniQsxJKYwdp0vf3etbZrpkYNRTVBN/ QIXg== In-Reply-To: <20170113084014.GB25212@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andrew Morton Cc: Michal Hocko , Johannes Weiner , Vladimir Davydov , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org When memory.move_charge_at_immigrate is enabled and precharges are depleted during move, mem_cgroup_move_charge_pte_range() will attempt to increase the size of the precharge. Prevent precharges from ever looping by setting __GFP_NORETRY. This was probably the intention of the GFP_KERNEL & ~__GFP_NORETRY, which is pointless as written. Fixes: 0029e19ebf84 ("mm: memcontrol: remove explicit OOM parameter in charge path") Acked-by: Michal Hocko Signed-off-by: David Rientjes --- mm/memcontrol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -4353,9 +4353,9 @@ static int mem_cgroup_do_precharge(unsigned long count) return ret; } - /* Try charges one by one with reclaim */ + /* Try charges one by one with reclaim, but do not retry */ while (count--) { - ret = try_charge(mc.to, GFP_KERNEL & ~__GFP_NORETRY, 1); + ret = try_charge(mc.to, GFP_KERNEL | __GFP_NORETRY, 1); if (ret) return ret; mc.precharge++; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org