From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933358AbdCHAV0 (ORCPT ); Tue, 7 Mar 2017 19:21:26 -0500 Received: from mail.kernel.org ([198.145.29.136]:35094 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933274AbdCHAVT (ORCPT ); Tue, 7 Mar 2017 19:21:19 -0500 Date: Tue, 7 Mar 2017 16:11:19 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-X260 To: Boris Ostrovsky cc: Stefano Stabellini , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Stefano Stabellini , jgross@suse.com, Eric Van Hensbergen , Ron Minnich , Latchesar Ionkov , v9fs-developer@lists.sourceforge.net Subject: Re: [PATCH 4/7] xen/9pfs: connect to the backend In-Reply-To: Message-ID: References: <1488830488-18506-1-git-send-email-sstabellini@kernel.org> <1488830488-18506-4-git-send-email-sstabellini@kernel.org> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Mar 2017, Boris Ostrovsky wrote: > > +static int xen_9pfs_front_free(struct xen_9pfs_front_priv *priv) > > +{ > > + int i, j; > > + > > + list_del(&priv->list); > > + > > + for (i = 0; i < priv->num_rings; i++) { > > + if (priv->rings[i].intf == NULL) > > + break; > > Are we guaranteed that all subsequent entries are not allocated (i.e. > this shouldn't be 'continue')? Yes, we are guaranteed that all subsequent entries are NULL because they are allocated in order until an error occurs. > > + if (priv->rings[i].irq > 0) > > + unbind_from_irqhandler(priv->rings[i].irq, priv->dev); > > + if (priv->rings[i].bytes != NULL) { > > + for (j = 0; j < (1 << XEN_9PFS_RING_ORDER); j++) > > + gnttab_end_foreign_access(priv->rings[i].intf->ref[j], 0, 0); > > + free_pages((unsigned long)priv->rings[i].bytes, XEN_9PFS_RING_ORDER); > > + } > > + gnttab_end_foreign_access(priv->rings[i].ref, 0, 0); > > + free_page((unsigned long)priv->rings[i].intf); > > + } > > + kfree(priv->rings); > > + kfree(priv); > > + > > + return 0; > > +} > > + > > static int xen_9pfs_front_remove(struct xenbus_device *dev) > > { > > + int ret; > > + struct xen_9pfs_front_priv *priv = dev_get_drvdata(&dev->dev); > > + > > + dev_set_drvdata(&dev->dev, NULL); > > + ret = xen_9pfs_front_free(priv); > > + return ret; > > +} > > + > > +static int xen_9pfs_front_alloc_dataring(struct xenbus_device *dev, > > + struct xen_9pfs_dataring *ring) > > +{ > > + int i; > > + int ret = -ENOMEM; > > + > > + init_waitqueue_head(&ring->wq); > > + spin_lock_init(&ring->lock); > > + INIT_WORK(&ring->work, p9_xen_response); > > + > > + ring->intf = (struct xen_9pfs_data_intf *) __get_free_page(GFP_KERNEL | __GFP_ZERO); > > + if (!ring->intf) > > + goto error; > > + memset(ring->intf, 0, XEN_PAGE_SIZE); > > get_zeroed_page()? (especially given that __get_free_page() returns > PAGE_SIZE, not XEN_PAGE_SIZE) Yes, good point. > > + ring->bytes = (void*)__get_free_pages(GFP_KERNEL | __GFP_ZERO, XEN_9PFS_RING_ORDER); > > + if (ring->bytes == NULL) > > + goto error; > > + for (i = 0; i < (1 << XEN_9PFS_RING_ORDER); i++) > > + ring->intf->ref[i] = gnttab_grant_foreign_access(dev->otherend_id, pfn_to_gfn(virt_to_pfn((void*)ring->bytes) + i), 0); > > + ring->ref = gnttab_grant_foreign_access(dev->otherend_id, pfn_to_gfn(virt_to_pfn((void*)ring->intf)), 0); > > + ring->ring.in = ring->bytes; > > + ring->ring.out = ring->bytes + XEN_9PFS_RING_SIZE; > > + > > + ret = xenbus_alloc_evtchn(dev, &ring->evtchn); > > + if (ret) > > + goto error; > > + ring->irq = bind_evtchn_to_irqhandler(ring->evtchn, xen_9pfs_front_event_handler, > > + 0, "xen_9pfs-frontend", ring); > > + if (ring->irq < 0) { > > + xenbus_free_evtchn(dev, ring->evtchn); > > + ret = ring->irq; > > + goto error; > > + } > > return 0; > > + > > +error: > > You may need to gnttab_end_foreign_access(). Actually this error path is unnecessary because it will be handled by xen_9pfs_front_probe, that calls xen_9pfs_front_free on errors. I'll remove it. > > + if (ring->intf != NULL) > > + kfree(ring->intf); > > + if (ring->bytes != NULL) > > + kfree(ring->bytes); > > + return ret; > > } > > > > static int xen_9pfs_front_probe(struct xenbus_device *dev, > > const struct xenbus_device_id *id) > > { > > + int ret = -EFAULT, i; > > Unnecessary initialization. I'll remove it. > > + struct xenbus_transaction xbt; > > + struct xen_9pfs_front_priv *priv = NULL; > > + char *versions; > > + unsigned int max_rings, max_ring_order, len; > > + > > + versions = xenbus_read(XBT_NIL, dev->otherend, "versions", &len); > > + if (!len || strcmp(versions, "1")) > > + return -EINVAL; > > + kfree(versions); > > + ret = xenbus_scanf(XBT_NIL, dev->otherend, "max-rings", "%u", &max_rings); > > + if (ret < 0 || max_rings < XEN_9PFS_NUM_RINGS) > > + return -EINVAL; > > + ret = xenbus_scanf(XBT_NIL, dev->otherend, "max-ring-page-order", "%u", &max_ring_order); > > + if (ret < 0|| max_ring_order < XEN_9PFS_RING_ORDER) > > + return -EINVAL; > > + > > + > > + priv = kzalloc(sizeof(struct xen_9pfs_front_priv), GFP_KERNEL); > > + if (!priv) > > + return -ENOMEM; > > + > > + priv->dev = dev; > > + priv->num_rings = XEN_9PFS_NUM_RINGS; > > + priv->rings = kzalloc(sizeof(struct xen_9pfs_dataring) * priv->num_rings, > > + GFP_KERNEL); > > + if (!priv->rings) { > > + kfree(priv); > > + return -ENOMEM; > > + } > > + > > + again: > > + ret = xenbus_transaction_start(&xbt); > > + if (ret) { > > + xenbus_dev_fatal(dev, ret, "starting transaction"); > > + goto error; > > + } > > + ret = xenbus_printf(xbt, dev->nodename, "version", "%u", 1); > > + if (ret) > > + goto error_xenbus; > > + ret = xenbus_printf(xbt, dev->nodename, "num-rings", "%u", priv->num_rings); > > + if (ret) > > + goto error_xenbus; > > + for (i = 0; i < priv->num_rings; i++) { > > + char str[16]; > > + > > + priv->rings[i].priv = priv; > > + ret = xen_9pfs_front_alloc_dataring(dev, &priv->rings[i]); > > Not for -EAGAIN, I think. I don't think xen_9pfs_front_alloc_dataring can return EAGAIN. EAGAIN can only come from xenbus_transaction_end, the case we handle below. > > + if (ret < 0) > > + goto error_xenbus; > > + > > + sprintf(str, "ring-ref%u", i); > > + ret = xenbus_printf(xbt, dev->nodename, str, "%d", priv->rings[i].ref); > > + if (ret) > > + goto error_xenbus; > > + > > + sprintf(str, "event-channel-%u", i); > > + ret = xenbus_printf(xbt, dev->nodename, str, "%u", priv->rings[i].evtchn); > > + if (ret) > > + goto error_xenbus; > > + } > > + priv->tag = xenbus_read(xbt, dev->nodename, "tag", NULL); > > + if (ret) > > + goto error_xenbus; > > + ret = xenbus_transaction_end(xbt, 0); > > + if (ret) { > > + if (ret == -EAGAIN) > > + goto again; > > + xenbus_dev_fatal(dev, ret, "completing transaction"); > > + goto error; > > + } > > + > > + > > + list_add_tail(&priv->list, &xen_9pfs_devs); > > + dev_set_drvdata(&dev->dev, priv); > > + xenbus_switch_state(dev, XenbusStateInitialised); > > + > > return 0; > > + > > + error_xenbus: > > + xenbus_transaction_end(xbt, 1); > > + xenbus_dev_fatal(dev, ret, "writing xenstore"); > > + error: > > + dev_set_drvdata(&dev->dev, NULL); > > + xen_9pfs_front_free(priv); > > + return ret; > > } > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH 4/7] xen/9pfs: connect to the backend Date: Tue, 7 Mar 2017 16:11:19 -0800 (PST) Message-ID: References: <1488830488-18506-1-git-send-email-sstabellini@kernel.org> <1488830488-18506-4-git-send-email-sstabellini@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clPCR-0007PE-Md for xen-devel@lists.xenproject.org; Wed, 08 Mar 2017 00:11:27 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Boris Ostrovsky Cc: jgross@suse.com, Latchesar Ionkov , Stefano Stabellini , Eric Van Hensbergen , linux-kernel@vger.kernel.org, Stefano Stabellini , v9fs-developer@lists.sourceforge.net, Ron Minnich , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gVHVlLCA3IE1hciAyMDE3LCBCb3JpcyBPc3Ryb3Zza3kgd3JvdGU6Cj4gPiArc3RhdGljIGlu dCB4ZW5fOXBmc19mcm9udF9mcmVlKHN0cnVjdCB4ZW5fOXBmc19mcm9udF9wcml2ICpwcml2KQo+ ID4gK3sKPiA+ICsJaW50IGksIGo7Cj4gPiArCj4gPiArCWxpc3RfZGVsKCZwcml2LT5saXN0KTsK PiA+ICsKPiA+ICsJZm9yIChpID0gMDsgaSA8IHByaXYtPm51bV9yaW5nczsgaSsrKSB7Cj4gPiAr CQlpZiAocHJpdi0+cmluZ3NbaV0uaW50ZiA9PSBOVUxMKQo+ID4gKwkJCWJyZWFrOwo+IAo+IEFy ZSB3ZSBndWFyYW50ZWVkIHRoYXQgYWxsIHN1YnNlcXVlbnQgZW50cmllcyBhcmUgbm90IGFsbG9j YXRlZCAoaS5lLgo+IHRoaXMgc2hvdWxkbid0IGJlICdjb250aW51ZScpPwoKWWVzLCB3ZSBhcmUg Z3VhcmFudGVlZCB0aGF0IGFsbCBzdWJzZXF1ZW50IGVudHJpZXMgYXJlIE5VTEwgYmVjYXVzZSB0 aGV5CmFyZSBhbGxvY2F0ZWQgaW4gb3JkZXIgdW50aWwgYW4gZXJyb3Igb2NjdXJzLgoKCj4gPiAr CQlpZiAocHJpdi0+cmluZ3NbaV0uaXJxID4gMCkKPiA+ICsJCQl1bmJpbmRfZnJvbV9pcnFoYW5k bGVyKHByaXYtPnJpbmdzW2ldLmlycSwgcHJpdi0+ZGV2KTsKPiA+ICsJCWlmIChwcml2LT5yaW5n c1tpXS5ieXRlcyAhPSBOVUxMKSB7Cj4gPiArCQkJZm9yIChqID0gMDsgaiA8ICgxIDw8IFhFTl85 UEZTX1JJTkdfT1JERVIpOyBqKyspCj4gPiArCQkJCWdudHRhYl9lbmRfZm9yZWlnbl9hY2Nlc3Mo cHJpdi0+cmluZ3NbaV0uaW50Zi0+cmVmW2pdLCAwLCAwKTsKPiA+ICsJCQlmcmVlX3BhZ2VzKCh1 bnNpZ25lZCBsb25nKXByaXYtPnJpbmdzW2ldLmJ5dGVzLCBYRU5fOVBGU19SSU5HX09SREVSKTsK PiA+ICsJCX0KPiA+ICsJCWdudHRhYl9lbmRfZm9yZWlnbl9hY2Nlc3MocHJpdi0+cmluZ3NbaV0u cmVmLCAwLCAwKTsKPiA+ICsJCWZyZWVfcGFnZSgodW5zaWduZWQgbG9uZylwcml2LT5yaW5nc1tp XS5pbnRmKTsKPiA+ICsJfQo+ID4gKwlrZnJlZShwcml2LT5yaW5ncyk7Cj4gPiArCWtmcmVlKHBy aXYpOwo+ID4gKwo+ID4gKwlyZXR1cm4gMDsKPiA+ICt9Cj4gPiArCj4gPiAgc3RhdGljIGludCB4 ZW5fOXBmc19mcm9udF9yZW1vdmUoc3RydWN0IHhlbmJ1c19kZXZpY2UgKmRldikKPiA+ICB7Cj4g PiArCWludCByZXQ7Cj4gPiArCXN0cnVjdCB4ZW5fOXBmc19mcm9udF9wcml2ICpwcml2ID0gZGV2 X2dldF9kcnZkYXRhKCZkZXYtPmRldik7Cj4gPiArCj4gPiArCWRldl9zZXRfZHJ2ZGF0YSgmZGV2 LT5kZXYsIE5VTEwpOwo+ID4gKwlyZXQgPSB4ZW5fOXBmc19mcm9udF9mcmVlKHByaXYpOwo+ID4g KwlyZXR1cm4gcmV0Owo+ID4gK30KPiA+ICsKPiA+ICtzdGF0aWMgaW50IHhlbl85cGZzX2Zyb250 X2FsbG9jX2RhdGFyaW5nKHN0cnVjdCB4ZW5idXNfZGV2aWNlICpkZXYsCj4gPiArCQlzdHJ1Y3Qg eGVuXzlwZnNfZGF0YXJpbmcgKnJpbmcpCj4gPiArewo+ID4gKwlpbnQgaTsKPiA+ICsJaW50IHJl dCA9IC1FTk9NRU07Cj4gPiArCj4gPiArCWluaXRfd2FpdHF1ZXVlX2hlYWQoJnJpbmctPndxKTsK PiA+ICsJc3Bpbl9sb2NrX2luaXQoJnJpbmctPmxvY2spOwo+ID4gKwlJTklUX1dPUksoJnJpbmct PndvcmssIHA5X3hlbl9yZXNwb25zZSk7Cj4gPiArCj4gPiArCXJpbmctPmludGYgPSAoc3RydWN0 IHhlbl85cGZzX2RhdGFfaW50ZiAqKSBfX2dldF9mcmVlX3BhZ2UoR0ZQX0tFUk5FTCB8IF9fR0ZQ X1pFUk8pOwo+ID4gKwlpZiAoIXJpbmctPmludGYpCj4gPiArCQlnb3RvIGVycm9yOwo+ID4gKwlt ZW1zZXQocmluZy0+aW50ZiwgMCwgWEVOX1BBR0VfU0laRSk7Cj4gCj4gZ2V0X3plcm9lZF9wYWdl KCk/ICAoZXNwZWNpYWxseSBnaXZlbiB0aGF0IF9fZ2V0X2ZyZWVfcGFnZSgpIHJldHVybnMKPiBQ QUdFX1NJWkUsIG5vdCBYRU5fUEFHRV9TSVpFKQoKWWVzLCBnb29kIHBvaW50LgoKCiAKPiA+ICsJ cmluZy0+Ynl0ZXMgPSAodm9pZCopX19nZXRfZnJlZV9wYWdlcyhHRlBfS0VSTkVMIHwgX19HRlBf WkVSTywgWEVOXzlQRlNfUklOR19PUkRFUik7Cj4gPiArCWlmIChyaW5nLT5ieXRlcyA9PSBOVUxM KQo+ID4gKwkJZ290byBlcnJvcjsKPiA+ICsJZm9yIChpID0gMDsgaSA8ICgxIDw8IFhFTl85UEZT X1JJTkdfT1JERVIpOyBpKyspCj4gPiArCQlyaW5nLT5pbnRmLT5yZWZbaV0gPSBnbnR0YWJfZ3Jh bnRfZm9yZWlnbl9hY2Nlc3MoZGV2LT5vdGhlcmVuZF9pZCwgcGZuX3RvX2dmbih2aXJ0X3RvX3Bm bigodm9pZCopcmluZy0+Ynl0ZXMpICsgaSksIDApOwo+ID4gKwlyaW5nLT5yZWYgPSBnbnR0YWJf Z3JhbnRfZm9yZWlnbl9hY2Nlc3MoZGV2LT5vdGhlcmVuZF9pZCwgcGZuX3RvX2dmbih2aXJ0X3Rv X3Bmbigodm9pZCopcmluZy0+aW50ZikpLCAwKTsKPiA+ICsJcmluZy0+cmluZy5pbiA9IHJpbmct PmJ5dGVzOwo+ID4gKwlyaW5nLT5yaW5nLm91dCA9IHJpbmctPmJ5dGVzICsgWEVOXzlQRlNfUklO R19TSVpFOwo+ID4gKwo+ID4gKwlyZXQgPSB4ZW5idXNfYWxsb2NfZXZ0Y2huKGRldiwgJnJpbmct PmV2dGNobik7Cj4gPiArCWlmIChyZXQpCj4gPiArCQlnb3RvIGVycm9yOwo+ID4gKwlyaW5nLT5p cnEgPSBiaW5kX2V2dGNobl90b19pcnFoYW5kbGVyKHJpbmctPmV2dGNobiwgeGVuXzlwZnNfZnJv bnRfZXZlbnRfaGFuZGxlciwKPiA+ICsJCQkJCTAsICJ4ZW5fOXBmcy1mcm9udGVuZCIsIHJpbmcp Owo+ID4gKwlpZiAocmluZy0+aXJxIDwgMCkgewo+ID4gKwkJeGVuYnVzX2ZyZWVfZXZ0Y2huKGRl diwgcmluZy0+ZXZ0Y2huKTsKPiA+ICsJCXJldCA9IHJpbmctPmlycTsKPiA+ICsJCWdvdG8gZXJy b3I7Cj4gPiArCX0KPiA+ICAJcmV0dXJuIDA7Cj4gPiArCj4gPiArZXJyb3I6Cj4gCj4gWW91IG1h eSBuZWVkIHRvIGdudHRhYl9lbmRfZm9yZWlnbl9hY2Nlc3MoKS4KCkFjdHVhbGx5IHRoaXMgZXJy b3IgcGF0aCBpcyB1bm5lY2Vzc2FyeSBiZWNhdXNlIGl0IHdpbGwgYmUgaGFuZGxlZCBieQp4ZW5f OXBmc19mcm9udF9wcm9iZSwgdGhhdCBjYWxscyB4ZW5fOXBmc19mcm9udF9mcmVlIG9uIGVycm9y cy4gSSdsbApyZW1vdmUgaXQuCgoKPiA+ICsJaWYgKHJpbmctPmludGYgIT0gTlVMTCkKPiA+ICsJ CWtmcmVlKHJpbmctPmludGYpOwo+ID4gKwlpZiAocmluZy0+Ynl0ZXMgIT0gTlVMTCkKPiA+ICsJ CWtmcmVlKHJpbmctPmJ5dGVzKTsKPiA+ICsJcmV0dXJuIHJldDsKPiA+ICB9Cj4gPiAgCj4gPiAg c3RhdGljIGludCB4ZW5fOXBmc19mcm9udF9wcm9iZShzdHJ1Y3QgeGVuYnVzX2RldmljZSAqZGV2 LAo+ID4gIAkJY29uc3Qgc3RydWN0IHhlbmJ1c19kZXZpY2VfaWQgKmlkKQo+ID4gIHsKPiA+ICsJ aW50IHJldCA9IC1FRkFVTFQsIGk7Cj4gCj4gVW5uZWNlc3NhcnkgaW5pdGlhbGl6YXRpb24uCgpJ J2xsIHJlbW92ZSBpdC4KCgo+ID4gKwlzdHJ1Y3QgeGVuYnVzX3RyYW5zYWN0aW9uIHhidDsKPiA+ ICsJc3RydWN0IHhlbl85cGZzX2Zyb250X3ByaXYgKnByaXYgPSBOVUxMOwo+ID4gKwljaGFyICp2 ZXJzaW9uczsKPiA+ICsJdW5zaWduZWQgaW50IG1heF9yaW5ncywgbWF4X3Jpbmdfb3JkZXIsIGxl bjsKPiA+ICsKPiA+ICsJdmVyc2lvbnMgPSB4ZW5idXNfcmVhZChYQlRfTklMLCBkZXYtPm90aGVy ZW5kLCAidmVyc2lvbnMiLCAmbGVuKTsKPiA+ICsJaWYgKCFsZW4gfHwgc3RyY21wKHZlcnNpb25z LCAiMSIpKQo+ID4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gPiArCWtmcmVlKHZlcnNpb25zKTsKPiA+ ICsJcmV0ID0geGVuYnVzX3NjYW5mKFhCVF9OSUwsIGRldi0+b3RoZXJlbmQsICJtYXgtcmluZ3Mi LCAiJXUiLCAmbWF4X3JpbmdzKTsKPiA+ICsJaWYgKHJldCA8IDAgfHwgbWF4X3JpbmdzIDwgWEVO XzlQRlNfTlVNX1JJTkdTKQo+ID4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gPiArCXJldCA9IHhlbmJ1 c19zY2FuZihYQlRfTklMLCBkZXYtPm90aGVyZW5kLCAibWF4LXJpbmctcGFnZS1vcmRlciIsICIl dSIsICZtYXhfcmluZ19vcmRlcik7Cj4gPiArCWlmIChyZXQgPCAwfHwgbWF4X3Jpbmdfb3JkZXIg PCBYRU5fOVBGU19SSU5HX09SREVSKQo+ID4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gPiArCj4gPiAr Cj4gPiArCXByaXYgPSBremFsbG9jKHNpemVvZihzdHJ1Y3QgeGVuXzlwZnNfZnJvbnRfcHJpdiks IEdGUF9LRVJORUwpOwo+ID4gKwlpZiAoIXByaXYpCj4gPiArCQlyZXR1cm4gLUVOT01FTTsKPiA+ ICsKPiA+ICsJcHJpdi0+ZGV2ID0gZGV2Owo+ID4gKwlwcml2LT5udW1fcmluZ3MgPSBYRU5fOVBG U19OVU1fUklOR1M7Cj4gPiArCXByaXYtPnJpbmdzID0ga3phbGxvYyhzaXplb2Yoc3RydWN0IHhl bl85cGZzX2RhdGFyaW5nKSAqIHByaXYtPm51bV9yaW5ncywKPiA+ICsJCQkJCQlHRlBfS0VSTkVM KTsKPiA+ICsJaWYgKCFwcml2LT5yaW5ncykgewo+ID4gKwkJa2ZyZWUocHJpdik7Cj4gPiArCQly ZXR1cm4gLUVOT01FTTsKPiA+ICsJfQo+ID4gKwo+ID4gKyBhZ2FpbjoKPiA+ICsJcmV0ID0geGVu YnVzX3RyYW5zYWN0aW9uX3N0YXJ0KCZ4YnQpOwo+ID4gKwlpZiAocmV0KSB7Cj4gPiArCQl4ZW5i dXNfZGV2X2ZhdGFsKGRldiwgcmV0LCAic3RhcnRpbmcgdHJhbnNhY3Rpb24iKTsKPiA+ICsJCWdv dG8gZXJyb3I7Cj4gPiArCX0KPiA+ICsJcmV0ID0geGVuYnVzX3ByaW50Zih4YnQsIGRldi0+bm9k ZW5hbWUsICJ2ZXJzaW9uIiwgIiV1IiwgMSk7Cj4gPiArCWlmIChyZXQpCj4gPiArCQlnb3RvIGVy cm9yX3hlbmJ1czsKPiA+ICsJcmV0ID0geGVuYnVzX3ByaW50Zih4YnQsIGRldi0+bm9kZW5hbWUs ICJudW0tcmluZ3MiLCAiJXUiLCBwcml2LT5udW1fcmluZ3MpOwo+ID4gKwlpZiAocmV0KQo+ID4g KwkJZ290byBlcnJvcl94ZW5idXM7Cj4gPiArCWZvciAoaSA9IDA7IGkgPCBwcml2LT5udW1fcmlu Z3M7IGkrKykgewo+ID4gKwkJY2hhciBzdHJbMTZdOwo+ID4gKwo+ID4gKwkJcHJpdi0+cmluZ3Nb aV0ucHJpdiA9IHByaXY7Cj4gPiArCQlyZXQgPSB4ZW5fOXBmc19mcm9udF9hbGxvY19kYXRhcmlu ZyhkZXYsICZwcml2LT5yaW5nc1tpXSk7Cj4gCj4gTm90IGZvciAtRUFHQUlOLCBJIHRoaW5rLgoK SSBkb24ndCB0aGluayB4ZW5fOXBmc19mcm9udF9hbGxvY19kYXRhcmluZyBjYW4gcmV0dXJuIEVB R0FJTi4gRUFHQUlOCmNhbiBvbmx5IGNvbWUgZnJvbSB4ZW5idXNfdHJhbnNhY3Rpb25fZW5kLCB0 aGUgY2FzZSB3ZSBoYW5kbGUgYmVsb3cuCgoKPiA+ICsJCWlmIChyZXQgPCAwKQo+ID4gKwkJCWdv dG8gZXJyb3JfeGVuYnVzOwo+ID4gKwo+ID4gKwkJc3ByaW50ZihzdHIsICJyaW5nLXJlZiV1Iiwg aSk7Cj4gPiArCQlyZXQgPSB4ZW5idXNfcHJpbnRmKHhidCwgZGV2LT5ub2RlbmFtZSwgc3RyLCAi JWQiLCBwcml2LT5yaW5nc1tpXS5yZWYpOwo+ID4gKwkJaWYgKHJldCkKPiA+ICsJCQlnb3RvIGVy cm9yX3hlbmJ1czsKPiA+ICsKPiA+ICsJCXNwcmludGYoc3RyLCAiZXZlbnQtY2hhbm5lbC0ldSIs IGkpOwo+ID4gKwkJcmV0ID0geGVuYnVzX3ByaW50Zih4YnQsIGRldi0+bm9kZW5hbWUsIHN0ciwg IiV1IiwgcHJpdi0+cmluZ3NbaV0uZXZ0Y2huKTsKPiA+ICsJCWlmIChyZXQpCj4gPiArCQkJZ290 byBlcnJvcl94ZW5idXM7Cj4gPiArCX0KPiA+ICsJcHJpdi0+dGFnID0geGVuYnVzX3JlYWQoeGJ0 LCBkZXYtPm5vZGVuYW1lLCAidGFnIiwgTlVMTCk7Cj4gPiArCWlmIChyZXQpCj4gPiArCQlnb3Rv IGVycm9yX3hlbmJ1czsKPiA+ICsJcmV0ID0geGVuYnVzX3RyYW5zYWN0aW9uX2VuZCh4YnQsIDAp Owo+ID4gKwlpZiAocmV0KSB7Cj4gPiArCQlpZiAocmV0ID09IC1FQUdBSU4pCj4gPiArCQkJZ290 byBhZ2FpbjsKPiA+ICsJCXhlbmJ1c19kZXZfZmF0YWwoZGV2LCByZXQsICJjb21wbGV0aW5nIHRy YW5zYWN0aW9uIik7Cj4gPiArCQlnb3RvIGVycm9yOwo+ID4gKwl9Cj4gPiArCj4gPiArCj4gPiAr CWxpc3RfYWRkX3RhaWwoJnByaXYtPmxpc3QsICZ4ZW5fOXBmc19kZXZzKTsKPiA+ICsJZGV2X3Nl dF9kcnZkYXRhKCZkZXYtPmRldiwgcHJpdik7Cj4gPiArCXhlbmJ1c19zd2l0Y2hfc3RhdGUoZGV2 LCBYZW5idXNTdGF0ZUluaXRpYWxpc2VkKTsKPiA+ICsKPiA+ICAJcmV0dXJuIDA7Cj4gPiArCj4g PiArIGVycm9yX3hlbmJ1czoKPiA+ICsJeGVuYnVzX3RyYW5zYWN0aW9uX2VuZCh4YnQsIDEpOwo+ ID4gKwl4ZW5idXNfZGV2X2ZhdGFsKGRldiwgcmV0LCAid3JpdGluZyB4ZW5zdG9yZSIpOwo+ID4g KyBlcnJvcjoKPiA+ICsJZGV2X3NldF9kcnZkYXRhKCZkZXYtPmRldiwgTlVMTCk7Cj4gPiArCXhl bl85cGZzX2Zyb250X2ZyZWUocHJpdik7Cj4gPiArCXJldHVybiByZXQ7Cj4gPiAgfQo+ID4gIAo+ IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRl dmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhl bi5vcmcveGVuLWRldmVsCg==