All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Stabellini <sstabellini@kernel.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	Stefano Stabellini <stefano@aporeto.com>,
	jgross@suse.com, Eric Van Hensbergen <ericvh@gmail.com>,
	Ron Minnich <rminnich@sandia.gov>,
	Latchesar Ionkov <lucho@ionkov.net>,
	v9fs-developer@lists.sourceforge.net
Subject: Re: [PATCH 6/7] xen/9pfs: receive responses
Date: Tue, 7 Mar 2017 17:13:59 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1703071712550.8160@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <alpine.DEB.2.10.1703071658480.8160@sstabellini-ThinkPad-X260>

On Tue, 7 Mar 2017, Stefano Stabellini wrote:
> > > +
> > > +	ring = container_of(work, struct xen_9pfs_dataring, work);
> > > +	priv = ring->priv;
> > > +
> > > +	while (1) {
> > > +		cons = ring->intf->in_cons;
> > > +		prod = ring->intf->in_prod;
> > > +		rmb();
> > 
> > 
> > Is this rmb() or mb()? (Or, in fact, virt_XXX()?) You used mb() in the
> > previous patch.
>  
> I think they should all be virt_XXX, thanks.

regarding mb() vs. rmb(), give a look at the workflow at the end of
docs/misc/9pfs.markdown, under "Ring Usage".

WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <sstabellini@kernel.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: jgross@suse.com, Latchesar Ionkov <lucho@ionkov.net>,
	Eric Van Hensbergen <ericvh@gmail.com>,
	linux-kernel@vger.kernel.org,
	Stefano Stabellini <stefano@aporeto.com>,
	v9fs-developer@lists.sourceforge.net,
	Ron Minnich <rminnich@sandia.gov>,
	xen-devel@lists.xenproject.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 6/7] xen/9pfs: receive responses
Date: Tue, 7 Mar 2017 17:13:59 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1703071712550.8160@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <alpine.DEB.2.10.1703071658480.8160@sstabellini-ThinkPad-X260>

On Tue, 7 Mar 2017, Stefano Stabellini wrote:
> > > +
> > > +	ring = container_of(work, struct xen_9pfs_dataring, work);
> > > +	priv = ring->priv;
> > > +
> > > +	while (1) {
> > > +		cons = ring->intf->in_cons;
> > > +		prod = ring->intf->in_prod;
> > > +		rmb();
> > 
> > 
> > Is this rmb() or mb()? (Or, in fact, virt_XXX()?) You used mb() in the
> > previous patch.
>  
> I think they should all be virt_XXX, thanks.

regarding mb() vs. rmb(), give a look at the workflow at the end of
docs/misc/9pfs.markdown, under "Ring Usage".

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-03-08  1:22 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-06 20:00 [PATCH 0/7] Xen transport for 9pfs frontend driver Stefano Stabellini
2017-03-06 20:01 ` [PATCH 1/7] xen: import new ring macros in ring.h Stefano Stabellini
2017-03-06 20:01   ` Stefano Stabellini
2017-03-06 20:01   ` [PATCH 2/7] xen: introduce the header file for the Xen 9pfs transport protocol Stefano Stabellini
2017-03-06 20:01     ` Stefano Stabellini
2017-03-06 21:22     ` Boris Ostrovsky
2017-03-06 21:22       ` Boris Ostrovsky
2017-03-06 21:36       ` Stefano Stabellini
2017-03-06 21:36       ` Stefano Stabellini
2017-03-06 21:42         ` Boris Ostrovsky
2017-03-06 21:42           ` Boris Ostrovsky
2017-03-06 20:01   ` [PATCH 3/7] xen/9pfs: introduce Xen 9pfs transport driver Stefano Stabellini
2017-03-06 20:01     ` Stefano Stabellini
2017-03-06 20:01   ` [PATCH 4/7] xen/9pfs: connect to the backend Stefano Stabellini
2017-03-06 20:01     ` Stefano Stabellini
2017-03-07 15:03     ` Boris Ostrovsky
2017-03-07 15:03       ` Boris Ostrovsky
2017-03-08  0:11       ` Stefano Stabellini
2017-03-08  0:11         ` Stefano Stabellini
2017-03-08 13:47         ` Boris Ostrovsky
2017-03-08 13:47           ` Boris Ostrovsky
2017-03-08 19:22           ` Stefano Stabellini
2017-03-08 19:22           ` Stefano Stabellini
2017-03-07 17:37     ` [Xen-devel] " Julien Grall
2017-03-07 17:37       ` Julien Grall
2017-03-08  0:49       ` [Xen-devel] " Stefano Stabellini
2017-03-08  0:49         ` Stefano Stabellini
2017-03-08 12:25         ` [Xen-devel] " Julien Grall
2017-03-08 12:25           ` Julien Grall
2017-03-08 19:08           ` [Xen-devel] " Stefano Stabellini
2017-03-08 19:08             ` Stefano Stabellini
2017-03-06 20:01   ` [PATCH 5/7] xen/9pfs: send requests " Stefano Stabellini
2017-03-06 20:01     ` Stefano Stabellini
2017-03-07 15:27     ` Boris Ostrovsky
2017-03-07 15:27       ` Boris Ostrovsky
2017-03-08  0:55       ` Stefano Stabellini
2017-03-08  0:55       ` Stefano Stabellini
2017-03-08 13:58         ` Boris Ostrovsky
2017-03-08 13:58           ` Boris Ostrovsky
2017-03-08 19:33           ` Stefano Stabellini
2017-03-08 19:33             ` Stefano Stabellini
2017-03-08 20:02             ` Boris Ostrovsky
2017-03-08 20:02               ` Boris Ostrovsky
2017-03-08 20:56               ` Stefano Stabellini
2017-03-08 20:56                 ` Stefano Stabellini
2017-03-08 21:01                 ` Boris Ostrovsky
2017-03-08 21:01                   ` Boris Ostrovsky
2017-03-06 20:01   ` [PATCH 6/7] xen/9pfs: receive responses Stefano Stabellini
2017-03-06 20:01     ` Stefano Stabellini
2017-03-07 15:49     ` Boris Ostrovsky
2017-03-07 15:49       ` Boris Ostrovsky
2017-03-08  1:06       ` Stefano Stabellini
2017-03-08  1:06         ` Stefano Stabellini
2017-03-08  1:13         ` Stefano Stabellini [this message]
2017-03-08  1:13           ` Stefano Stabellini
2017-03-08 20:11           ` Konrad Rzeszutek Wilk
2017-03-08 20:11           ` [Xen-devel] " Konrad Rzeszutek Wilk
2017-03-08 14:33         ` Boris Ostrovsky
2017-03-08 14:33           ` Boris Ostrovsky
2017-03-08 19:26           ` Stefano Stabellini
2017-03-08 19:26           ` Stefano Stabellini
2017-03-06 20:01   ` [PATCH 7/7] xen/9pfs: build 9pfs Xen transport driver Stefano Stabellini
2017-03-06 20:01     ` Stefano Stabellini
2017-03-07 17:15   ` [Xen-devel] [PATCH 1/7] xen: import new ring macros in ring.h Julien Grall
2017-03-07 17:15     ` Julien Grall
2017-03-08  0:12     ` [Xen-devel] " Stefano Stabellini
2017-03-08  0:12       ` Stefano Stabellini
2017-03-08 11:14       ` [Xen-devel] " Julien Grall
2017-03-08 11:14         ` Julien Grall
2017-03-07 16:38 ` [Xen-devel] [PATCH 0/7] Xen transport for 9pfs frontend driver Roger Pau Monné
2017-03-07 16:38   ` Roger Pau Monné
2017-03-07 18:27   ` [Xen-devel] " Stefano Stabellini
2017-03-07 18:27     ` Stefano Stabellini
2017-03-09  3:02     ` [Xen-devel] " Roger Pau Monné
2017-03-09  3:02       ` Roger Pau Monné
2017-03-13 22:36       ` Stefano Stabellini
2017-03-13 22:36       ` [Xen-devel] " Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1703071712550.8160@sstabellini-ThinkPad-X260 \
    --to=sstabellini@kernel.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=ericvh@gmail.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucho@ionkov.net \
    --cc=rminnich@sandia.gov \
    --cc=stefano@aporeto.com \
    --cc=v9fs-developer@lists.sourceforge.net \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.