Re: [PATCH] x86/intel_rdt: Implement "update" mode when writing schemata file

From: Shivappa Vikas <vikas.shivappa@intel.com>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Vikas Shivappa <vikas.shivappa@intel.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/intel_rdt: Implement "update" mode when writing schemata file
Date: Thu, 30 Mar 2017 11:33:04 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.10.1703301132150.25705@vshiva-Udesk> (raw)
In-Reply-To: <20170324231855.GA40624@linux.intel.com>

On Fri, 24 Mar 2017, Fenghua Yu wrote:

> On Fri, Mar 24, 2017 at 10:51:58AM -0700, Luck, Tony wrote:
>> From: Tony Luck <tony.luck@intel.com>
>>
>> The schemata file can have multiple lines and it is cumbersome to
>> update from shell scripts.
>
> "from shell scripts" makes people a bit confused. Not just shell scripts,
> C or Java code also can be cumbersome to update the file, right?
>
>> +Reading/writing the schemata file
>> +---------------------------------
>> +Reading the schemata file will show the state of all resources
>> +on all domains. When writing you only need to specify those values
>> +which you wish to change.  E.g.
>
> User can still write all values including not changed and change just
> like 4.10 does. We may say "When writing you can either write all values
> or only need to specify those values which you wish to change."?

Will integrate these changes to Tony's patch and send it as part of the next 
series.

Thanks,
Vikas