From: Stefano Stabellini <sstabellini@kernel.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
AndrewCooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH for-4.9] xen: append -Wno-unused-function to C99 header check
Date: Thu, 6 Apr 2017 09:51:32 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1704060947410.2759@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <58E66DE1020000780014E0A0@prv-mh.provo.novell.com>
On Thu, 6 Apr 2017, Jan Beulich wrote:
> >>> On 06.04.17 at 14:54, <wei.liu2@citrix.com> wrote:
> > --- a/xen/include/Makefile
> > +++ b/xen/include/Makefile
> > @@ -111,7 +111,7 @@ headers.chk: $(PUBLIC_ANSI_HEADERS) Makefile
> > headers99.chk: $(PUBLIC_C99_HEADERS) Makefile
> > rm -f $@.new
> > $(foreach i, $(filter %.h,$^), \
> > - $(CC) -x c -std=c99 -Wall -Werror \
> > + $(CC) -x c -std=c99 -Wall -Werror -Wno-unused-function \
> > -include stdint.h $(foreach j, $($(i)-prereq), -include $(j).h) \
> > -S -o /dev/null $(i) \
> > || exit $$?; echo $(i) >> $@.new;)
>
> I think it would be better to make this match the C++ check, where
> a source file is being generated on the fly (and quite possibly for a
> similar reason).
I don't have an opinion on what is the best way to fix this. However,
I'll say that it is expected to have unused functions in header files
(it would be a problem if there weren't), so -Wno-unused-function looks
fine to me.
Wei, given that the problem was introduced by my patch, let me know if
you need any help fixing this.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-04-06 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 12:54 [PATCH for-4.9] xen: append -Wno-unused-function to C99 header check Wei Liu
2017-04-06 14:33 ` Jan Beulich
2017-04-06 16:51 ` Stefano Stabellini [this message]
2017-04-06 17:53 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1704060947410.2759@sstabellini-ThinkPad-X260 \
--to=sstabellini@kernel.org \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.