From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753430AbdDKA0H (ORCPT ); Mon, 10 Apr 2017 20:26:07 -0400 Received: from mail-pg0-f50.google.com ([74.125.83.50]:33586 "EHLO mail-pg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753122AbdDKA0F (ORCPT ); Mon, 10 Apr 2017 20:26:05 -0400 Date: Mon, 10 Apr 2017 17:26:03 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Wei Yang cc: kirill@shutemov.name, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, tj@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] x86/numa_emulation: assign physnode_mask directly from numa_nodes_parsed In-Reply-To: <20170410165652.50250-3-richard.weiyang@gmail.com> Message-ID: References: <20170410165652.50250-1-richard.weiyang@gmail.com> <20170410165652.50250-3-richard.weiyang@gmail.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Apr 2017, Wei Yang wrote: > According to current code path, numa_nodes_parsed is already setup when > numa_emucation() is called. > > x86_numa_init() > numa_init() > init_func() > > numa_emulation() > > numa_register_memblks() > s/numa_emucation/numa_emulation/, but I think everything above should just be reworded to say the following since it establishes the dependency: numa_init() has already called init_func(), which is responsible for setting numa_nodes_parsed, so use this nodemask instead of re-finding it when calling numa_emulation(). > This means we can get the physnode_mask directly from numa_nodes_parsed. At > the same time, this patch correct the comment of these two functions. > > Signed-off-by: Wei Yang Acked-by: David Rientjes