From: Stefano Stabellini <sstabellini@kernel.org>
To: Julien Grall <julien.grall@arm.com>
Cc: sstabellini@kernel.org, xen-devel@lists.xen.org
Subject: Re: [PATCH 1/3] xen/arm: arm32: Rename the trap to the correct name
Date: Thu, 4 May 2017 11:57:02 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1705041156550.9240@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <20170504175425.22759-2-julien.grall@arm.com>
On Thu, 4 May 2017, Julien Grall wrote:
> Per Table B1-3 in ARM DDI 0406C.c, the vector 0x8 for hyp is called
> "Hypervisor Call".
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> xen/arch/arm/arm32/entry.S | 4 ++--
> xen/arch/arm/arm32/traps.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/xen/arch/arm/arm32/entry.S b/xen/arch/arm/arm32/entry.S
> index 2b04a99664..05733089f7 100644
> --- a/xen/arch/arm/arm32/entry.S
> +++ b/xen/arch/arm/arm32/entry.S
> @@ -149,7 +149,7 @@ trap_##trap: \
> GLOBAL(hyp_traps_vector)
> .word 0 /* 0x00 - Reset */
> b trap_undefined_instruction /* 0x04 - Undefined Instruction */
> - b trap_supervisor_call /* 0x08 - Supervisor Call */
> + b trap_hypervisor_call /* 0x08 - Hypervisor Call */
> b trap_prefetch_abort /* 0x0c - Prefetch Abort */
> b trap_data_abort /* 0x10 - Data Abort */
> b trap_hypervisor /* 0x14 - Hypervisor */
> @@ -157,7 +157,7 @@ GLOBAL(hyp_traps_vector)
> b trap_fiq /* 0x1c - FIQ */
>
> DEFINE_TRAP_ENTRY(undefined_instruction)
> -DEFINE_TRAP_ENTRY(supervisor_call)
> +DEFINE_TRAP_ENTRY(hypervisor_call)
> DEFINE_TRAP_ENTRY(prefetch_abort)
> DEFINE_TRAP_ENTRY(hypervisor)
> DEFINE_TRAP_ENTRY_NOIRQ(irq)
> diff --git a/xen/arch/arm/arm32/traps.c b/xen/arch/arm/arm32/traps.c
> index 5bc5f64d86..e75836792a 100644
> --- a/xen/arch/arm/arm32/traps.c
> +++ b/xen/arch/arm/arm32/traps.c
> @@ -50,9 +50,9 @@ die:
> do_unexpected_trap("Undefined Instruction", regs);
> }
>
> -asmlinkage void do_trap_supervisor_call(struct cpu_user_regs *regs)
> +asmlinkage void do_trap_hypervisor_call(struct cpu_user_regs *regs)
> {
> - do_unexpected_trap("Supervisor Call", regs);
> + do_unexpected_trap("Hypervisor Call", regs);
> }
>
> asmlinkage void do_trap_prefetch_abort(struct cpu_user_regs *regs)
> --
> 2.11.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-05-04 18:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 17:54 [PATCH 0/3] xen/arm: Survive unknown traps from guests Julien Grall
2017-05-04 17:54 ` [PATCH 1/3] xen/arm: arm32: Rename the trap to the correct name Julien Grall
2017-05-04 18:57 ` Stefano Stabellini [this message]
2017-05-04 17:54 ` [PATCH 2/3] xen/arm: do_trap_hypervisor: Separate hypervisor and guest traps Julien Grall
2017-05-04 18:03 ` Andrew Cooper
2017-05-04 18:06 ` Julien Grall
2017-05-04 19:13 ` Stefano Stabellini
2017-05-04 17:54 ` [PATCH 3/3] xen/arm: Survive unknown traps from guests Julien Grall
2017-05-04 19:14 ` Stefano Stabellini
2017-05-04 19:18 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1705041156550.9240@sstabellini-ThinkPad-X260 \
--to=sstabellini@kernel.org \
--cc=julien.grall@arm.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.