All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shrikrishna Khare <skhare@shri-linux.eng.vmware.com>
To: "Charles (Chas) Williams" <ciwillia@brocade.com>
Cc: <dev@dpdk.org>, <skhare@vmware.com>,
	Nachiketa Prachanda <nprachan@brocade.com>
Subject: Re: [PATCH 1/6] net/vmxnet3: retain counters on restart
Date: Fri, 26 May 2017 10:31:26 -0700	[thread overview]
Message-ID: <alpine.DEB.2.10.1705261031050.5989@shri-linux.eng.vmware.com> (raw)
In-Reply-To: <1495216560-12920-1-git-send-email-ciwillia@brocade.com>



On Fri, 19 May 2017, Charles (Chas) Williams wrote:

> From: Nachiketa Prachanda <nprachan@brocade.com>
> 
> Most nics like virtio, igb/ixgbe etc. don't reset counters on
> dev_start and arguably this helps in monitoring the counters
> across a longer time span with multiple device start/stops.
> vmxnet3 behavior is opposite to that and counters are reset by
> the host side implementation each time the device is restarted.
> 
> Change the driver to save the counters in its private context
> before it is reset by writing CMD_ACTIVATE to REG_CMD.
> 
> Signed-off-by: Nachiketa Prachanda <nprachan@brocade.com>

Acked-by: Shrikrishna Khare <skhare@vmware.com>

  parent reply	other threads:[~2017-05-26 17:31 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19 17:55 [PATCH 1/6] net/vmxnet3: retain counters on restart Charles (Chas) Williams
2017-05-19 17:55 ` [PATCH 2/6] net/vmxnet3: Implement retrieval of extended stats Charles (Chas) Williams
2017-05-24  0:17   ` Shrikrishna Khare
2017-05-19 17:55 ` [PATCH 3/6] net/vmxnet3: Generate link-state change notifications Charles (Chas) Williams
2017-05-19 17:55 ` [PATCH 4/6] net/vmxnet3: Make vmxnet3_process_events less noisy Charles (Chas) Williams
2017-05-23 21:44   ` Shrikrishna Khare
2017-05-19 17:55 ` [PATCH 5/6] net/vmxnet3: receive queue lockup and memleak Charles (Chas) Williams
2017-06-01 12:24   ` Charles (Chas) Williams
2017-05-24 21:09 ` [PATCH 1/6] net/vmxnet3: retain counters on restart Shrikrishna Khare
2017-05-25 18:31   ` Nachi Prachanda
2017-05-25 20:27     ` Shrikrishna Khare
2017-05-25 22:08       ` Nachi Prachanda
2017-05-26 17:29         ` Shrikrishna Khare
2017-05-26 19:01           ` Nachi Prachanda
2017-05-26 17:31 ` Shrikrishna Khare [this message]
2017-06-15 12:16 ` [PATCH V2 0/6] some local vmxnet3 patches Charles (Chas) Williams
2017-06-15 12:16   ` [PATCH v2 1/6] net/vmxnet3: retain counters on restart Charles (Chas) Williams
2017-06-15 12:16   ` [PATCH v2 2/6] net/vmxnet3: Implement retrieval of extended stats Charles (Chas) Williams
2017-06-21  1:42     ` Shrikrishna Khare
2017-06-15 12:16   ` [PATCH v2 3/6] net/vmxnet3: Generate link-state change notifications Charles (Chas) Williams
2017-06-27 13:52     ` Ferruh Yigit
2017-06-15 12:16   ` [PATCH v2 4/6] net/vmxnet3: Make vmxnet3_process_events less noisy Charles (Chas) Williams
2017-06-28 11:30   ` [PATCH V2 0/6] some local vmxnet3 patches Ferruh Yigit
2017-06-28 12:52     ` Ferruh Yigit
2017-06-28 13:09       ` Charles (Chas) Williams
2017-06-28 17:15       ` Charles (Chas) Williams
2017-06-28 17:54         ` Ferruh Yigit
2017-06-15 12:17 ` [PATCH v2 5/6] net/vmxnet3: receive queue memory leak Charles (Chas) Williams
2017-06-23 23:00   ` Shrikrishna Khare
2017-06-15 12:17 ` [PATCH v2 6/6] net/vmxnet3: preserve configured MAC address Charles (Chas) Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1705261031050.5989@shri-linux.eng.vmware.com \
    --to=skhare@shri-linux.eng.vmware.com \
    --cc=ciwillia@brocade.com \
    --cc=dev@dpdk.org \
    --cc=nprachan@brocade.com \
    --cc=skhare@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.