From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH for-4.9 v3 3/3] xen/livepatch: Don't crash on encountering STN_UNDEF relocations Date: Thu, 22 Jun 2017 14:10:15 -0700 (PDT) Message-ID: References: <1498155329-4752-1-git-send-email-andrew.cooper3@citrix.com> <1498155329-4752-4-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1498155329-4752-4-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Andrew Cooper Cc: Stefano Stabellini , Xen-devel , Ross Lagerwall , Julien Grall , Jan Beulich List-Id: xen-devel@lists.xenproject.org T24gVGh1LCAyMiBKdW4gMjAxNywgQW5kcmV3IENvb3BlciB3cm90ZToKPiBBIHN5bW5keCBvZiBT VE5fVU5ERUYgaXMgc3BlY2lhbCwgYW5kIG1lYW5zIGEgc3ltYm9sIHZhbHVlIG9mIDAuICBXaGls ZQo+IGxlZ2l0aW1hdGUgaW4gdGhlIEVMRiBzdGFuZGFyZCwgaXRzIGV4aXN0YW5jZSBpbiBhIGxp dmVwYXRjaCBpcyBxdWVzdGlvbmFibGUKPiBhdCBiZXN0LiAgVW50aWwgYSBwbGF1c2libGUgdXNl Y2FzZSBwcmVzZW50cyBpdHNlbGYsIHJlamVjdCBzdWNoIGEgcmVsb2NhdGlvbgo+IHdpdGggLUVP UE5PVFNVUFAuCj4gCj4gQWRkaXRpb25hbGx5LCBmaXggYW4gb2ZmLWJ5LW9uZSBlcnJvciB3aGls ZSByYW5nZSBjaGVja2luZyBzeW1uZHgsIGFuZCBwZXJmb3JtCj4gYSBzYWZldHkgY2hlY2sgb24g ZWxmLT5zeW1bc3ltbmR4XS5zeW0gYmVmb3JlIGRlcmVmZW5jaW5nIGl0LCB0byBhdm9pZAo+IHRy aXBwaW5nIG92ZXIgYSBOVUxMIHBvaW50ZXIgd2hlbiBjYWxjdWxhdGluZyB2YWwuCj4gCj4gU2ln bmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KPiAt LS0KPiBDQzogS29ucmFkIFJ6ZXN6dXRlayBXaWxrIDxrb25yYWQud2lsa0BvcmFjbGUuY29tPgo+ IENDOiBSb3NzIExhZ2Vyd2FsbCA8cm9zcy5sYWdlcndhbGxAY2l0cml4LmNvbT4KPiBDQzogSmFu IEJldWxpY2ggPEpCZXVsaWNoQHN1c2UuY29tPgo+IENDOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNz dGFiZWxsaW5pQGtlcm5lbC5vcmc+Cj4gQ0M6IEp1bGllbiBHcmFsbCA8anVsaWVuLmdyYWxsQGFy bS5jb20+Cj4gCj4gdjM6Cj4gICogRml4IG9mZi1ieS1vbmUgZXJyb3IKPiB2MjoKPiAgKiBSZWpl Y3QgU1ROX1VOREVGIHdpdGggLUVPUE5PVFNVUFAKClJldmlld2VkLWJ5OiBTdGVmYW5vIFN0YWJl bGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+CgoKPiAtLS0KPiAgeGVuL2FyY2gvYXJtL2Fy bTMyL2xpdmVwYXRjaC5jIHwgMTQgKysrKysrKysrKysrKy0KPiAgeGVuL2FyY2gvYXJtL2FybTY0 L2xpdmVwYXRjaC5jIHwgMTQgKysrKysrKysrKysrKy0KPiAgeGVuL2FyY2gveDg2L2xpdmVwYXRj aC5jICAgICAgIHwgMTQgKysrKysrKysrKysrKy0KPiAgMyBmaWxlcyBjaGFuZ2VkLCAzOSBpbnNl cnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0v YXJtMzIvbGl2ZXBhdGNoLmMgYi94ZW4vYXJjaC9hcm0vYXJtMzIvbGl2ZXBhdGNoLmMKPiBpbmRl eCBhMzI4MTc5Li40MTM3OGE1IDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL2FybS9hcm0zMi9saXZl cGF0Y2guYwo+ICsrKyBiL3hlbi9hcmNoL2FybS9hcm0zMi9saXZlcGF0Y2guYwo+IEBAIC0yNTQs MTIgKzI1NCwyNCBAQCBpbnQgYXJjaF9saXZlcGF0Y2hfcGVyZm9ybShzdHJ1Y3QgbGl2ZXBhdGNo X2VsZiAqZWxmLAo+ICAgICAgICAgICAgICBhZGRlbmQgPSBnZXRfYWRkZW5kKHR5cGUsIGRlc3Qp Owo+ICAgICAgICAgIH0KPiAgCj4gLSAgICAgICAgaWYgKCBzeW1uZHggPiBlbGYtPm5zeW0gKQo+ ICsgICAgICAgIGlmICggc3ltbmR4ID09IFNUTl9VTkRFRiApCj4gKyAgICAgICAgewo+ICsgICAg ICAgICAgICBkcHJpbnRrKFhFTkxPR19FUlIsIExJVkVQQVRDSCAiJXM6IEVuY291bnRlcmVkIFNU Tl9VTkRFRlxuIiwKPiArICAgICAgICAgICAgICAgICAgICBlbGYtPm5hbWUpOwo+ICsgICAgICAg ICAgICByZXR1cm4gLUVPUE5PVFNVUFA7Cj4gKyAgICAgICAgfQo+ICsgICAgICAgIGVsc2UgaWYg KCBzeW1uZHggPj0gZWxmLT5uc3ltICkKPiAgICAgICAgICB7Cj4gICAgICAgICAgICAgIGRwcmlu dGsoWEVOTE9HX0VSUiwgTElWRVBBVENIICIlczogUmVsYXRpdmUgc3ltYm9sIHdhbnRzIHN5bWJv bEAldSB3aGljaCBpcyBwYXN0IGVuZCFcbiIsCj4gICAgICAgICAgICAgICAgICAgICAgZWxmLT5u YW1lLCBzeW1uZHgpOwo+ICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiAgICAgICAgICB9 Cj4gKyAgICAgICAgZWxzZSBpZiAoICFlbGYtPnN5bVtzeW1uZHhdLnN5bSApCj4gKyAgICAgICAg ewo+ICsgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19FUlIsIExJVkVQQVRDSCAiJXM6IE5vIHJl bGF0aXZlIHN5bWJvbEAldVxuIiwKPiArICAgICAgICAgICAgICAgICAgICBlbGYtPm5hbWUsIHN5 bW5keCk7Cj4gKyAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ICsgICAgICAgIH0KPiAgCj4g ICAgICAgICAgdmFsID0gZWxmLT5zeW1bc3ltbmR4XS5zeW0tPnN0X3ZhbHVlOyAvKiBTICovCj4g IAo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vYXJtNjQvbGl2ZXBhdGNoLmMgYi94ZW4vYXJj aC9hcm0vYXJtNjQvbGl2ZXBhdGNoLmMKPiBpbmRleCA2MzkyOWIxLi4yMjQ3YjkyIDEwMDY0NAo+ IC0tLSBhL3hlbi9hcmNoL2FybS9hcm02NC9saXZlcGF0Y2guYwo+ICsrKyBiL3hlbi9hcmNoL2Fy bS9hcm02NC9saXZlcGF0Y2guYwo+IEBAIC0yNTIsMTIgKzI1MiwyNCBAQCBpbnQgYXJjaF9saXZl cGF0Y2hfcGVyZm9ybV9yZWxhKHN0cnVjdCBsaXZlcGF0Y2hfZWxmICplbGYsCj4gICAgICAgICAg aW50IG92ZiA9IDA7Cj4gICAgICAgICAgdWludDY0X3QgdmFsOwo+ICAKPiAtICAgICAgICBpZiAo IHN5bW5keCA+IGVsZi0+bnN5bSApCj4gKyAgICAgICAgaWYgKCBzeW1uZHggPT0gU1ROX1VOREVG ICkKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIGRwcmludGsoWEVOTE9HX0VSUiwgTElWRVBB VENIICIlczogRW5jb3VudGVyZWQgU1ROX1VOREVGXG4iLAo+ICsgICAgICAgICAgICAgICAgICAg IGVsZi0+bmFtZSk7Cj4gKyAgICAgICAgICAgIHJldHVybiAtRU9QTk9UU1VQUDsKPiArICAgICAg ICB9Cj4gKyAgICAgICAgZWxzZSBpZiAoIHN5bW5keCA+PSBlbGYtPm5zeW0gKQo+ICAgICAgICAg IHsKPiAgICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfRVJSLCBMSVZFUEFUQ0ggIiVzOiBSZWxh dGl2ZSByZWxvY2F0aW9uIHdhbnRzIHN5bWJvbEAldSB3aGljaCBpcyBwYXN0IGVuZCFcbiIsCj4g ICAgICAgICAgICAgICAgICAgICAgZWxmLT5uYW1lLCBzeW1uZHgpOwo+ICAgICAgICAgICAgICBy ZXR1cm4gLUVJTlZBTDsKPiAgICAgICAgICB9Cj4gKyAgICAgICAgZWxzZSBpZiAoICFlbGYtPnN5 bVtzeW1uZHhdLnN5bSApCj4gKyAgICAgICAgewo+ICsgICAgICAgICAgICBkcHJpbnRrKFhFTkxP R19FUlIsIExJVkVQQVRDSCAiJXM6IE5vIHJlbGF0aXZlIHN5bWJvbEAldVxuIiwKPiArICAgICAg ICAgICAgICAgICAgICBlbGYtPm5hbWUsIHN5bW5keCk7Cj4gKyAgICAgICAgICAgIHJldHVybiAt RUlOVkFMOwo+ICsgICAgICAgIH0KPiAgCj4gICAgICAgICAgdmFsID0gZWxmLT5zeW1bc3ltbmR4 XS5zeW0tPnN0X3ZhbHVlICsgIHItPnJfYWRkZW5kOyAvKiBTK0EgKi8KPiAgCj4gZGlmZiAtLWdp dCBhL3hlbi9hcmNoL3g4Ni9saXZlcGF0Y2guYyBiL3hlbi9hcmNoL3g4Ni9saXZlcGF0Y2guYwo+ IGluZGV4IDc5MTc2MTAuLjQwNmViOTEgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2L2xpdmVw YXRjaC5jCj4gKysrIGIveGVuL2FyY2gveDg2L2xpdmVwYXRjaC5jCj4gQEAgLTE3MCwxMiArMTcw LDI0IEBAIGludCBhcmNoX2xpdmVwYXRjaF9wZXJmb3JtX3JlbGEoc3RydWN0IGxpdmVwYXRjaF9l bGYgKmVsZiwKPiAgICAgICAgICB1aW50OF90ICpkZXN0ID0gYmFzZS0+bG9hZF9hZGRyICsgci0+ cl9vZmZzZXQ7Cj4gICAgICAgICAgdWludDY0X3QgdmFsOwo+ICAKPiAtICAgICAgICBpZiAoIHN5 bW5keCA+IGVsZi0+bnN5bSApCj4gKyAgICAgICAgaWYgKCBzeW1uZHggPT0gU1ROX1VOREVGICkK PiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIGRwcmludGsoWEVOTE9HX0VSUiwgTElWRVBBVENI ICIlczogRW5jb3VudGVyZWQgU1ROX1VOREVGXG4iLAo+ICsgICAgICAgICAgICAgICAgICAgIGVs Zi0+bmFtZSk7Cj4gKyAgICAgICAgICAgIHJldHVybiAtRU9QTk9UU1VQUDsKPiArICAgICAgICB9 Cj4gKyAgICAgICAgZWxzZSBpZiAoIHN5bW5keCA+PSBlbGYtPm5zeW0gKQo+ICAgICAgICAgIHsK PiAgICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfRVJSLCBMSVZFUEFUQ0ggIiVzOiBSZWxhdGl2 ZSByZWxvY2F0aW9uIHdhbnRzIHN5bWJvbEAldSB3aGljaCBpcyBwYXN0IGVuZCFcbiIsCj4gICAg ICAgICAgICAgICAgICAgICAgZWxmLT5uYW1lLCBzeW1uZHgpOwo+ICAgICAgICAgICAgICByZXR1 cm4gLUVJTlZBTDsKPiAgICAgICAgICB9Cj4gKyAgICAgICAgZWxzZSBpZiAoICFlbGYtPnN5bVtz eW1uZHhdLnN5bSApCj4gKyAgICAgICAgewo+ICsgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19F UlIsIExJVkVQQVRDSCAiJXM6IE5vIHN5bWJvbEAldVxuIiwKPiArICAgICAgICAgICAgICAgICAg ICBlbGYtPm5hbWUsIHN5bW5keCk7Cj4gKyAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ICsg ICAgICAgIH0KPiAgCj4gICAgICAgICAgdmFsID0gci0+cl9hZGRlbmQgKyBlbGYtPnN5bVtzeW1u ZHhdLnN5bS0+c3RfdmFsdWU7Cj4gIAo+IC0tIAo+IDIuMS40Cj4gCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhl bi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK