From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752896AbdGMWH6 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 13 Jul 2017 18:07:58 -0400
Received: from mga07.intel.com ([134.134.136.100]:26353 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751017AbdGMWH5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 13 Jul 2017 18:07:57 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,356,1496127600"; 
   d="scan'208";a="127083618"
Date: Thu, 13 Jul 2017 15:09:34 -0700 (PDT)
From: Shivappa Vikas <vikas.shivappa@intel.com>
X-X-Sender: vikas@vshiva-Udesk
To: Thomas Gleixner <tglx@linutronix.de>
cc: Vikas Shivappa <vikas.shivappa@linux.intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, hpa@zytor.com, peterz@infradead.org,
        ravi.v.shankar@intel.com, vikas.shivappa@intel.com,
        tony.luck@intel.com, fenghua.yu@intel.com, andi.kleen@intel.com
Subject: Re: [PATCH 13/21] x86/intel_rdt/cqm: Add cpus file support
In-Reply-To: <alpine.DEB.2.20.1707021313150.2296@nanos>
Message-ID: <alpine.DEB.2.10.1707131507150.31299@vshiva-Udesk>
References: <1498503368-20173-1-git-send-email-vikas.shivappa@linux.intel.com> <1498503368-20173-14-git-send-email-vikas.shivappa@linux.intel.com> <alpine.DEB.2.20.1707021313150.2296@nanos>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Sun, 2 Jul 2017, Thomas Gleixner wrote:

>>  {
>> +	struct rdtgroup *pr = rdtgrp->parent, *cr;
>
> *pr and *cr really suck.

We used r before rdtgroup. pr would be parent rdtgrp. Wanted to keep them short 
as there are more in this function.

prgrp can be used if thats not ok?