Renaming p9 to p9s in libxl idl

Renaming p9 to p9s in libxl idl

[Wei Liu]

Ian and Stefano

Oleksandr discovered that the p9fs array in libxl_domain_config is name
p9 instead of p9s. This causes problem for his work to rework device
framework.

Given that p9fs was added only during last release and the only known
external toolstack libvirt can't possibility use that, maybe we can
rename p9 to p9s. Opinions?

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Renaming p9 to p9s in libxl idl

[Stefano Stabellini]

On Tue, 8 Aug 2017, Wei Liu wrote:
> Ian and Stefano
> 
> Oleksandr discovered that the p9fs array in libxl_domain_config is name
> p9 instead of p9s. This causes problem for his work to rework device
> framework.
> 
> Given that p9fs was added only during last release and the only known
> external toolstack libvirt can't possibility use that, maybe we can
> rename p9 to p9s. Opinions?

stage1-xen uses it:

https://github.com/rkt/stage1-xen/blob/master/files/run

it would be a bit of a problem to change the name now, given that xen 4.9
was released with "p9" in it. We don't know who might be using it. I
think we have to keep handling "p9", possibly in addition to "p9s".

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Renaming p9 to p9s in libxl idl

[Wei Liu]

On Tue, Aug 08, 2017 at 09:19:21AM -0700, Stefano Stabellini wrote:
> On Tue, 8 Aug 2017, Wei Liu wrote:
> > Ian and Stefano
> > 
> > Oleksandr discovered that the p9fs array in libxl_domain_config is name
> > p9 instead of p9s. This causes problem for his work to rework device
> > framework.
> > 
> > Given that p9fs was added only during last release and the only known
> > external toolstack libvirt can't possibility use that, maybe we can
> > rename p9 to p9s. Opinions?
> 
> stage1-xen uses it:
> 
> https://github.com/rkt/stage1-xen/blob/master/files/run
> 

I think this should be fine -- xl shouldn't be affected. I didn't
suggest we change the config option in xl, only in libxl idl.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Renaming p9 to p9s in libxl idl

[Stefano Stabellini]

On Tue, 8 Aug 2017, Wei Liu wrote:
> On Tue, Aug 08, 2017 at 09:19:21AM -0700, Stefano Stabellini wrote:
> > On Tue, 8 Aug 2017, Wei Liu wrote:
> > > Ian and Stefano
> > > 
> > > Oleksandr discovered that the p9fs array in libxl_domain_config is name
> > > p9 instead of p9s. This causes problem for his work to rework device
> > > framework.
> > > 
> > > Given that p9fs was added only during last release and the only known
> > > external toolstack libvirt can't possibility use that, maybe we can
> > > rename p9 to p9s. Opinions?
> > 
> > stage1-xen uses it:
> > 
> > https://github.com/rkt/stage1-xen/blob/master/files/run
> > 
> 
> I think this should be fine -- xl shouldn't be affected. I didn't
> suggest we change the config option in xl, only in libxl idl.

In that case, stage1-xen would be unaffected.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Renaming p9 to p9s in libxl idl

[Jim Fehlig]

On 08/08/2017 09:09 AM, Wei Liu wrote:
> Ian and Stefano
> 
> Oleksandr discovered that the p9fs array in libxl_domain_config is name
> p9 instead of p9s. This causes problem for his work to rework device
> framework.
> 
> Given that p9fs was added only during last release and the only known
> external toolstack libvirt can't possibility use that, maybe we can
> rename p9 to p9s. Opinions?

ATM the libvirt libxl driver doesn't use it, but it could by supporting 
libvirt's <filesystem> device

http://libvirt.org/formatdomain.html#elementsFilesystems

Regards,
Jim

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Renaming p9 to p9s in libxl idl

[Wei Liu]

On Thu, Aug 10, 2017 at 03:42:24PM -0600, Jim Fehlig wrote:
> On 08/08/2017 09:09 AM, Wei Liu wrote:
> > Ian and Stefano
> > 
> > Oleksandr discovered that the p9fs array in libxl_domain_config is name
> > p9 instead of p9s. This causes problem for his work to rework device
> > framework.
> > 
> > Given that p9fs was added only during last release and the only known
> > external toolstack libvirt can't possibility use that, maybe we can
> > rename p9 to p9s. Opinions?
> 
> ATM the libvirt libxl driver doesn't use it, but it could by supporting
> libvirt's <filesystem> device
> 
> http://libvirt.org/formatdomain.html#elementsFilesystems

I think that means all the parameters go directly to QEMU. Without
proper plumbing via libxl driver there won't be anything in the xenstore
hence it isn't useable by Xen guest, right?

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Renaming p9 to p9s in libxl idl

[Stefano Stabellini]

On Fri, 11 Aug 2017, Wei Liu wrote:
> On Thu, Aug 10, 2017 at 03:42:24PM -0600, Jim Fehlig wrote:
> > On 08/08/2017 09:09 AM, Wei Liu wrote:
> > > Ian and Stefano
> > > 
> > > Oleksandr discovered that the p9fs array in libxl_domain_config is name
> > > p9 instead of p9s. This causes problem for his work to rework device
> > > framework.
> > > 
> > > Given that p9fs was added only during last release and the only known
> > > external toolstack libvirt can't possibility use that, maybe we can
> > > rename p9 to p9s. Opinions?
> > 
> > ATM the libvirt libxl driver doesn't use it, but it could by supporting
> > libvirt's <filesystem> device
> > 
> > http://libvirt.org/formatdomain.html#elementsFilesystems
> 
> I think that means all the parameters go directly to QEMU. Without
> proper plumbing via libxl driver there won't be anything in the xenstore
> hence it isn't useable by Xen guest, right?

That's right.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Renaming p9 to p9s in libxl idl

[Jim Fehlig]

On 08/11/2017 05:45 AM, Wei Liu wrote:
> On Thu, Aug 10, 2017 at 03:42:24PM -0600, Jim Fehlig wrote:
>> On 08/08/2017 09:09 AM, Wei Liu wrote:
>>> Ian and Stefano
>>>
>>> Oleksandr discovered that the p9fs array in libxl_domain_config is name
>>> p9 instead of p9s. This causes problem for his work to rework device
>>> framework.
>>>
>>> Given that p9fs was added only during last release and the only known
>>> external toolstack libvirt can't possibility use that, maybe we can
>>> rename p9 to p9s. Opinions?
>>
>> ATM the libvirt libxl driver doesn't use it, but it could by supporting
>> libvirt's <filesystem> device
>>
>> http://libvirt.org/formatdomain.html#elementsFilesystems
> 
> I think that means all the parameters go directly to QEMU. Without
> proper plumbing via libxl driver there won't be anything in the xenstore
> hence it isn't useable by Xen guest, right?

I'm not sure why they have to go directly to QEMU. My naive thinking was to map 
the <filesystem> XML elements/attributes to libxl_device_p9 struct. E.g. 
/domain/devices/filesystem/source@file would map to libxl_device_p9->path, etc.

Regards,
Jim



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Renaming p9 to p9s in libxl idl

[Wei Liu]

On Fri, Aug 11, 2017 at 12:37:04PM -0600, Jim Fehlig wrote:
> On 08/11/2017 05:45 AM, Wei Liu wrote:
> > On Thu, Aug 10, 2017 at 03:42:24PM -0600, Jim Fehlig wrote:
> > > On 08/08/2017 09:09 AM, Wei Liu wrote:
> > > > Ian and Stefano
> > > > 
> > > > Oleksandr discovered that the p9fs array in libxl_domain_config is name
> > > > p9 instead of p9s. This causes problem for his work to rework device
> > > > framework.
> > > > 
> > > > Given that p9fs was added only during last release and the only known
> > > > external toolstack libvirt can't possibility use that, maybe we can
> > > > rename p9 to p9s. Opinions?
> > > 
> > > ATM the libvirt libxl driver doesn't use it, but it could by supporting
> > > libvirt's <filesystem> device
> > > 
> > > http://libvirt.org/formatdomain.html#elementsFilesystems
> > 
> > I think that means all the parameters go directly to QEMU. Without
> > proper plumbing via libxl driver there won't be anything in the xenstore
> > hence it isn't useable by Xen guest, right?
> 
> I'm not sure why they have to go directly to QEMU. My naive thinking was to
> map the <filesystem> XML elements/attributes to libxl_device_p9 struct. E.g.
> /domain/devices/filesystem/source@file would map to libxl_device_p9->path,
> etc.
> 

Right, that would require adding code somewhere in libvirt.git, right?

What I'm trying to figure out is if there could be code is libvirt that
uses the p9 array defined in libxl. It seems to me the answer is no.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Renaming p9 to p9s in libxl idl

[Jim Fehlig]

On 08/11/2017 02:27 PM, Wei Liu wrote:
> On Fri, Aug 11, 2017 at 12:37:04PM -0600, Jim Fehlig wrote:
>> On 08/11/2017 05:45 AM, Wei Liu wrote:
>>> On Thu, Aug 10, 2017 at 03:42:24PM -0600, Jim Fehlig wrote:
>>>> On 08/08/2017 09:09 AM, Wei Liu wrote:
>>>>> Ian and Stefano
>>>>>
>>>>> Oleksandr discovered that the p9fs array in libxl_domain_config is name
>>>>> p9 instead of p9s. This causes problem for his work to rework device
>>>>> framework.
>>>>>
>>>>> Given that p9fs was added only during last release and the only known
>>>>> external toolstack libvirt can't possibility use that, maybe we can
>>>>> rename p9 to p9s. Opinions?
>>>>
>>>> ATM the libvirt libxl driver doesn't use it, but it could by supporting
>>>> libvirt's <filesystem> device
>>>>
>>>> http://libvirt.org/formatdomain.html#elementsFilesystems
>>>
>>> I think that means all the parameters go directly to QEMU. Without
>>> proper plumbing via libxl driver there won't be anything in the xenstore
>>> hence it isn't useable by Xen guest, right?
>>
>> I'm not sure why they have to go directly to QEMU. My naive thinking was to
>> map the <filesystem> XML elements/attributes to libxl_device_p9 struct. E.g.
>> /domain/devices/filesystem/source@file would map to libxl_device_p9->path,
>> etc.
>>
> 
> Right, that would require adding code somewhere in libvirt.git, right?
> 
> What I'm trying to figure out is if there could be code is libvirt that
> uses the p9 array defined in libxl. It seems to me the answer is no.

Correct, not at this time. Perhaps in the near future :-).


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel