From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751125AbdIKUon (ORCPT ); Mon, 11 Sep 2017 16:44:43 -0400 Received: from mail-pg0-f41.google.com ([74.125.83.41]:35057 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbdIKUol (ORCPT ); Mon, 11 Sep 2017 16:44:41 -0400 X-Google-Smtp-Source: ADKCNb4ffckBCMWWzgdY5McUXZz/jBgu9OtrrtmiqZv+aBdccyKOOeSiFJLBIfU7ag7DC6rapD22KA== Date: Mon, 11 Sep 2017 13:44:39 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Roman Gushchin cc: linux-mm@kvack.org, Michal Hocko , Vladimir Davydov , Johannes Weiner , Tetsuo Handa , Andrew Morton , Tejun Heo , kernel-team@fb.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v8 0/4] cgroup-aware OOM killer In-Reply-To: <20170911131742.16482-1-guro@fb.com> Message-ID: References: <20170911131742.16482-1-guro@fb.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Sep 2017, Roman Gushchin wrote: > This patchset makes the OOM killer cgroup-aware. > > v8: > - Do not kill tasks with OOM_SCORE_ADJ -1000 > - Make the whole thing opt-in with cgroup mount option control > - Drop oom_priority for further discussions Nack, we specifically require oom_priority for this to function correctly, otherwise we cannot prefer to kill from low priority leaf memcgs as required. v8 appears to implement new functionality that we want, to compare two memcgs based on usage, but without the ability to influence that decision to protect important userspace, so now I'm in a position where (1) nothing has changed if I don't use the new mount option or (2) I get completely different oom kill selection with the new mount option but not the ability to influence it. I was much happier with the direction that v7 was taking, but since v8 causes us to regress without the ability to change memcg priority, this has to be nacked. > - Kill the whole cgroup if oom_group is set and it's > memory.max is reached > - Update docs and commit messages From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Rientjes Subject: Re: [v8 0/4] cgroup-aware OOM killer Date: Mon, 11 Sep 2017 13:44:39 -0700 (PDT) Message-ID: References: <20170911131742.16482-1-guro@fb.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=1k3aVCvxHxyn94nvcEmm3tTubjsk174oBz410rzv/ZI=; b=Oi+OJEYqaVwYAEgUpgL0IA1jTYUKGYbFbgpPswHIeaJ7c4tWxkXpbBPjFNut3tN/TL dJ1Xjozqt7u4c/CCM+BztGBC6VxaocytyJUKoQW1qxG0VNrF9ySDa6nej1EPhDPxPd3C 53m5RrWxQJkEH+rhAuGYHzgEJXrl+ORh2nxiqF1OSh/fTGPpjB2DrWRx8uyKviwctuUG 2vFgAWqcVrzWUWp+iryjdc3WJALMOIY5dEK0eavX7pPugolqsj3SNGPwI5vFoBtkHiPr DISZsbSqfsuc0PEGMep5doPcSMB5o9ymkeP2SssnXtQlHhn+/1djFvlzEv+hDKpfzw7V d4pw== In-Reply-To: <20170911131742.16482-1-guro@fb.com> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: TEXT/PLAIN; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Roman Gushchin Cc: linux-mm@kvack.org, Michal Hocko , Vladimir Davydov , Johannes Weiner , Tetsuo Handa , Andrew Morton , Tejun Heo , kernel-team@fb.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, 11 Sep 2017, Roman Gushchin wrote: > This patchset makes the OOM killer cgroup-aware. > > v8: > - Do not kill tasks with OOM_SCORE_ADJ -1000 > - Make the whole thing opt-in with cgroup mount option control > - Drop oom_priority for further discussions Nack, we specifically require oom_priority for this to function correctly, otherwise we cannot prefer to kill from low priority leaf memcgs as required. v8 appears to implement new functionality that we want, to compare two memcgs based on usage, but without the ability to influence that decision to protect important userspace, so now I'm in a position where (1) nothing has changed if I don't use the new mount option or (2) I get completely different oom kill selection with the new mount option but not the ability to influence it. I was much happier with the direction that v7 was taking, but since v8 causes us to regress without the ability to change memcg priority, this has to be nacked. > - Kill the whole cgroup if oom_group is set and it's > memory.max is reached > - Update docs and commit messages -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org