From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2NTX-0006M9-PM for qemu-devel@nongnu.org; Wed, 11 Oct 2017 16:19:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2NTT-0002Lp-P3 for qemu-devel@nongnu.org; Wed, 11 Oct 2017 16:19:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:34100) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e2NTT-0002Kn-Iq for qemu-devel@nongnu.org; Wed, 11 Oct 2017 16:19:27 -0400 Date: Wed, 11 Oct 2017 13:19:25 -0700 (PDT) From: Stefano Stabellini In-Reply-To: <20171011154718.GQ1771@perard.uk.xensource.com> Message-ID: References: <1506437019-17946-1-git-send-email-owen.smith@citrix.com> <1506437019-17946-4-git-send-email-owen.smith@citrix.com> <20171002170132.GA2116@perard.uk.xensource.com> <20171011154718.GQ1771@perard.uk.xensource.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-pointer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony PERARD Cc: Stefano Stabellini , Owen Smith , kraxel@redhat.com, xen-devel@lists.xenproject.org, qemu-devel@nongnu.org On Wed, 11 Oct 2017, Anthony PERARD wrote: > On Tue, Oct 10, 2017 at 04:52:48PM -0700, Stefano Stabellini wrote: > > On Mon, 2 Oct 2017, Anthony PERARD wrote: > > > On Tue, Sep 26, 2017 at 02:43:39PM +0000, Owen Smith wrote: > > > > Writes "feature-raw-pointer" during init to indicate the backend > > > > can pass raw unscaled values for absolute axes to the frontend. > > > > Frontends set "request-raw-pointer" to indicate the backend should > > > > not attempt to scale absolute values to console size. > > > > "request-raw-pointer" is only valid if "request-abs-pointer" is > > > > also set. Raw unscaled pointer values are in the range [0, 0x7fff] > > > > > > > > Signed-off-by: Owen Smith > > > > > > Hi Owen, > > > > > > Why did you remove the following from the commit description? > > > > "feature-raw-pointer" and "request-raw-pointer" added to Xen > > > > header in commit 7868654ff7fe5e4a2eeae2b277644fa884a5031e > > > > > > I think that with it, you could have kept stefano's reviewed-by tag. > > > > Hi Anthony, > > > > Have you tested this series with a few of different guests? Do you > > consider it safe to merge? If so, we can send it upstream (either via > > xen or via ui as Gerd kindly offered). > > Yes, I think it's fine. > > The only observation I have is that on a Linux guest, when I have > usbdevice=tablet, with this series the pv mouse seems to become the > primary way of gueting mouse events (without, the tablet is primary). > So, on my VNC client instead of having both mouse in the guest and on my > desktop being at the same place, there is like a zoom of the mouse (the > zoom centered on the top-left corner). (That's better than relative > mouse event that we can get with the emulation.) Thanks for testing. I am not completely sure about what should be the right behavior when both usbdevice=tablet and pvmouse are present. Typically, PV devices take precedence over emulated devices, so maybe it is OK that PV mouse is the primary device in this case. But we would need to document this behavioral change in the commit descriptions. The other question is whether the "zoom of the mouse" you are seeing is normal or whether we can "fix" it somehow. I guess it has always been the case for PV mouse? It is not something new, is it? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-pointer Date: Wed, 11 Oct 2017 13:19:25 -0700 (PDT) Message-ID: References: <1506437019-17946-1-git-send-email-owen.smith@citrix.com> <1506437019-17946-4-git-send-email-owen.smith@citrix.com> <20171002170132.GA2116@perard.uk.xensource.com> <20171011154718.GQ1771@perard.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2NTV-00072O-Ql for xen-devel@lists.xenproject.org; Wed, 11 Oct 2017 20:19:29 +0000 In-Reply-To: <20171011154718.GQ1771@perard.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Anthony PERARD Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Owen Smith , kraxel@redhat.com List-Id: xen-devel@lists.xenproject.org T24gV2VkLCAxMSBPY3QgMjAxNywgQW50aG9ueSBQRVJBUkQgd3JvdGU6Cj4gT24gVHVlLCBPY3Qg MTAsIDIwMTcgYXQgMDQ6NTI6NDhQTSAtMDcwMCwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOgo+ ID4gT24gTW9uLCAyIE9jdCAyMDE3LCBBbnRob255IFBFUkFSRCB3cm90ZToKPiA+ID4gT24gVHVl LCBTZXAgMjYsIDIwMTcgYXQgMDI6NDM6MzlQTSArMDAwMCwgT3dlbiBTbWl0aCB3cm90ZToKPiA+ ID4gPiBXcml0ZXMgImZlYXR1cmUtcmF3LXBvaW50ZXIiIGR1cmluZyBpbml0IHRvIGluZGljYXRl IHRoZSBiYWNrZW5kCj4gPiA+ID4gY2FuIHBhc3MgcmF3IHVuc2NhbGVkIHZhbHVlcyBmb3IgYWJz b2x1dGUgYXhlcyB0byB0aGUgZnJvbnRlbmQuCj4gPiA+ID4gRnJvbnRlbmRzIHNldCAicmVxdWVz dC1yYXctcG9pbnRlciIgdG8gaW5kaWNhdGUgdGhlIGJhY2tlbmQgc2hvdWxkCj4gPiA+ID4gbm90 IGF0dGVtcHQgdG8gc2NhbGUgYWJzb2x1dGUgdmFsdWVzIHRvIGNvbnNvbGUgc2l6ZS4KPiA+ID4g PiAicmVxdWVzdC1yYXctcG9pbnRlciIgaXMgb25seSB2YWxpZCBpZiAicmVxdWVzdC1hYnMtcG9p bnRlciIgaXMKPiA+ID4gPiBhbHNvIHNldC4gUmF3IHVuc2NhbGVkIHBvaW50ZXIgdmFsdWVzIGFy ZSBpbiB0aGUgcmFuZ2UgWzAsIDB4N2ZmZl0KPiA+ID4gPiAKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5 OiBPd2VuIFNtaXRoIDxvd2VuLnNtaXRoQGNpdHJpeC5jb20+Cj4gPiA+IAo+ID4gPiBIaSBPd2Vu LAo+ID4gPiAKPiA+ID4gV2h5IGRpZCB5b3UgcmVtb3ZlIHRoZSBmb2xsb3dpbmcgZnJvbSB0aGUg Y29tbWl0IGRlc2NyaXB0aW9uPwo+ID4gPiA+ICJmZWF0dXJlLXJhdy1wb2ludGVyIiBhbmQgInJl cXVlc3QtcmF3LXBvaW50ZXIiIGFkZGVkIHRvIFhlbgo+ID4gPiA+IGhlYWRlciBpbiBjb21taXQg Nzg2ODY1NGZmN2ZlNWU0YTJlZWFlMmIyNzc2NDRmYTg4NGE1MDMxZQo+ID4gPiAKPiA+ID4gSSB0 aGluayB0aGF0IHdpdGggaXQsIHlvdSBjb3VsZCBoYXZlIGtlcHQgc3RlZmFubydzIHJldmlld2Vk LWJ5IHRhZy4KPiA+IAo+ID4gSGkgQW50aG9ueSwKPiA+IAo+ID4gSGF2ZSB5b3UgdGVzdGVkIHRo aXMgc2VyaWVzIHdpdGggYSBmZXcgb2YgZGlmZmVyZW50IGd1ZXN0cz8gRG8geW91Cj4gPiBjb25z aWRlciBpdCBzYWZlIHRvIG1lcmdlPyBJZiBzbywgd2UgY2FuIHNlbmQgaXQgdXBzdHJlYW0gKGVp dGhlciB2aWEKPiA+IHhlbiBvciB2aWEgdWkgYXMgR2VyZCBraW5kbHkgb2ZmZXJlZCkuIAo+IAo+ IFllcywgSSB0aGluayBpdCdzIGZpbmUuCj4gCj4gVGhlIG9ubHkgb2JzZXJ2YXRpb24gSSBoYXZl IGlzIHRoYXQgb24gYSBMaW51eCBndWVzdCwgd2hlbiBJIGhhdmUKPiB1c2JkZXZpY2U9dGFibGV0 LCB3aXRoIHRoaXMgc2VyaWVzIHRoZSBwdiBtb3VzZSBzZWVtcyB0byBiZWNvbWUgdGhlCj4gcHJp bWFyeSB3YXkgb2YgZ3VldGluZyBtb3VzZSBldmVudHMgKHdpdGhvdXQsIHRoZSB0YWJsZXQgaXMg cHJpbWFyeSkuCj4gU28sIG9uIG15IFZOQyBjbGllbnQgaW5zdGVhZCBvZiBoYXZpbmcgYm90aCBt b3VzZSBpbiB0aGUgZ3Vlc3QgYW5kIG9uIG15Cj4gZGVza3RvcCBiZWluZyBhdCB0aGUgc2FtZSBw bGFjZSwgdGhlcmUgaXMgbGlrZSBhIHpvb20gb2YgdGhlIG1vdXNlICh0aGUKPiB6b29tIGNlbnRl cmVkIG9uIHRoZSB0b3AtbGVmdCBjb3JuZXIpLiAoVGhhdCdzIGJldHRlciB0aGFuIHJlbGF0aXZl Cj4gbW91c2UgZXZlbnQgdGhhdCB3ZSBjYW4gZ2V0IHdpdGggdGhlIGVtdWxhdGlvbi4pCgpUaGFu a3MgZm9yIHRlc3RpbmcuIEkgYW0gbm90IGNvbXBsZXRlbHkgc3VyZSBhYm91dCB3aGF0IHNob3Vs ZCBiZSB0aGUKcmlnaHQgYmVoYXZpb3Igd2hlbiBib3RoIHVzYmRldmljZT10YWJsZXQgYW5kIHB2 bW91c2UgYXJlIHByZXNlbnQuClR5cGljYWxseSwgUFYgZGV2aWNlcyB0YWtlIHByZWNlZGVuY2Ug b3ZlciBlbXVsYXRlZCBkZXZpY2VzLCBzbyBtYXliZQppdCBpcyBPSyB0aGF0IFBWIG1vdXNlIGlz IHRoZSBwcmltYXJ5IGRldmljZSBpbiB0aGlzIGNhc2UuCgpCdXQgd2Ugd291bGQgbmVlZCB0byBk b2N1bWVudCB0aGlzIGJlaGF2aW9yYWwgY2hhbmdlIGluIHRoZSBjb21taXQKZGVzY3JpcHRpb25z LgoKVGhlIG90aGVyIHF1ZXN0aW9uIGlzIHdoZXRoZXIgdGhlICJ6b29tIG9mIHRoZSBtb3VzZSIg eW91IGFyZSBzZWVpbmcgaXMKbm9ybWFsIG9yIHdoZXRoZXIgd2UgY2FuICJmaXgiIGl0IHNvbWVo b3cuIEkgZ3Vlc3MgaXQgaGFzIGFsd2F5cyBiZWVuCnRoZSBjYXNlIGZvciBQViBtb3VzZT8gSXQg aXMgbm90IHNvbWV0aGluZyBuZXcsIGlzIGl0PwoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlz dHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==