From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH 2/3] xen/arm: domain_build: Rework the way to allocate the event channel interrupt Date: Fri, 2 Mar 2018 15:10:47 -0800 (PST) Message-ID: References: <20180227151555.1953-1-julien.grall@arm.com> <20180227151555.1953-3-julien.grall@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ertpG-0003Py-5z for xen-devel@lists.xenproject.org; Fri, 02 Mar 2018 23:10:54 +0000 In-Reply-To: <20180227151555.1953-3-julien.grall@arm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Julien Grall Cc: stewart.hildebrand@dornerworks.com, xen-devel@lists.xenproject.org, sstabellini@kernel.org, andre.przywara@arm.com List-Id: xen-devel@lists.xenproject.org T24gVHVlLCAyNyBGZWIgMjAxOCwganVsaWVuLmdyYWxsQGFybS5jb20gd3JvdGU6Cj4gRnJvbTog SnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4KPiAKPiBBdCB0aGUgbW9tZW50LCBh IHBsYWNlaG9sZGVyIHdpbGwgYmUgY3JlYXRlZCBpbiB0aGUgZGV2aWNlLXRyZWUgZm9yIHRoZQo+ IGV2ZW50IGNoYW5uZWwgaW5mb3JtYXRpb24uIExhdGVyIGluIHRoZSBkb21haW4gY29uc3RydWN0 aW9uLCB0aGUKPiBpbnRlcnJ1cHQgZm9yIHRoZSBldmVudCBjaGFubmVsIHVwY2FsbCB3aWxsIGJl IGFsbG9jYXRlZCB0aGUgZGV2aWNlLXRyZWUKPiBmaXhlZCB1cC4KPiAKPiBMb29raW5nIGF0IHRo ZSBjb2RlLCB0aGUgY3VycmVudCBzcGxpdCBpcyBub3QgbmVjZXNzYXJ5IGJlY2F1c2UgYWxsIHRo ZQo+IFBQSXMgdXNlZCBieSB0aGUgaGFyZHdhcmUgZG9tYWluIHdpbGwgYnkgdGhlIHRpbWUgd2Ug Y3JlYXRlIHRoZSBub2RlIGluCj4gdGhlIGRldmljZS10cmVlLgo+IAo+ID5Gcm9tIG5vdywgbWFu ZGF0ZSB0aGF0IGFsbCBpbnRlcnJ1cHRzIGFyZSByZWdpc3RlcmVkIGJlZm9yZQo+IGFjcGlfcHJl cGFyZSgpIGFuZCBkdGJfcHJlcGFyZSgpLiBUaGlzIGFsbG93cyB1cyB0byByZXdvcmsgdGhlIGV2 ZW50Cj4gY2hhbm5lbCBjb2RlIGFuZCByZW1vdmUgb25lIHBsYWNlaG9sZGVyLgo+IAo+IE5vdGUs IHRoaXMgd2lsbCBhbHNvIGhlbHAgdG8gZml4IHRoZSBCVUcoLi4uKSBjb25kaXRpb24gaW4gc2V0 X2ludGVycnVwdF9wcGkKPiB3aGljaCBpcyBjb21wbGV0ZWx5IHdyb25nLiBTZWUgaW4gYSBmb2xs b3ctdXAgcGF0Y2guCj4gCj4gU2lnbmVkLW9mZi1ieTogSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3Jh bGxAYXJtLmNvbT4KClJldmlld2VkLWJ5OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5p QGtlcm5lbC5vcmc+CgoKPiAtLS0KPiAgeGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jIHwgNzQg KysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBj aGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspLCAzOSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWls ZC5jCj4gaW5kZXggYTVlNWM4MjM1NS4uZWQxYTM5M2JiNSAxMDA2NDQKPiAtLS0gYS94ZW4vYXJj aC9hcm0vZG9tYWluX2J1aWxkLmMKPiArKysgYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMK PiBAQCAtNTc2LDcgKzU3NiwxMCBAQCBzdGF0aWMgaW50IG1ha2VfbWVtb3J5X25vZGUoY29uc3Qg c3RydWN0IGRvbWFpbiAqZCwKPiAgICAgIHJldHVybiByZXM7Cj4gIH0KPiAgCj4gLXN0YXRpYyBp bnQgbWFrZV9oeXBlcnZpc29yX25vZGUoY29uc3Qgc3RydWN0IGtlcm5lbF9pbmZvICpraW5mbywK PiArc3RhdGljIHZvaWQgZXZ0Y2huX2FsbG9jYXRlKHN0cnVjdCBkb21haW4gKmQpOwo+ICsKPiAr c3RhdGljIGludCBtYWtlX2h5cGVydmlzb3Jfbm9kZShzdHJ1Y3QgZG9tYWluICpkLAo+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBrZXJuZWxfaW5mbyAqa2lu Zm8sCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGR0X2Rl dmljZV9ub2RlICpwYXJlbnQpCj4gIHsKPiAgICAgIGNvbnN0IGNoYXIgY29tcGF0W10gPQo+IEBA IC02MjAsMTAgKzYyMywxOCBAQCBzdGF0aWMgaW50IG1ha2VfaHlwZXJ2aXNvcl9ub2RlKGNvbnN0 IHN0cnVjdCBrZXJuZWxfaW5mbyAqa2luZm8sCj4gICAgICAgICAgcmV0dXJuIHJlczsKPiAgCj4g ICAgICAvKgo+IC0gICAgICogUGxhY2Vob2xkZXIgZm9yIHRoZSBldmVudCBjaGFubmVsIGludGVy cnVwdC4gIFRoZSB2YWx1ZXMgd2lsbCBiZQo+IC0gICAgICogcmVwbGFjZWQgbGF0ZXIuCj4gKyAg ICAgKiBJdCBpcyBzYWZlIHRvIGFsbG9jYXRlIHRoZSBldmVudCBjaGFubmVsIGhlcmUgYmVjYXVz ZSBhbGwgdGhlCj4gKyAgICAgKiBQUElzIHVzZWQgYnkgdGhlIGhhcmR3YXJlIGRvbWFpbiBoYXZl IGJlZW4gcmVnaXN0ZXJlZC4KPiArICAgICAqLwo+ICsgICAgZXZ0Y2huX2FsbG9jYXRlKGQpOwo+ ICsKPiArICAgIC8qCj4gKyAgICAgKiBJbnRlcnJ1cHQgZXZlbnQgY2hhbm5lbCB1cGNhbGw6Cj4g KyAgICAgKiAgLSBBY3RpdmUtbG93IGxldmVsLXNlbnNpdGl2ZQo+ICsgICAgICogIC0gQWxsIENQ VXMKPiArICAgICAqICBUT0RPOiBIYW5kbGUgcHJvcGVybHkgdGhlIGNwdW1hc2s7Cj4gICAgICAg Ki8KPiAtICAgIHNldF9pbnRlcnJ1cHRfcHBpKGludHIsIH4wLCAweGYsIElSUV9UWVBFX0lOVkFM SUQpOwo+ICsgICAgc2V0X2ludGVycnVwdF9wcGkoaW50ciwgZC0+YXJjaC5ldnRjaG5faXJxLCAw eGYsIElSUV9UWVBFX0xFVkVMX0xPVyk7Cj4gICAgICByZXMgPSBmZHRfcHJvcGVydHlfaW50ZXJy dXB0cyhmZHQsICZpbnRyLCAxKTsKPiAgICAgIGlmICggcmVzICkKPiAgICAgICAgICByZXR1cm4g cmVzOwo+IEBAIC0xMjgyLDcgKzEyOTMsMTEgQEAgc3RhdGljIGludCBoYW5kbGVfbm9kZShzdHJ1 Y3QgZG9tYWluICpkLCBzdHJ1Y3Qga2VybmVsX2luZm8gKmtpbmZvLAo+ICAKPiAgICAgIGlmICgg bm9kZSA9PSBkdF9ob3N0ICkKPiAgICAgIHsKPiAtICAgICAgICByZXMgPSBtYWtlX2h5cGVydmlz b3Jfbm9kZShraW5mbywgbm9kZSk7Cj4gKyAgICAgICAgLyoKPiArICAgICAgICAgKiBUaGUgaHlw ZXJ2aXNvciBub2RlIHNob3VsZCBhbHdheXMgYmUgY3JlYXRlZCBhZnRlciBhbGwgbm9kZXMKPiAr ICAgICAgICAgKiBmcm9tIHRoZSBob3N0IERUIGhhdmUgYmVlbiBwYXJzZWQuCj4gKyAgICAgICAg ICovCj4gKyAgICAgICAgcmVzID0gbWFrZV9oeXBlcnZpc29yX25vZGUoZCwga2luZm8sIG5vZGUp Owo+ICAgICAgICAgIGlmICggcmVzICkKPiAgICAgICAgICAgICAgcmV0dXJuIHJlczsKPiAgCj4g QEAgLTE5MzksNiArMTk1NCwxMiBAQCBzdGF0aWMgaW50IHByZXBhcmVfYWNwaShzdHJ1Y3QgZG9t YWluICpkLCBzdHJ1Y3Qga2VybmVsX2luZm8gKmtpbmZvKQo+ICAgICAgaWYgKCByYyAhPSAwICkK PiAgICAgICAgICByZXR1cm4gcmM7Cj4gIAo+ICsgICAgLyoKPiArICAgICAqIEFsbCBQUElzIGhh dmUgYmVlbiByZWdpc3RlcmVkLCBhbGxvY2F0ZSB0aGUgZXZlbnQgY2hhbm5lbAo+ICsgICAgICog aW50ZXJydXB0cy4KPiArICAgICAqLwo+ICsgICAgZXZ0Y2huX2FsbG9jYXRlKGQpOwo+ICsKPiAg ICAgIHJldHVybiAwOwo+ICB9Cj4gICNlbHNlCj4gQEAgLTIwMTQsMTYgKzIwMzUsMTggQEAgc3Rh dGljIHZvaWQgaW5pdHJkX2xvYWQoc3RydWN0IGtlcm5lbF9pbmZvICpraW5mbykKPiAgICAgICAg ICBwYW5pYygiVW5hYmxlIHRvIGNvcHkgdGhlIGluaXRyZCBpbiB0aGUgaHdkb20gbWVtb3J5Iik7 Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIGV2dGNobl9maXh1cChzdHJ1Y3QgZG9tYWluICpkLCBz dHJ1Y3Qga2VybmVsX2luZm8gKmtpbmZvKQo+ICsvKgo+ICsgKiBBbGxvY2F0ZSB0aGUgZXZlbnQg Y2hhbm5lbCBQUElzIGFuZCBzZXR1cCB0aGUgSFZNX1BBUkFNX0NBTExCQUNLX0lSUS4KPiArICog VGhlIGFsbG9jYXRlZCBJUlEgd2lsbCBiZSBmb3VuZCBpbiBkLT5hcmNoLmV2dGNobl9pcnEuCj4g KyAqCj4gKyAqIE5vdGUgdGhhdCB0aGlzIHNob3VsZCBvbmx5IGJlIGNhbGxlZCBvbmNlIGFsbCBQ UElzIHVzZWQgYnkgdGhlCj4gKyAqIGhhcmR3YXJlIGRvbWFpbiBoYXZlIGJlZW4gcmVnaXN0ZXJl ZC4KPiArICovCj4gK3N0YXRpYyB2b2lkIGV2dGNobl9hbGxvY2F0ZShzdHJ1Y3QgZG9tYWluICpk KQo+ICB7Cj4gLSAgICBpbnQgcmVzLCBub2RlOwo+ICsgICAgaW50IHJlczsKPiAgICAgIHU2NCB2 YWw7Cj4gLSAgICBnaWNfaW50ZXJydXB0X3QgaW50cjsKPiAgCj4gLSAgICAvKgo+IC0gICAgICog VGhlIGFsbG9jYXRpb24gb2YgdGhlIGV2ZW50IGNoYW5uZWwgSVJRIGhhcyBiZWVuIGRlZmVycmVk IHVudGlsCj4gLSAgICAgKiBub3cuIEF0IHRoaXMgdGltZSwgYWxsIFBQSXMgdXNlZCBieSBET00w IGhhdmUgYmVlbiByZWdpc3RlcmVkLgo+IC0gICAgICovCj4gICAgICByZXMgPSB2Z2ljX2FsbG9j YXRlX3BwaShkKTsKPiAgICAgIGlmICggcmVzIDwgMCApCj4gICAgICAgICAgcGFuaWMoIlVuYWJs ZSB0byBhbGxvY2F0ZSBhIFBQSSBmb3IgdGhlIGV2ZW50IGNoYW5uZWwgaW50ZXJydXB0XG4iKTsK PiBAQCAtMjA0MSwzMSArMjA2NCw2IEBAIHN0YXRpYyB2b2lkIGV2dGNobl9maXh1cChzdHJ1Y3Qg ZG9tYWluICpkLCBzdHJ1Y3Qga2VybmVsX2luZm8gKmtpbmZvKQo+ICAgICAgICAgICAgICAgICAg ICAgICBIVk1fUEFSQU1fQ0FMTEJBQ0tfVFlQRV9QUElfRkxBR19NQVNLKTsKPiAgICAgIHZhbCB8 PSBkLT5hcmNoLmV2dGNobl9pcnE7Cj4gICAgICBkLT5hcmNoLmh2bV9kb21haW4ucGFyYW1zW0hW TV9QQVJBTV9DQUxMQkFDS19JUlFdID0gdmFsOwo+IC0KPiAtICAgIC8qCj4gLSAgICAgKiBXaGVu IGJvb3RpbmcgRG9tMCB1c2luZyBBQ1BJLCBEb20wIGNhbiBvbmx5IGdldCB0aGUgZXZlbnQgY2hh bm5lbAo+IC0gICAgICogaW50ZXJydXB0IHZpYSBoeXBlcmNhbGwuCj4gLSAgICAgKi8KPiAtICAg IGlmICggIWFjcGlfZGlzYWJsZWQgKQo+IC0gICAgICAgIHJldHVybjsKPiAtCj4gLSAgICAvKiBG aXggdXAgImludGVycnVwdHMiIGluIC9oeXBlcnZpc29yIG5vZGUgKi8KPiAtICAgIG5vZGUgPSBm ZHRfcGF0aF9vZmZzZXQoa2luZm8tPmZkdCwgIi9oeXBlcnZpc29yIik7Cj4gLSAgICBpZiAoIG5v ZGUgPCAwICkKPiAtICAgICAgICBwYW5pYygiQ2Fubm90IGZpbmQgdGhlIC9oeXBlcnZpc29yIG5v ZGUiKTsKPiAtCj4gLSAgICAvKiBJbnRlcnJ1cHQgZXZlbnQgY2hhbm5lbCB1cGNhbGw6Cj4gLSAg ICAgKiAgLSBBY3RpdmUtbG93IGxldmVsLXNlbnNpdGl2ZQo+IC0gICAgICogIC0gQWxsIENQVXMK PiAtICAgICAqCj4gLSAgICAgKiAgVE9ETzogSGFuZGxlIHByb3Blcmx5IHRoZSBjcHVtYXNrCj4g LSAgICAgKi8KPiAtICAgIHNldF9pbnRlcnJ1cHRfcHBpKGludHIsIGQtPmFyY2guZXZ0Y2huX2ly cSwgMHhmLAo+IC0gICAgICAgICAgICAgICAgICAgICAgSVJRX1RZUEVfTEVWRUxfTE9XKTsKPiAt ICAgIHJlcyA9IGZkdF9zZXRwcm9wX2lucGxhY2Uoa2luZm8tPmZkdCwgbm9kZSwgImludGVycnVw dHMiLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmaW50ciwgc2l6ZW9mKGludHIp KTsKPiAtICAgIGlmICggcmVzICkKPiAtICAgICAgICBwYW5pYygiQ2Fubm90IGZpeCB1cCBcImlu dGVycnVwdHNcIiBwcm9wZXJ0eSBvZiB0aGUgaHlwZXJ2aXNvciBub2RlIik7Cj4gIH0KPiAgCj4g IHN0YXRpYyB2b2lkIF9faW5pdCBmaW5kX2dudHRhYl9yZWdpb24oc3RydWN0IGRvbWFpbiAqZCwK PiBAQCAtMjE3Nyw4ICsyMTc1LDYgQEAgaW50IGNvbnN0cnVjdF9kb20wKHN0cnVjdCBkb21haW4g KmQpCj4gICAgICBrZXJuZWxfbG9hZCgma2luZm8pOwo+ICAgICAgLyogaW5pdHJkX2xvYWQgd2ls bCBmaXggdXAgdGhlIGZkdCwgc28gY2FsbCBpdCBiZWZvcmUgZHRiX2xvYWQgKi8KPiAgICAgIGlu aXRyZF9sb2FkKCZraW5mbyk7Cj4gLSAgICAvKiBBbGxvY2F0ZSB0aGUgZXZlbnQgY2hhbm5lbCBJ UlEgYW5kIGZpeCB1cCB0aGUgZGV2aWNlIHRyZWUgKi8KPiAtICAgIGV2dGNobl9maXh1cChkLCAm a2luZm8pOwo+ICAgICAgZHRiX2xvYWQoJmtpbmZvKTsKPiAgCj4gICAgICAvKiBOb3cgdGhhdCB3 ZSBhcmUgZG9uZSByZXN0b3JlIHRoZSBvcmlnaW5hbCBwMm0gYW5kIGN1cnJlbnQuICovCj4gLS0g Cj4gMi4xMS4wCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9y ZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs