From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [PATCH v2 08/45] ARM: GIC: extend LR read/write functions to cover EOI and source Date: Fri, 16 Mar 2018 14:43:05 -0700 (PDT) Message-ID: References: <20180315203050.19791-1-andre.przywara@linaro.org> <20180315203050.19791-9-andre.przywara@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ewx84-0006up-58 for xen-devel@lists.xenproject.org; Fri, 16 Mar 2018 21:43:12 +0000 In-Reply-To: <20180315203050.19791-9-andre.przywara@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Andre Przywara Cc: xen-devel@lists.xenproject.org, Julien Grall , Stefano Stabellini , Andre Przywara List-Id: xen-devel@lists.xenproject.org T24gVGh1LCAxNSBNYXIgMjAxOCwgQW5kcmUgUHJ6eXdhcmEgd3JvdGU6Cj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4KPiAKPiBTbyBmYXIgb3VyIExSIHJlYWQvd3Jp dGUgZnVuY3Rpb25zIGRvIG5vdCBoYW5kbGUgdGhlIEVPSSBiaXQgYW5kIHRoZQo+IHNvdXJjZSBD UFVJRCBiaXRzIGluIGFuIExSLCBiZWNhdXNlIHRoZSBjdXJyZW50IFZHSUMgaW1wbGVtZW50YXRp b24gZG9lcwo+IG5vdCB1c2UgdGhlbS4KPiBFeHRlbmQgdGhlIGdpY19sciBkYXRhIHN0cnVjdHVy ZSB0byBob2xkIHRoZXNlIGJpdHMgb2YgaW5mb3JtYXRpb24gYnkKPiB1c2luZyBhIHVuaW9uIHRv IGRpZmZlcmVudGlhdGUgZmllbGQgdXNlZCBkZXBlbmRpbmcgb24gd2hldGhlciB0aGUgdklSUQo+ IGhhcyBhIGNvcnJlc3BvbmRpbmcgcElSUS4KPiAKPiBUaGlzIGFsbG93cyB0aGUgbmV3IFZHSUMg dG8gdXNlIHRoaXMgaW5mb3JtYXRpb24uCj4gCj4gVGhpcyBpcyBiYXNlZCBvbiB0aGUgb3JpZ2lu YWwgcGF0Y2ggc2VudCBieSBBbmRyZSBQcnp5d2FyYSBbMV0uCj4gCj4gWzFdIGh0dHBzOi8vbGlz dHMueGVucHJvamVjdC5vcmcvYXJjaGl2ZXMvaHRtbC94ZW4tZGV2ZWwvMjAxOC0wMy9tc2cwMDQz NS5odG1sCj4gCj4gU2lnbmVkLW9mZi1ieTogSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJt LmNvbT4KPiBSZXZpZXdlZC1ieTogQW5kcmUgUHJ6eXdhcmEgPGFuZHJlLnByenl3YXJhQGFybS5j b20+Cj4gU2lnbmVkLW9mZi1ieTogQW5kcmUgUHJ6eXdhcmEgPGFuZHJlLnByenl3YXJhQGFybS5j b20+CgpBY2tlZC1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3Jn PgoKPiAtLS0KPiBDaGFuZ2VzOgo+IC0gUmVzZXQgYXV0aG9yc2hpcAo+IC0gUmV3b3JrIHNvdXJj ZQo+IC0gQWRkIHNvdXJjZSBzdXBwb3J0IG9uIEdJQ3YzCj4gCj4gIHhlbi9hcmNoL2FybS9naWMt djIuYyAgICAgICAgICAgICB8IDI2ICsrKysrKysrKysrKysrKysrKysrKysrLS0tCj4gIHhlbi9h cmNoL2FybS9naWMtdjMuYyAgICAgICAgICAgICB8IDM0ICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKystLS0KPiAgeGVuL2luY2x1ZGUvYXNtLWFybS9naWMuaCAgICAgICAgIHwgMTYgKysr KysrKysrKysrKystLQo+ICB4ZW4vaW5jbHVkZS9hc20tYXJtL2dpY192M19kZWZzLmggfCAgMiAr Kwo+ICA0IGZpbGVzIGNoYW5nZWQsIDcwIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9naWMtdjIuYyBiL3hlbi9hcmNoL2FybS9naWMt djIuYwo+IGluZGV4IDJmMDEyNjkyZTAuLjdkZmU2ZmM2OGQgMTAwNjQ0Cj4gLS0tIGEveGVuL2Fy Y2gvYXJtL2dpYy12Mi5jCj4gKysrIGIveGVuL2FyY2gvYXJtL2dpYy12Mi5jCj4gQEAgLTQ3NCw4 ICs0NzQsMTcgQEAgc3RhdGljIHZvaWQgZ2ljdjJfcmVhZF9scihpbnQgbHIsIHN0cnVjdCBnaWNf bHIgKmxyX3JlZykKPiAgCj4gICAgICBpZiAoIGxyX3JlZy0+aHdfc3RhdHVzICkKPiAgICAgIHsK PiAtICAgICAgICBscl9yZWctPnBpcnEgPSBscnYgPj4gR0lDSF9WMl9MUl9QSFlTSUNBTF9TSElG VDsKPiAtICAgICAgICBscl9yZWctPnBpcnEgJj0gR0lDSF9WMl9MUl9QSFlTSUNBTF9NQVNLOwo+ ICsgICAgICAgIGxyX3JlZy0+aHcucGlycSA9IGxydiA+PiBHSUNIX1YyX0xSX1BIWVNJQ0FMX1NI SUZUOwo+ICsgICAgICAgIGxyX3JlZy0+aHcucGlycSAmPSBHSUNIX1YyX0xSX1BIWVNJQ0FMX01B U0s7Cj4gKyAgICB9Cj4gKyAgICBlbHNlCj4gKyAgICB7Cj4gKyAgICAgICAgbHJfcmVnLT52aXJ0 LmVvaSA9IChscnYgJiBHSUNIX1YyX0xSX01BSU5URU5BTkNFX0lSUSk7Cj4gKyAgICAgICAgaWYg KCBscl9yZWctPnZpcnEgPCBOUl9HSUNfU0dJICkKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAg IGxyX3JlZy0+dmlydC5zb3VyY2UgPSAobHJ2ID4+IEdJQ0hfVjJfTFJfQ1BVSURfU0hJRlQpCj4g KyAgICAgICAgICAgICAgICAmIEdJQ0hfVjJfTFJfQ1BVSURfTUFTSzsKPiArICAgICAgICB9Cj4g ICAgICB9Cj4gIH0KPiAgCj4gQEAgLTQ5Niw3ICs1MDUsMTggQEAgc3RhdGljIHZvaWQgZ2ljdjJf d3JpdGVfbHIoaW50IGxyLCBjb25zdCBzdHJ1Y3QgZ2ljX2xyICpscl9yZWcpCj4gICAgICBpZiAo IGxyX3JlZy0+aHdfc3RhdHVzICkKPiAgICAgIHsKPiAgICAgICAgICBscnYgfD0gR0lDSF9WMl9M Ul9IVzsKPiAtICAgICAgICBscnYgfD0gbHJfcmVnLT5waXJxIDw8IEdJQ0hfVjJfTFJfUEhZU0lD QUxfU0hJRlQ7Cj4gKyAgICAgICAgbHJ2IHw9IGxyX3JlZy0+aHcucGlycSA8PCBHSUNIX1YyX0xS X1BIWVNJQ0FMX1NISUZUOwo+ICsgICAgfQo+ICsgICAgZWxzZQo+ICsgICAgewo+ICsgICAgICAg IGlmICggbHJfcmVnLT52aXJ0LmVvaSApCj4gKyAgICAgICAgICAgIGxydiB8PSBHSUNIX1YyX0xS X01BSU5URU5BTkNFX0lSUTsKPiArICAgICAgICAvKgo+ICsgICAgICAgICAqIFRoaXMgaXMgb25s eSB2YWxpZCBmb3IgU0dJLCBidXQgaXQgZG9lcyBub3QgbWF0dGVyIHRvIGFsd2F5cwo+ICsgICAg ICAgICAqIHJlYWQgaXQgYXMgaXQgc2hvdWxkIGJlIDAgYnkgZGVmYXVsdC4KPiArICAgICAgICAg Ki8KPiArICAgICAgICBBU1NFUlQoIWxyX3JlZy0+dmlydC5zb3VyY2UgfHwgbHJfcmVnLT52aXJx IDwgTlJfR0lDX1NHSSk7Cj4gKyAgICAgICAgbHJ2IHw9ICh1aW50MzJfdClscl9yZWctPnZpcnQu c291cmNlIDw8IEdJQ0hfVjJfTFJfQ1BVSURfU0hJRlQ7Cj4gICAgICB9Cj4gIAo+ICAgICAgd3Jp dGVsX2dpY2gobHJ2LCBHSUNIX0xSICsgbHIgKiA0KTsKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gv YXJtL2dpYy12My5jIGIveGVuL2FyY2gvYXJtL2dpYy12My5jCj4gaW5kZXggZTkwMTIxMGI3OC4u MzkyY2Y5MWI1OCAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC9hcm0vZ2ljLXYzLmMKPiArKysgYi94 ZW4vYXJjaC9hcm0vZ2ljLXYzLmMKPiBAQCAtMTAxNCwxMiArMTAxNCwyNSBAQCBzdGF0aWMgdm9p ZCBnaWN2M19yZWFkX2xyKGludCBsciwgc3RydWN0IGdpY19sciAqbHJfcmVnKQo+ICAgICAgbHJf cmVnLT5od19zdGF0dXMgPSBscnYgJiBJQ0hfTFJfSFc7Cj4gIAo+ICAgICAgaWYgKCBscl9yZWct Pmh3X3N0YXR1cyApCj4gLSAgICAgICAgbHJfcmVnLT5waXJxID0gKGxydiA+PiBJQ0hfTFJfUEhZ U0lDQUxfU0hJRlQpICYgSUNIX0xSX1BIWVNJQ0FMX01BU0s7Cj4gKyAgICAgICAgbHJfcmVnLT5o dy5waXJxID0gKGxydiA+PiBJQ0hfTFJfUEhZU0lDQUxfU0hJRlQpICYgSUNIX0xSX1BIWVNJQ0FM X01BU0s7Cj4gKyAgICBlbHNlCj4gKyAgICB7Cj4gKyAgICAgICAgbHJfcmVnLT52aXJ0LmVvaSA9 IChscnYgJiBJQ0hfTFJfTUFJTlRFTkFOQ0VfSVJRKTsKPiArICAgICAgICAvKiBTb3VyY2Ugb25s eSBleGlzdHMgZm9yIFNHSSBhbmQgaW4gR0lDdjIgY29tcGF0aWJsZSBtb2RlICovCj4gKyAgICAg ICAgaWYgKCBscl9yZWctPnZpcnEgPCBOUl9HSUNfU0dJICYmCj4gKyAgICAgICAgICAgICBjdXJy ZW50LT5kb21haW4tPmFyY2gudmdpYy52ZXJzaW9uID09IEdJQ19WMiApCj4gKyAgICAgICAgewo+ ICsgICAgICAgICAgICBscl9yZWctPnZpcnQuc291cmNlID0gKGxydiA+PiBJQ0hfTFJfQ1BVSURf U0hJRlQpCj4gKyAgICAgICAgICAgICAgICAmIElDSF9MUl9DUFVJRF9NQVNLOwo+ICsgICAgICAg IH0KPiArICAgIH0KPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgZ2ljdjNfd3JpdGVfbHIoaW50IGxy X3JlZywgY29uc3Qgc3RydWN0IGdpY19sciAqbHIpCj4gIHsKPiAgICAgIHVpbnQ2NF90IGxydiA9 IDA7Cj4gKyAgICBjb25zdCBlbnVtIGdpY192ZXJzaW9uIHZnaWNfdmVyc2lvbiA9IGN1cnJlbnQt PmRvbWFpbi0+YXJjaC52Z2ljLnZlcnNpb247Cj4gKwo+ICAKPiAgICAgIGxydiA9ICggKCh1NjQp KGxyLT52aXJxICYgSUNIX0xSX1ZJUlRVQUxfTUFTSykgIDw8IElDSF9MUl9WSVJUVUFMX1NISUZU KSB8Cj4gICAgICAgICAgKCh1NjQpKGxyLT5wcmlvcml0eSAmIElDSF9MUl9QUklPUklUWV9NQVNL KSA8PCBJQ0hfTFJfUFJJT1JJVFlfU0hJRlQpICk7Cj4gQEAgLTEwMzMsMTQgKzEwNDYsMjkgQEAg c3RhdGljIHZvaWQgZ2ljdjNfd3JpdGVfbHIoaW50IGxyX3JlZywgY29uc3Qgc3RydWN0IGdpY19s ciAqbHIpCj4gICAgICBpZiAoIGxyLT5od19zdGF0dXMgKQo+ICAgICAgewo+ICAgICAgICAgIGxy diB8PSBJQ0hfTFJfSFc7Cj4gLSAgICAgICAgbHJ2IHw9ICh1aW50NjRfdClsci0+cGlycSA8PCBJ Q0hfTFJfUEhZU0lDQUxfU0hJRlQ7Cj4gKyAgICAgICAgbHJ2IHw9ICh1aW50NjRfdClsci0+aHcu cGlycSA8PCBJQ0hfTFJfUEhZU0lDQUxfU0hJRlQ7Cj4gKyAgICB9Cj4gKyAgICBlbHNlCj4gKyAg ICB7Cj4gKyAgICAgICAgaWYgKCBsci0+dmlydC5lb2kgKQo+ICsgICAgICAgICAgICBscnYgfD0g SUNIX0xSX01BSU5URU5BTkNFX0lSUTsKPiArICAgICAgICAvKiBTb3VyY2UgaXMgb25seSBzZXQg aW4gR0lDdjIgY29tcGF0aWJsZSBtb2RlICovCj4gKyAgICAgICAgaWYgKCB2Z2ljX3ZlcnNpb24g PT0gR0lDX1YyICkKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIC8qCj4gKyAgICAgICAgICAg ICAqIFRoaXMgaXMgb25seSB2YWxpZCBmb3IgU0dJLCBidXQgaXQgZG9lcyBub3QgbWF0dGVyIHRv IGFsd2F5cwo+ICsgICAgICAgICAgICAgKiByZWFkIGl0IGFzIGl0IHNob3VsZCBiZSAwIGJ5IGRl ZmF1bHQuCj4gKyAgICAgICAgICAgICAqLwo+ICsgICAgICAgICAgICBBU1NFUlQoIWxyLT52aXJ0 LnNvdXJjZSB8fCBsci0+dmlycSA8IE5SX0dJQ19TR0kpOwo+ICsgICAgICAgICAgICBscnYgfD0g KHVpbnQ2NF90KWxyLT52aXJ0LnNvdXJjZSA8PCBJQ0hfTFJfQ1BVSURfU0hJRlQ7Cj4gKyAgICAg ICAgfQo+ICAgICAgfQo+ICAKPiAgICAgIC8qCj4gICAgICAgKiBXaGVuIHRoZSBndWVzdCBpcyB1 c2luZyB2R0lDdjMsIGFsbCB0aGUgSVJRcyBhcmUgR3JvdXAgMS4gR3JvdXAgMAo+ICAgICAgICog d291bGQgcmVzdWx0IGluIGEgRklRLCB3aGljaCB3aWxsIG5vdCBiZSBleHBlY3RlZCBieSB0aGUg Z3Vlc3QgT1MuCj4gICAgICAgKi8KPiAtICAgIGlmICggY3VycmVudC0+ZG9tYWluLT5hcmNoLnZn aWMudmVyc2lvbiA9PSBHSUNfVjMgKQo+ICsgICAgaWYgKCB2Z2ljX3ZlcnNpb24gPT0gR0lDX1Yz ICkKPiAgICAgICAgICBscnYgfD0gSUNIX0xSX0dSUDE7Cj4gIAo+ICAgICAgZ2ljdjNfaWNoX3dy aXRlX2xyKGxyX3JlZywgbHJ2KTsKPiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLWFybS9n aWMuaCBiL3hlbi9pbmNsdWRlL2FzbS1hcm0vZ2ljLmgKPiBpbmRleCA1NDU5MDFiMTIwLi41NjVi MDg3NWNhIDEwMDY0NAo+IC0tLSBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vZ2ljLmgKPiArKysgYi94 ZW4vaW5jbHVkZS9hc20tYXJtL2dpYy5oCj4gQEAgLTIwNCwxNCArMjA0LDI2IEBAIHVuaW9uIGdp Y19zdGF0ZV9kYXRhIHsKPiAgICogVGhlIExSIHJlZ2lzdGVyIGZvcm1hdCBpcyBkaWZmZXJlbnQg Zm9yIEdJQyBIVyB2ZXJzaW9uCj4gICAqLwo+ICBzdHJ1Y3QgZ2ljX2xyIHsKPiAtICAgLyogUGh5 c2ljYWwgSVJRIC0+IE9ubHkgc2V0IHdoZW4gaHdfc3RhdHVzIGlzIHNldC4gKi8KPiAtICAgdWlu dDMyX3QgcGlycTsKPiAgICAgLyogVmlydHVhbCBJUlEgKi8KPiAgICAgdWludDMyX3QgdmlycTsK PiAgICAgdWludDhfdCBwcmlvcml0eTsKPiAgICAgYm9vbCBhY3RpdmU7Cj4gICAgIGJvb2wgcGVu ZGluZzsKPiAgICAgYm9vbCBod19zdGF0dXM7Cj4gKyAgIHVuaW9uCj4gKyAgIHsKPiArICAgICAg IC8qIE9ubHkgZmlsbGVkIHdoZW4gdGhlcmUgYXJlIGEgY29ycmVzcG9uZGluZyBwSVJRIChod19z dGF0ZSA9IHRydWUpICovCj4gKyAgICAgICBzdHJ1Y3QKPiArICAgICAgIHsKPiArICAgICAgICAg ICB1aW50MzJfdCBwaXJxOwo+ICsgICAgICAgfSBodzsKPiArICAgICAgIC8qIE9ubHkgZmlsbGVk IHdoZW4gdGhlcmUgYXJlIG5vIGNvcnJlc3BvbmRpbmcgcElSUSAoaHdfc3RhdGUgPSBmYWxzZSkg Ki8KPiArICAgICAgIHN0cnVjdAo+ICsgICAgICAgewo+ICsgICAgICAgICAgIGJvb2wgZW9pOwo+ ICsgICAgICAgICAgIHVpbnQ4X3Qgc291cmNlOyAgICAgIC8qIEdJQ3YyIG9ubHkgKi8KPiArICAg ICAgIH0gdmlydDsKPiArICAgfTsKPiAgfTsKPiAgCj4gIGVudW0gZ2ljX3ZlcnNpb24gewo+IGRp ZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20tYXJtL2dpY192M19kZWZzLmggYi94ZW4vaW5jbHVk ZS9hc20tYXJtL2dpY192M19kZWZzLmgKPiBpbmRleCBkOTgyN2JkODRjLi4xMGEyYWVlYTkzIDEw MDY0NAo+IC0tLSBhL3hlbi9pbmNsdWRlL2FzbS1hcm0vZ2ljX3YzX2RlZnMuaAo+ICsrKyBiL3hl bi9pbmNsdWRlL2FzbS1hcm0vZ2ljX3YzX2RlZnMuaAo+IEBAIC0xNjcsNiArMTY3LDggQEAKPiAg Cj4gICNkZWZpbmUgSUNIX0xSX1ZJUlRVQUxfTUFTSyAgICAgICAgICAweGZmZmYKPiAgI2RlZmlu ZSBJQ0hfTFJfVklSVFVBTF9TSElGVCAgICAgICAgIDAKPiArI2RlZmluZSBJQ0hfTFJfQ1BVSURf TUFTSyAgICAgICAgICAgIDB4Nwo+ICsjZGVmaW5lIElDSF9MUl9DUFVJRF9TSElGVCAgICAgICAg ICAgMTAKPiAgI2RlZmluZSBJQ0hfTFJfUEhZU0lDQUxfTUFTSyAgICAgICAgIDB4M2ZmCj4gICNk ZWZpbmUgSUNIX0xSX1BIWVNJQ0FMX1NISUZUICAgICAgICAzMgo+ICAjZGVmaW5lIElDSF9MUl9T VEFURV9NQVNLICAgICAgICAgICAgMHgzCj4gLS0gCj4gMi4xNC4xCj4gCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0 Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qu b3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs