From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ex13-edg-ou-002.vmware.com ([208.91.0.190]:14186 "EHLO EX13-EDG-OU-002.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbeCTS5u (ORCPT ); Tue, 20 Mar 2018 14:57:50 -0400 Date: Tue, 20 Mar 2018 11:42:47 -0700 From: Shrikrishna Khare To: David Miller CC: , , , , , Subject: Re: [PATCH] vmxnet3: fix LRO feature check In-Reply-To: <20180320.105722.15146213885137044.davem@davemloft.net> Message-ID: References: <20180317075852.11785-1-ipylypiv@silver-peak.com> <201803181411.VTfldbIf%fengguang.wu@intel.com> <20180320.105722.15146213885137044.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 20 Mar 2018, David Miller wrote: > From: kbuild test robot > Date: Sun, 18 Mar 2018 14:37:35 +0800 > > > All warnings (new ones prefixed by >>): > > > > drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_rx_complete': > >>> drivers/net/vmxnet3/vmxnet3_drv.c:1474:8: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' [-Wparentheses] > > !adapter->netdev->features & NETIF_F_LRO) { > > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > Igor, I will fix this up for you. But it is clear that this patch wasn't tested > very well. > > Because !adapter->netdev->features evaluates wholly before the "& NETIF_F_LRO", > the flags aren't being tested properly at all. Ronak's patch that fixes this issue has the right code, and is already accepted in net tree (Commit: 034f405793897a3c8f642935f5494b86c340cde7). We no longer need Igor's patch. Thanks, Shri