From: Stefano Stabellini <sstabellini@kernel.org>
To: Andrii Anisov <andrii_anisov@epam.com>
Cc: artem_mygaiev@epam.com, lars.kurth@citrix.com,
Stefano Stabellini <sstabellini@kernel.org>,
dfaggioli@suse.com, julien.grall@arm.com, jbeulich@suse.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH v3 07/10] arm: make it possible to disable the SMMU driver
Date: Wed, 23 May 2018 12:16:51 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1805231212550.15101@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <beec5a83-fe7b-65e9-14ca-4ecb498760bd@epam.com>
On Wed, 23 May 2018, Andrii Anisov wrote:
> Hello Stefano,
>
>
> On 23.05.18 03:25, Stefano Stabellini wrote:
> > Introduce a Kconfig option for the ARM SMMUv1 and SMMUv2 driver.
> >
> > Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
> > CC: jbeulich@suse.com
> >
> > ---
> > Changes in v3:
> > - rename SMMUv2 to ARM_SMMU
> > - improve help message
> > - use if ARM
> >
> > Changes in v2:
> > - rename HAS_SMMUv2 to SMMUv2
> > - move SMMUv2 to xen/drivers/passthrough/Kconfig
> > ---
> > xen/drivers/passthrough/Kconfig | 12 ++++++++++++
> > xen/drivers/passthrough/arm/Makefile | 2 +-
> > 2 files changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/xen/drivers/passthrough/Kconfig
> > b/xen/drivers/passthrough/Kconfig
> > index 8d90b67..a3c0649 100644
> > --- a/xen/drivers/passthrough/Kconfig
> > +++ b/xen/drivers/passthrough/Kconfig
> > @@ -1,3 +1,15 @@
> > config HAS_PASSTHROUGH
> > bool
> > +
> > +if ARM
> > +config ARM_SMMU
> > + bool "ARM SMMUv1 and v2 driver"
> > + default y
> Did you mean here "default n"? So in a platform selecting configs patch you
> silently skipping it for QEMU and RCAR3, but enabling for MPSOC?
I meant "default y" because I am only trying to introduce the options
in this patch series, I am not trying to change the defaults (yet).
In any case, even with "default y" it works as intended if you start
from tiny.config.
1) cp arch/arm/configs/tiny.conf .config
2) make olddefconfig
3) make menuconfig -> select RCAR3
the results is that ARM_SMMU will be disabled because it is already
disabled in tiny.config and CONFIG_RCAR3 won't enable it.
> > + ---help---
> > + Support for implementations of the ARM System MMU architecture
> > + versions 1 and 2.
> > +
> > + Say Y here if your SoC includes an IOMMU device implementing the
> > + ARM SMMU architecture.
> > +endif
> > diff --git a/xen/drivers/passthrough/arm/Makefile
> > b/xen/drivers/passthrough/arm/Makefile
> > index f4cd26e..0156431 100644
> > --- a/xen/drivers/passthrough/arm/Makefile
> > +++ b/xen/drivers/passthrough/arm/Makefile
> > @@ -1,2 +1,2 @@
> > obj-y += iommu.o
> > -obj-y += smmu.o
> > +obj-$(ARM_SMMU) += smmu.o
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-05-23 19:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 0:24 [PATCH v3 0/10] arm: more kconfig configurability and small default configs Stefano Stabellini
2018-05-23 0:24 ` [PATCH v3 01/10] arm: remove the ARM HDLCD driver Stefano Stabellini
2018-05-29 13:37 ` Julien Grall
2018-05-23 0:25 ` [PATCH v3 02/10] arm: make it possible to disable HAS_GICV3 Stefano Stabellini
2018-05-29 13:38 ` Julien Grall
2018-05-23 0:25 ` [PATCH v3 03/10] arm: rename HAS_GICV3 to GICV3 Stefano Stabellini
2018-05-29 13:39 ` Julien Grall
2018-05-23 0:25 ` [PATCH v3 04/10] Make MEM_ACCESS configurable Stefano Stabellini
2018-05-29 11:50 ` Jan Beulich
2018-05-30 20:24 ` Stefano Stabellini
2018-05-30 22:19 ` Tamas K Lengyel
2018-06-01 7:30 ` Jan Beulich
2018-05-23 0:25 ` [PATCH v3 05/10] make it possible to enable/disable UART drivers Stefano Stabellini
2018-05-29 12:02 ` Jan Beulich
2018-05-23 0:25 ` [PATCH v3 06/10] xen: remove HAS_ prefix from UART Kconfig options Stefano Stabellini
2018-05-29 12:06 ` Jan Beulich
2018-05-30 20:33 ` Stefano Stabellini
2018-05-23 0:25 ` [PATCH v3 07/10] arm: make it possible to disable the SMMU driver Stefano Stabellini
2018-05-23 17:54 ` Andrii Anisov
2018-05-23 19:16 ` Stefano Stabellini [this message]
2018-05-24 8:01 ` Andrii Anisov
2018-05-29 12:07 ` Jan Beulich
2018-05-29 13:40 ` Julien Grall
2018-05-23 0:25 ` [PATCH v3 08/10] arm: add a tiny kconfig configuration Stefano Stabellini
2018-05-23 0:25 ` [PATCH v3 09/10] arm: add QEMU, Rcar3 and MPSoC configs Stefano Stabellini
2018-05-29 14:07 ` Julien Grall
2018-05-30 21:39 ` Stefano Stabellini
2018-05-30 22:38 ` Julien Grall
2018-05-31 21:38 ` Stefano Stabellini
2018-06-04 15:58 ` Julien Grall
2018-05-23 0:25 ` [PATCH v3 10/10] xen: add cloc target Stefano Stabellini
2018-05-29 12:15 ` Jan Beulich
2018-05-30 0:50 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1805231212550.15101@sstabellini-ThinkPad-X260 \
--to=sstabellini@kernel.org \
--cc=andrii_anisov@epam.com \
--cc=artem_mygaiev@epam.com \
--cc=dfaggioli@suse.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=lars.kurth@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.