From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: Re: [RFC 07/16] xen/arm: p2m: Introduce p2m_is_valid and use it Date: Fri, 2 Nov 2018 15:45:26 -0700 (PDT) Message-ID: References: <20181008183352.16291-1-julien.grall@arm.com> <20181008183352.16291-8-julien.grall@arm.com> <80fb5961-5093-4044-8e16-cdc85497805c@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <80fb5961-5093-4044-8e16-cdc85497805c@arm.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Julien Grall Cc: Stefano Stabellini , andre.przywara@linaro.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gVHVlLCAzMCBPY3QgMjAxOCwgSnVsaWVuIEdyYWxsIHdyb3RlOgo+IEhpLAo+IAo+IE9uIDMw LzEwLzIwMTggMDA6MjEsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToKPiA+IE9uIE1vbiwgOCBP Y3QgMjAxOCwgSnVsaWVuIEdyYWxsIHdyb3RlOgo+ID4gPiBUaGUgTFBBRSBmb3JtYXQgYWxsb3dz IHRvIHN0b3JlIGluZm9ybWF0aW9uIGluIGFuIGVudHJ5IGV2ZW4gd2l0aCB0aGUKPiA+ID4gdmFs aWQgYml0IHVuc2V0LiBJbiBhIGZvbGxvdy11cCBwYXRjaCwgd2Ugd2lsbCB0YWtlIGFkdmFudGFn ZSBvZiB0aGlzCj4gPiA+IGZlYXR1cmUgdG8gcmUtcHVycG9zZSB0aGUgdmFsaWQgYml0IGZvciBn ZW5lcmF0aW5nIGEgdHJhbnNsYXRpb24gZmF1bHQKPiA+ID4gZXZlbiBpZiBhbiBlbnRyeSBjb250 YWlucyB2YWxpZCBpbmZvcm1hdGlvbi4KPiA+ID4gCj4gPiA+IFNvIHdlIG5lZWQgYSBkaWZmZXJl bnQgd2F5IHRvIGtub3cgd2hldGhlciBhbiBlbnRyeSBjb250YWlucyB2YWxpZAo+ID4gPiBpbmZv cm1hdGlvbi4gSXQgaXMgcG9zc2libGUgdG8gdXNlIHRoZSBpbmZvcm1hdGlvbiBob2xkIGluIHRo ZSBwMm1fdHlwZQo+ID4gPiB0byBrbm93IGZvciB0aGF0IHB1cnBvc2UuIEluZGVlZCBhbGwgZW50 cmllcyBjb250YWluaW5nIHZhbGlkCj4gPiA+IGluZm9ybWF0aW9uIHdpbGwgaGF2ZSBhIHZhbGlk IHAybSB0eXBlIChpLmUgcDJtX3R5cGUgIT0gcDJtX2ludmFsaWQpLgo+ID4gPiAKPiA+ID4gVGhp cyBwYXRjaCBpbnRyb2R1Y2VzIGEgbmV3IGhlbHBlciBwMm1faXNfdmFsaWQsIHdoaWNoIGltcGxl bWVudHMgdGhhdAo+ID4gPiBpZGVhLCBhbmQgcmVwbGFjZSBtb3N0IG9mIGxwYWVfaXNfdmFsaWQg Y2FsbCB3aXRoIHRoZSBuZXcgaGVscGVyLiBUaGUgb25lcwo+ID4gPiByZW1haW5pbmcgYXJlIGZv ciBUTEJzIGhhbmRsaW5nIGFuZCBlbnRyaWVzIGFjY291bnRpbmcuCj4gPiA+IAo+ID4gPiBXaXRo IHRoZSByZW5hbWluZyB0aGVyZSBhcmUgMiBvdGhlcnMgY2hhbmdlcyByZXF1aXJlZDoKPiA+ID4g ICAgICAtIEdlbmVyYXRlIHRhYmxlIGVudHJ5IHdpdGggYSB2YWxpZCBwMm0gdHlwZQo+ID4gPiAg ICAgIC0gRGV0ZWN0IG5ldyBtYXBwaW5nIGZvciBwcm9wZXIgc3RhdHMgYWNjb3VudGluZwo+ID4g PiAKPiA+ID4gU2lnbmVkLW9mZi1ieTogSnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNv bT4KPiA+ID4gLS0tCj4gPiA+ICAgeGVuL2FyY2gvYXJtL3AybS5jIHwgMzQgKysrKysrKysrKysr KysrKysrKysrKystLS0tLS0tLS0tLQo+ID4gPiAgIDEgZmlsZSBjaGFuZ2VkLCAyMyBpbnNlcnRp b25zKCspLCAxMSBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJj aC9hcm0vcDJtLmMgYi94ZW4vYXJjaC9hcm0vcDJtLmMKPiA+ID4gaW5kZXggNmM3NjI5OGViYy4u MmExZTdlOWJlMiAxMDA2NDQKPiA+ID4gLS0tIGEveGVuL2FyY2gvYXJtL3AybS5jCj4gPiA+ICsr KyBiL3hlbi9hcmNoL2FybS9wMm0uYwo+ID4gPiBAQCAtMjIwLDE3ICsyMjAsMjYgQEAgc3RhdGlj IHAybV9hY2Nlc3NfdCBwMm1fbWVtX2FjY2Vzc19yYWRpeF9nZXQoc3RydWN0Cj4gPiA+IHAybV9k b21haW4gKnAybSwgZ2ZuX3QgZ2ZuKQo+ID4gPiAgIH0KPiA+ID4gICAgIC8qCj4gPiA+ICsgKiBJ biB0aGUgY2FzZSBvZiB0aGUgUDJNLCB0aGUgdmFsaWQgYml0IGlzIHVzZWQgZm9yIG90aGVyIHB1 cnBvc2UuIFVzZQo+ID4gPiArICogdGhlIHR5cGUgdG8gY2hlY2sgd2hldGhlciBhbiBlbnRyeSBp cyB2YWxpZC4KPiA+ID4gKyAqLwo+ID4gPiArc3RhdGljIGlubGluZSBib29sIHAybV9pc192YWxp ZChscGFlX3QgcHRlKQo+ID4gPiArewo+ID4gPiArICAgIHJldHVybiBwdGUucDJtLnR5cGUgIT0g cDJtX2ludmFsaWQ7Cj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4gKy8qCj4gPiA+ICAgICogbHBhZV9p c18qIGhlbHBlcnMgZG9uJ3QgY2hlY2sgd2hldGhlciB0aGUgdmFsaWQgYml0IGlzIHNldCBpbiB0 aGUKPiA+ID4gICAgKiBQVEUuIFByb3ZpZGUgb3VyIG93biBvdmVybGF5IHRvIGNoZWNrIHRoZSB2 YWxpZCBiaXQuCj4gPiA+ICAgICovCj4gPiA+ICAgc3RhdGljIGlubGluZSBib29sIHAybV9pc19t YXBwaW5nKGxwYWVfdCBwdGUsIHVuc2lnbmVkIGludCBsZXZlbCkKPiA+ID4gICB7Cj4gPiA+IC0g ICAgcmV0dXJuIGxwYWVfaXNfdmFsaWQocHRlKSAmJiBscGFlX2lzX21hcHBpbmcocHRlLCBsZXZl bCk7Cj4gPiA+ICsgICAgcmV0dXJuIHAybV9pc192YWxpZChwdGUpICYmIGxwYWVfaXNfbWFwcGlu ZyhwdGUsIGxldmVsKTsKPiA+ID4gICB9Cj4gPiA+ICAgICBzdGF0aWMgaW5saW5lIGJvb2wgcDJt X2lzX3N1cGVycGFnZShscGFlX3QgcHRlLCB1bnNpZ25lZCBpbnQgbGV2ZWwpCj4gPiA+ICAgewo+ ID4gPiAtICAgIHJldHVybiBscGFlX2lzX3ZhbGlkKHB0ZSkgJiYgbHBhZV9pc19zdXBlcnBhZ2Uo cHRlLCBsZXZlbCk7Cj4gPiA+ICsgICAgcmV0dXJuIHAybV9pc192YWxpZChwdGUpICYmIGxwYWVf aXNfc3VwZXJwYWdlKHB0ZSwgbGV2ZWwpOwo+ID4gPiAgIH0KPiA+ID4gICAgICNkZWZpbmUgR1VF U1RfVEFCTEVfTUFQX0ZBSUxFRCAwCj4gPiA+IEBAIC0yNjQsNyArMjczLDcgQEAgc3RhdGljIGlu dCBwMm1fbmV4dF9sZXZlbChzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLCBib29sCj4gPiA+IHJlYWRf b25seSwKPiA+ID4gICAgICAgICBlbnRyeSA9ICp0YWJsZSArIG9mZnNldDsKPiA+ID4gICAtICAg IGlmICggIWxwYWVfaXNfdmFsaWQoKmVudHJ5KSApCj4gPiA+ICsgICAgaWYgKCAhcDJtX2lzX3Zh bGlkKCplbnRyeSkgKQo+ID4gPiAgICAgICB7Cj4gPiA+ICAgICAgICAgICBpZiAoIHJlYWRfb25s eSApCj4gPiA+ICAgICAgICAgICAgICAgcmV0dXJuIEdVRVNUX1RBQkxFX01BUF9GQUlMRUQ7Cj4g PiA+IEBAIC0zNTYsNyArMzY1LDcgQEAgbWZuX3QgcDJtX2dldF9lbnRyeShzdHJ1Y3QgcDJtX2Rv bWFpbiAqcDJtLCBnZm5fdCBnZm4sCj4gPiA+ICAgICAgICAgZW50cnkgPSB0YWJsZVtvZmZzZXRz W2xldmVsXV07Cj4gPiA+ICAgLSAgICBpZiAoIGxwYWVfaXNfdmFsaWQoZW50cnkpICkKPiA+ID4g KyAgICBpZiAoIHAybV9pc192YWxpZChlbnRyeSkgKQo+ID4gPiAgICAgICB7Cj4gPiA+ICAgICAg ICAgICAqdCA9IGVudHJ5LnAybS50eXBlOwo+ID4gPiAgIEBAIC01NDQsOCArNTUzLDExIEBAIHN0 YXRpYyBscGFlX3QgcGFnZV90b19wMm1fdGFibGUoc3RydWN0IHBhZ2VfaW5mbwo+ID4gPiAqcGFn ZSkKPiA+ID4gICAgICAgLyoKPiA+ID4gICAgICAgICogVGhlIGFjY2VzcyB2YWx1ZSBkb2VzIG5v dCBtYXR0ZXIgYmVjYXVzZSB0aGUgaGFyZHdhcmUgd2lsbCBpZ25vcmUKPiA+ID4gICAgICAgICog dGhlIHBlcm1pc3Npb24gZmllbGRzIGZvciB0YWJsZSBlbnRyeS4KPiA+ID4gKyAgICAgKgo+ID4g PiArICAgICAqIFdlIHVzZSBwMm1fcmFtX3J3IHNvIHRoZSBlbnRyeSBoYXMgYSB2YWxpZCB0eXBl LiBUaGlzIGlzIGltcG9ydGFudAo+ID4gPiArICAgICAqIGZvciBwMm1faXNfdmFsaWQoKSB0byBy ZXR1cm4gdmFsaWQgb24gdGFibGUgZW50cmllcy4KPiA+ID4gICAgICAgICovCj4gPiA+IC0gICAg cmV0dXJuIG1mbl90b19wMm1fZW50cnkocGFnZV90b19tZm4ocGFnZSksIHAybV9pbnZhbGlkLAo+ ID4gPiBwMm1fYWNjZXNzX3J3eCk7Cj4gPiA+ICsgICAgcmV0dXJuIG1mbl90b19wMm1fZW50cnko cGFnZV90b19tZm4ocGFnZSksIHAybV9yYW1fcncsCj4gPiA+IHAybV9hY2Nlc3Nfcnd4KTsKPiA+ ID4gICB9Cj4gPiA+ICAgICBzdGF0aWMgaW5saW5lIHZvaWQgcDJtX3dyaXRlX3B0ZShscGFlX3Qg KnAsIGxwYWVfdCBwdGUsIGJvb2wKPiA+ID4gY2xlYW5fcHRlKQo+ID4gPiBAQCAtNTY5LDcgKzU4 MSw3IEBAIHN0YXRpYyBpbnQgcDJtX2NyZWF0ZV90YWJsZShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJt LAo+ID4gPiBscGFlX3QgKmVudHJ5KQo+ID4gPiAgICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwYWdl Owo+ID4gPiAgICAgICBscGFlX3QgKnA7Cj4gPiA+ICAgLSAgICBBU1NFUlQoIWxwYWVfaXNfdmFs aWQoKmVudHJ5KSk7Cj4gPiA+ICsgICAgQVNTRVJUKCFwMm1faXNfdmFsaWQoKmVudHJ5KSk7Cj4g PiA+ICAgICAgICAgcGFnZSA9IGFsbG9jX2RvbWhlYXBfcGFnZShOVUxMLCAwKTsKPiA+ID4gICAg ICAgaWYgKCBwYWdlID09IE5VTEwgKQo+ID4gPiBAQCAtNjI2LDcgKzYzOCw3IEBAIHN0YXRpYyBp bnQgcDJtX21lbV9hY2Nlc3NfcmFkaXhfc2V0KHN0cnVjdCBwMm1fZG9tYWluCj4gPiA+ICpwMm0s IGdmbl90IGdmbiwKPiA+ID4gICAgKi8KPiA+ID4gICBzdGF0aWMgdm9pZCBwMm1fcHV0X2wzX3Bh Z2UoY29uc3QgbHBhZV90IHB0ZSkKPiA+ID4gICB7Cj4gPiA+IC0gICAgQVNTRVJUKGxwYWVfaXNf dmFsaWQocHRlKSk7Cj4gPiA+ICsgICAgQVNTRVJUKHAybV9pc192YWxpZChwdGUpKTsKPiA+ID4g ICAgICAgICAvKgo+ID4gPiAgICAgICAgKiBUT0RPOiBIYW5kbGUgb3RoZXIgcDJtIHR5cGVzCj4g PiA+IEBAIC02NTQsMTEgKzY2NiwxMSBAQCBzdGF0aWMgdm9pZCBwMm1fZnJlZV9lbnRyeShzdHJ1 Y3QgcDJtX2RvbWFpbiAqcDJtLAo+ID4gPiAgICAgICBzdHJ1Y3QgcGFnZV9pbmZvICpwZzsKPiA+ ID4gICAgICAgICAvKiBOb3RoaW5nIHRvIGRvIGlmIHRoZSBlbnRyeSBpcyBpbnZhbGlkLiAqLwo+ ID4gPiAtICAgIGlmICggIWxwYWVfaXNfdmFsaWQoZW50cnkpICkKPiA+ID4gKyAgICBpZiAoICFw Mm1faXNfdmFsaWQoZW50cnkpICkKPiA+ID4gICAgICAgICAgIHJldHVybjsKPiA+ID4gICAgICAg ICAvKiBOb3RoaW5nIHRvIGRvIGJ1dCB1cGRhdGluZyB0aGUgc3RhdHMgaWYgdGhlIGVudHJ5IGlz IGEKPiA+ID4gc3VwZXItcGFnZS4gKi8KPiA+ID4gLSAgICBpZiAoIHAybV9pc19zdXBlcnBhZ2Uo ZW50cnksIGxldmVsKSApCj4gPiA+ICsgICAgaWYgKCBsZXZlbCA9PSAzICYmIGVudHJ5LnAybS50 YWJsZSApCj4gPiAKPiA+IFdoeT8KPiAKPiBCZWNhdXNlIHAybV9pc19zdXBlcnBhZ2UoLi4uKSBj b250YWlucyBwMm1faXNfdmFsaWQoKS4gU28gd2Ugd291bGQgdGVzdCB0d2ljZQo+IHRoZSB2YWxp ZGl0eSBvZiB0aGUgcDJtLgo+IAo+IEJ1dCBJIGd1ZXNzIHRoaXMgaXMgbm90IGEgYmlnIGRlYWws IHNvIEkgY2FuIHJlbW92ZSBpdC4KPiAKPiA+IAo+ID4gCj4gPiA+ICAgICAgIHsKPiA+ID4gICAg ICAgICAgIHAybS0+c3RhdHMubWFwcGluZ3NbbGV2ZWxdLS07Cj4gPiA+ICAgICAgICAgICByZXR1 cm47Cj4gPiA+IEBAIC05NTEsNyArOTYzLDcgQEAgc3RhdGljIGludCBfX3AybV9zZXRfZW50cnko c3RydWN0IHAybV9kb21haW4gKnAybSwKPiA+ID4gICAgICAgICAgICAgICBlbHNlCj4gPiA+ICAg ICAgICAgICAgICAgICAgIHAybS0+bmVlZF9mbHVzaCA9IHRydWU7Cj4gPiA+ICAgICAgICAgICB9 Cj4gPiA+IC0gICAgICAgIGVsc2UgLyogbmV3IG1hcHBpbmcgKi8KPiA+ID4gKyAgICAgICAgZWxz ZSBpZiAoICFwMm1faXNfdmFsaWQob3JpZ19wdGUpICkgLyogbmV3IG1hcHBpbmcgKi8KPiA+IAo+ ID4gVGhlcmUgYXJlIGEgY291cGxlIG9mIGxwYWVfaXNfdmFsaWQgY2hlY2tzIGp1c3QgYWJvdmUg dGhpcyBsaW5lIHRoYXQgeW91Cj4gPiBtaXNzZWQsIHdoeSBoYXZlbid0IHlvdSBjaGFuZ2VkIHRo ZW0/Cj4gPiAKPiA+IElmIHlvdSBoYXZlIGEgZ29vZCByZWFzb24sIHBsZWFzZSBleHBsYWluIGlu IGEgY29tbWVudCBhbmQvb3IgY29tbWl0Cj4gPiBtZXNzYWdlLgo+IAo+IFRoaXMgaXMgYWxyZWFk eSBleHBsYWluZWQgaW4gdGhlIGNvbW1pdCBtZXNzYWdlOgo+IAo+ICJUaGlzIHBhdGNoIGludHJv ZHVjZXMgYSBuZXcgaGVscGVyIHAybV9pc192YWxpZCwgd2hpY2ggaW1wbGVtZW50cyB0aGF0Cj4g aWRlYSwgYW5kIHJlcGxhY2UgbW9zdCBvZiBscGFlX2lzX3ZhbGlkIGNhbGwgd2l0aCB0aGUgbmV3 IGhlbHBlci4gVGhlIG9uZXMKPiByZW1haW5pbmcgYXJlIGZvciBUTEJzIGhhbmRsaW5nIGFuZCBl bnRyaWVzIGFjY291bnRpbmcuIgo+IAo+IEkgYmVsaWV2ZSB0aGF0IHRoZSBjb2RlIGhhcyBlbm91 Z2ggZXhpc3RpbmcgY29tbWVudCB0byB1bmRlcnN0YW5kIHdoeQo+IGxwYWVfaXNfdmFsaWQoLi4u KSBzaG91bGQgYmUga2VwdC4gWW91IGRlYWwgd2l0aCBoYXJkd2FyZSB1cGRhdGUgYW5kIGhlbmNl IHlvdQo+IHNob3VsZCB1c2UgdGhlIHZhbGlkIGJpdCBpbiB0aGUgTFBBRSB0YWJsZS4gVGhpcyB3 aWxsIHRlbGwgeW91IHdoZXRoZXIgeW91Cj4gbmVlZCB0byBmbHVzaCB0aGUgVExCcy4KCkkgY2hl Y2tlZCBhbmQgaXQgaXMgbGlrZSB5b3Ugd3JvdGUuCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL3hlbi1kZXZlbA==