From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753974AbaGKPRq (ORCPT ); Fri, 11 Jul 2014 11:17:46 -0400 Received: from qmta14.emeryville.ca.mail.comcast.net ([76.96.27.212]:43577 "EHLO qmta14.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752561AbaGKPRp (ORCPT ); Fri, 11 Jul 2014 11:17:45 -0400 Date: Fri, 11 Jul 2014 10:17:41 -0500 (CDT) From: Christoph Lameter To: Frederic Weisbecker cc: akpm@linux-foundation.org, Gilad Ben-Yossef , Thomas Gleixner , Tejun Heo , John Stultz , Mike Frysinger , Minchan Kim , Hakan Akkan , Max Krasnyansky , "Paul E. McKenney" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, hughd@google.com, viresh.kumar@linaro.org, hpa@zytor.com, mingo@kernel.org, peterz@infradead.org Subject: Re: vmstat: On demand vmstat workers V8 In-Reply-To: <20140711135854.GD26045@localhost.localdomain> Message-ID: References: <20140711132032.GB26045@localhost.localdomain> <20140711135854.GD26045@localhost.localdomain> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Jul 2014, Frederic Weisbecker wrote: > > Converted what? We still need to keep a cpumask around that tells us which > > processor have vmstat running and which do not. > > > > Converted to cpumask_var_t. > > I mean we spent dozens emails on that... Oh there is this outstanding fix, right. Subject: on demand vmstat: Do not open code alloc_cpumask_var Signed-off-by: Christoph Lameter Index: linux/mm/vmstat.c =================================================================== --- linux.orig/mm/vmstat.c 2014-07-11 10:15:55.356856916 -0500 +++ linux/mm/vmstat.c 2014-07-11 10:15:55.352856994 -0500 @@ -1244,7 +1244,7 @@ #ifdef CONFIG_SMP static DEFINE_PER_CPU(struct delayed_work, vmstat_work); int sysctl_stat_interval __read_mostly = HZ; -struct cpumask *cpu_stat_off; +cpumask_var_t cpu_stat_off; static void vmstat_update(struct work_struct *w) { @@ -1338,7 +1338,8 @@ INIT_DEFERRABLE_WORK(per_cpu_ptr(&vmstat_work, cpu), vmstat_update); - cpu_stat_off = kmalloc(cpumask_size(), GFP_KERNEL); + if (!alloc_cpumask_var(&cpu_stat_off, GFP_KERNEL)) + BUG(); cpumask_copy(cpu_stat_off, cpu_online_mask); schedule_delayed_work(&shepherd, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qc0-f172.google.com (mail-qc0-f172.google.com [209.85.216.172]) by kanga.kvack.org (Postfix) with ESMTP id 826C5900002 for ; Fri, 11 Jul 2014 11:17:46 -0400 (EDT) Received: by mail-qc0-f172.google.com with SMTP id l6so1113813qcy.3 for ; Fri, 11 Jul 2014 08:17:46 -0700 (PDT) Received: from qmta02.emeryville.ca.mail.comcast.net (qmta02.emeryville.ca.mail.comcast.net. [2001:558:fe2d:43:76:96:30:24]) by mx.google.com with ESMTP id k7si3867781qat.26.2014.07.11.08.17.44 for ; Fri, 11 Jul 2014 08:17:45 -0700 (PDT) Date: Fri, 11 Jul 2014 10:17:41 -0500 (CDT) From: Christoph Lameter Subject: Re: vmstat: On demand vmstat workers V8 In-Reply-To: <20140711135854.GD26045@localhost.localdomain> Message-ID: References: <20140711132032.GB26045@localhost.localdomain> <20140711135854.GD26045@localhost.localdomain> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Frederic Weisbecker Cc: akpm@linux-foundation.org, Gilad Ben-Yossef , Thomas Gleixner , Tejun Heo , John Stultz , Mike Frysinger , Minchan Kim , Hakan Akkan , Max Krasnyansky , "Paul E. McKenney" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, hughd@google.com, viresh.kumar@linaro.org, hpa@zytor.com, mingo@kernel.org, peterz@infradead.org On Fri, 11 Jul 2014, Frederic Weisbecker wrote: > > Converted what? We still need to keep a cpumask around that tells us which > > processor have vmstat running and which do not. > > > > Converted to cpumask_var_t. > > I mean we spent dozens emails on that... Oh there is this outstanding fix, right. Subject: on demand vmstat: Do not open code alloc_cpumask_var Signed-off-by: Christoph Lameter Index: linux/mm/vmstat.c =================================================================== --- linux.orig/mm/vmstat.c 2014-07-11 10:15:55.356856916 -0500 +++ linux/mm/vmstat.c 2014-07-11 10:15:55.352856994 -0500 @@ -1244,7 +1244,7 @@ #ifdef CONFIG_SMP static DEFINE_PER_CPU(struct delayed_work, vmstat_work); int sysctl_stat_interval __read_mostly = HZ; -struct cpumask *cpu_stat_off; +cpumask_var_t cpu_stat_off; static void vmstat_update(struct work_struct *w) { @@ -1338,7 +1338,8 @@ INIT_DEFERRABLE_WORK(per_cpu_ptr(&vmstat_work, cpu), vmstat_update); - cpu_stat_off = kmalloc(cpumask_size(), GFP_KERNEL); + if (!alloc_cpumask_var(&cpu_stat_off, GFP_KERNEL)) + BUG(); cpumask_copy(cpu_stat_off, cpu_online_mask); schedule_delayed_work(&shepherd, -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org