From: Christoph Lameter <cl@linux.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
nicolas.pitre@linaro.org,
Russell King <rmk+kernel@arm.linux.org.uk>,
Tejun Heo <tj@kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: linux-next: Tree for Sep 1
Date: Tue, 2 Sep 2014 10:00:07 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.11.1409020958530.9608@gentwo.org> (raw)
In-Reply-To: <alpine.DEB.2.11.1409020857110.9201@gentwo.org>
On Tue, 2 Sep 2014, Christoph Lameter wrote:
> Oww.. This is double indirection deal there. A percpu offset pointing to
> a pointer?
>
> Generally the following is true (definition from
> include/asm-generic/percpu.h that is used for ARM for raw_cpu_read):
>
> #define raw_cpu_read_4(pcp) (*raw_cpu_ptr(&(pcp)))
I think what the issue is that we dropped the fetch of the percpu offset
in the patch. Instead we are using the address of the variable that
contains the offset. Does this patch fix it?
Subject: irqchip: Properly fetch the per cpu offset
The raw_cpu_read() conversion dropped the fetch of the offset
from base->percpu_base in gic_get_percpu_base.
Signed-off-by: Christoph Lameter <cl@linux.com>
Index: linux/drivers/irqchip/irq-gic.c
===================================================================
--- linux.orig/drivers/irqchip/irq-gic.c
+++ linux/drivers/irqchip/irq-gic.c
@@ -102,7 +102,7 @@ static struct gic_chip_data gic_data[MAX
#ifdef CONFIG_GIC_NON_BANKED
static void __iomem *gic_get_percpu_base(union gic_base *base)
{
- return raw_cpu_read(base->percpu_base);
+ return raw_cpu_read(*base->percpu_base);
}
static void __iomem *gic_get_common_base(union gic_base *base)
next prev parent reply other threads:[~2014-09-02 15:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 23:07 linux-next: Tree for Sep 1 Mark Brown
2014-09-02 13:16 ` Bartlomiej Zolnierkiewicz
2014-09-02 13:19 ` Bartlomiej Zolnierkiewicz
2014-09-02 14:07 ` Christoph Lameter
2014-09-02 15:00 ` Christoph Lameter [this message]
2014-09-03 16:09 ` Bartlomiej Zolnierkiewicz
2014-09-04 17:11 ` Tejun Heo
2014-09-04 17:59 ` Christoph Lameter
2014-09-05 18:17 ` Russell King - ARM Linux
2014-09-05 11:31 ` Jason Cooper
2014-09-05 23:48 ` Tejun Heo
2014-09-09 0:37 ` Tejun Heo
2014-09-10 14:15 ` Christoph Lameter
2014-09-10 15:04 ` Jason Cooper
2014-09-10 16:18 ` Nicolas Pitre
2014-09-10 16:21 ` Christoph Lameter
2014-09-10 16:19 ` Christoph Lameter
2014-09-05 19:27 ` Nicolas Pitre
2014-09-08 14:15 ` Christoph Lameter
2014-09-10 17:41 ` Russell King - ARM Linux
2014-09-10 17:59 ` Nicolas Pitre
2014-09-11 10:24 ` Bartlomiej Zolnierkiewicz
2014-09-10 18:11 ` Marc Zyngier
2014-09-11 11:01 ` Bartlomiej Zolnierkiewicz
2014-09-11 11:17 ` Marc Zyngier
2014-09-14 5:40 ` Jason Cooper
2014-09-18 12:51 ` Bartlomiej Zolnierkiewicz
2014-09-19 3:52 ` Tejun Heo
2014-09-02 14:58 ` Jason Cooper
2014-09-02 14:58 ` Jason Cooper
2015-09-01 8:21 Stephen Rothwell
2017-09-01 6:39 Stephen Rothwell
2021-09-01 8:17 Stephen Rothwell
2022-09-01 7:18 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1409020958530.9608@gentwo.org \
--to=cl@linux.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.