All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scot Doyle <lkml14@scotdoyle.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sarah Sharp <sarah.a.sharp@linux.intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Daniel Mack <daniel@caiaq.de>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: core: downgrade log severity to info when descriptor missing
Date: Tue, 23 Sep 2014 19:06:14 +0000 (UTC)	[thread overview]
Message-ID: <alpine.DEB.2.11.1409231905460.3223@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1409231021190.1322-100000@iolanthe.rowland.org>

On Tue, 23 Sep 2014, Alan Stern wrote:
> -ENODATA doesn't mean the string was unavailable.  It means that the
> second byte of the reply was different from USB_DT_STRING, i.e., the
> reply was malformed.

Thank you for the correction!

> And down here is where you should call either dev_info() or dev_err(),
> depending on whether err is equal to -EPIPE or something else.

I hope to send it shortly.

  reply	other threads:[~2014-09-23 19:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22 20:20 [PATCH] usb: core: downgrade log severity to info when descriptor missing Scot Doyle
2014-09-23 14:26 ` Alan Stern
2014-09-23 19:06   ` Scot Doyle [this message]
2014-09-23 19:12     ` [PATCH v2] usb: core: downgrade log severity to info when descriptor unavailable Scot Doyle
2014-09-24  5:18       ` Greg Kroah-Hartman
2014-09-24 17:56         ` Scot Doyle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1409231905460.3223@localhost.localdomain \
    --to=lkml14@scotdoyle.com \
    --cc=dan.j.williams@intel.com \
    --cc=daniel@caiaq.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sarah.a.sharp@linux.intel.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.