All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scot Doyle <lkml14@scotdoyle.com>
To: Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sarah Sharp <sarah.a.sharp@linux.intel.com>,
	Dan Williams <dan.j.williams@intel.com>
Cc: Daniel Mack <daniel@caiaq.de>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH] usb: core: log more general message on malformed LANGID descriptor
Date: Tue, 23 Sep 2014 22:28:49 +0000 (UTC)	[thread overview]
Message-ID: <alpine.DEB.2.11.1409232013320.2145@localhost.localdomain> (raw)

I'd like to change this error message:
[    3.325837] usb 1-4: string descriptor 0 malformed (err = -61), defaulting to 0x0409

into an error message followed by a debug message:
[    3.324726] usb 1-4: malformed string descriptor; unknown language, defaulting to English
[    3.327514] usb 1-4: string descriptor 0 malformed (err = -61), defaulting to 0x0409

in order to communicate more information from the log itself. Are there 
any problems with this approach? Would it be better to put all the 
information on a single line? Something else?


---
diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
index 0c8a7fc..c29eb37 100644
--- a/drivers/usb/core/message.c
+++ b/drivers/usb/core/message.c
@@ -770,6 +770,8 @@ static int usb_get_langid(struct usb_device *dev, unsigned char *tbuf)
 		dev->string_langid = 0x0409;
 		dev->have_langid = 1;
 		dev_err(&dev->dev,
+			"malformed string descriptor; unknown language, defaulting to English");
+		dev_dbg(&dev->dev,
 			"string descriptor 0 malformed (err = %d), "
 			"defaulting to 0x%04x\n",
 				err, dev->string_langid);

             reply	other threads:[~2014-09-23 22:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23 22:28 Scot Doyle [this message]
2014-09-24  5:27 ` [RFC PATCH] usb: core: log more general message on malformed LANGID descriptor Greg Kroah-Hartman
2014-09-24 17:28   ` Scot Doyle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1409232013320.2145@localhost.localdomain \
    --to=lkml14@scotdoyle.com \
    --cc=dan.j.williams@intel.com \
    --cc=daniel@caiaq.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sarah.a.sharp@linux.intel.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.