Re: [PATCHv3 2/3] kernel: add support for live patching

[Thomas Gleixner <tglx@linutronix.de>]

On Mon, 24 Nov 2014, Jiri Kosina wrote:
> On Mon, 24 Nov 2014, Thomas Gleixner wrote:
> > How is determined whether a change can be applied w/o a consistency
> > mechanism or not?
> 
> By a human being producing the "live patch" code.
> 
> If the semantics of the patch requires consistency mechanism to be applied 
> (such as "old and new function must not run in parallel, because locking 
> rules would be violated", or "return value from a function that is being 
> called in a loop is changing its meaning", etc.), then this first naive 
> implementation simply can't be used.
> 
> For simple things though, such as "add a missing bounds check to sys_foo() 
> prologue and return -EINVAL if out-of-bounds", this is sufficient.
> 
> It's being designed in a way that more advanced consistency models (such 
> as the ones kgraft and kpatch are currently implementing) can be built on 
> top of it.
> 
> The person writing the patch would always need to understand what he is 
> doing to be able to pick correct consistency model to be used. I 
> personally think this is a good thing -- this is nothing where we should 
> be relying on any kinds of tools.

But why want we to provide a mechanism which has no consistency
enforcement at all?

Surely you can argue that the person who is doing that is supposed to
know what he's doing, but what's the downside of enforcing consistency
mechanisms on all live code changes?

Thanks,

	tglx