From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933538AbaLCAEE (ORCPT ); Tue, 2 Dec 2014 19:04:04 -0500 Received: from www.linutronix.de ([62.245.132.108]:50396 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933271AbaLCAEC (ORCPT ); Tue, 2 Dec 2014 19:04:02 -0500 Date: Wed, 3 Dec 2014 01:03:43 +0100 (CET) From: Thomas Gleixner To: =?ISO-8859-15?Q?Peter_H=FCwe?= cc: tpmdd-devel@lists.sourceforge.net, Jarkko Sakkinen , christophe.ricard@gmail.com, josh.triplett@intel.com, linux-api@vger.kernel.org, Ashley Lai , linux-kernel@vger.kernel.org, jason.gunthorpe@obsidianresearch.com, trousers-tech@lists.sourceforge.net Subject: Re: [tpmdd-devel] [PATCH v8 0/8] TPM 2.0 support In-Reply-To: <201412030021.07882.PeterHuewe@gmx.de> Message-ID: References: <1417559480-13757-1-git-send-email-jarkko.sakkinen@linux.intel.com> <201412030016.20268.PeterHuewe@gmx.de> <201412030021.07882.PeterHuewe@gmx.de> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-758534258-1417565024=:16275" X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-758534258-1417565024=:16275 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT On Wed, 3 Dec 2014, Peter Hüwe wrote: > From: Peter Huewe > Date: Wed, 3 Dec 2014 00:18:52 +0100 > Subject: [PATCH] tpm:tpm_i2c_nuvoton: simpyl return statements simpyl? > if !rc evals to false it is 0 > -> we can return rc in both cases Why assigning rc and returning it when you can return the result of tpm_chip_register() right away? Thanks, tglx --8323329-758534258-1417565024=:16275-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [tpmdd-devel] [PATCH v8 0/8] TPM 2.0 support Date: Wed, 3 Dec 2014 01:03:43 +0100 (CET) Message-ID: References: <1417559480-13757-1-git-send-email-jarkko.sakkinen@linux.intel.com> <201412030016.20268.PeterHuewe@gmx.de> <201412030021.07882.PeterHuewe@gmx.de> Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-758534258-1417565024=:16275" Return-path: In-Reply-To: <201412030021.07882.PeterHuewe-Mmb7MZpHnFY@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?ISO-8859-15?Q?Peter_H=FCwe?= Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Jarkko Sakkinen , christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, josh.triplett-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ashley Lai , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jason.gunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org, trousers-tech-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-api@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-758534258-1417565024=:16275 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT On Wed, 3 Dec 2014, Peter Hüwe wrote: > From: Peter Huewe > Date: Wed, 3 Dec 2014 00:18:52 +0100 > Subject: [PATCH] tpm:tpm_i2c_nuvoton: simpyl return statements simpyl? > if !rc evals to false it is 0 > -> we can return rc in both cases Why assigning rc and returning it when you can return the result of tpm_chip_register() right away? Thanks, tglx --8323329-758534258-1417565024=:16275--