From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753179AbbDTUsV (ORCPT ); Mon, 20 Apr 2015 16:48:21 -0400 Received: from www.linutronix.de ([62.245.132.108]:55751 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024AbbDTUsQ (ORCPT ); Mon, 20 Apr 2015 16:48:16 -0400 Date: Mon, 20 Apr 2015 22:48:06 +0200 (CEST) From: Thomas Gleixner To: Baolin Wang cc: arnd@arndb.de, john.stultz@linaro.org, heenasirwani@gmail.com, pang.xunlei@linaro.org, peterz@infradead.org, rafael.j.wysocki@intel.com, gregkh@linuxfoundation.org, richardcochran@gmail.com, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, linux390@de.ibm.com, rth@twiddle.net, riel@redhat.com, cl@linux.com, tj@kernel.org, fweisbec@gmail.com, ahh@google.com, pjt@google.com, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, y2038@lists.linaro.org Subject: Re: [PATCH 05/11] time/posix-timers:Convert to the 64bit methods for k_clock callback functions In-Reply-To: <1429509459-17068-6-git-send-email-baolin.wang@linaro.org> Message-ID: References: <1429509459-17068-1-git-send-email-baolin.wang@linaro.org> <1429509459-17068-6-git-send-email-baolin.wang@linaro.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Apr 2015, Baolin Wang wrote: > /* Set clock_realtime */ > static int posix_clock_realtime_set(const clockid_t which_clock, > - const struct timespec *tp) > + const struct timespec64 *tp) > { > - return do_sys_settimeofday(tp, NULL); > + struct timespec ts = timespec64_to_timespec(*tp); > + > + return do_sys_settimeofday(&ts, NULL); Sigh. No. We first provide a proper function for this, which takes a timespec64, i.e. do_sys_settimeofday64() instead of having this wrapper mess all over the place. > /* SIGEV_NONE timers are not queued ! See common_timer_get */ > if (((timr->it_sigev_notify & ~SIGEV_THREAD_ID) == SIGEV_NONE)) { > diff --git a/kernel/time/timekeeping.h b/kernel/time/timekeeping.h > index 1d91416..144af14 100644 > --- a/kernel/time/timekeeping.h > +++ b/kernel/time/timekeeping.h > @@ -15,7 +15,7 @@ extern u64 timekeeping_max_deferment(void); > extern int timekeeping_inject_offset(struct timespec *ts); > extern s32 timekeeping_get_tai_offset(void); > extern void timekeeping_set_tai_offset(s32 tai_offset); > -extern void timekeeping_clocktai(struct timespec *ts); > +extern void timekeeping_clocktai(struct timespec64 *ts); # git grep timekeeping_clocktai() is your friend. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from Galois.linutronix.de (Galois.linutronix.de [IPv6:2001:470:1f0b:db:abcd:42:0:1]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 51DED1A0007 for ; Tue, 21 Apr 2015 06:48:16 +1000 (AEST) Date: Mon, 20 Apr 2015 22:48:06 +0200 (CEST) From: Thomas Gleixner To: Baolin Wang Subject: Re: [PATCH 05/11] time/posix-timers:Convert to the 64bit methods for k_clock callback functions In-Reply-To: <1429509459-17068-6-git-send-email-baolin.wang@linaro.org> Message-ID: References: <1429509459-17068-1-git-send-email-baolin.wang@linaro.org> <1429509459-17068-6-git-send-email-baolin.wang@linaro.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: pang.xunlei@linaro.org, peterz@infradead.org, heiko.carstens@de.ibm.com, paulus@samba.org, cl@linux.com, heenasirwani@gmail.com, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, y2038@lists.linaro.org, rafael.j.wysocki@intel.com, ahh@google.com, fweisbec@gmail.com, pjt@google.com, riel@redhat.com, arnd@arndb.de, richardcochran@gmail.com, schwidefsky@de.ibm.com, john.stultz@linaro.org, rth@twiddle.net, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, tj@kernel.org, linux390@de.ibm.com, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 20 Apr 2015, Baolin Wang wrote: > /* Set clock_realtime */ > static int posix_clock_realtime_set(const clockid_t which_clock, > - const struct timespec *tp) > + const struct timespec64 *tp) > { > - return do_sys_settimeofday(tp, NULL); > + struct timespec ts = timespec64_to_timespec(*tp); > + > + return do_sys_settimeofday(&ts, NULL); Sigh. No. We first provide a proper function for this, which takes a timespec64, i.e. do_sys_settimeofday64() instead of having this wrapper mess all over the place. > /* SIGEV_NONE timers are not queued ! See common_timer_get */ > if (((timr->it_sigev_notify & ~SIGEV_THREAD_ID) == SIGEV_NONE)) { > diff --git a/kernel/time/timekeeping.h b/kernel/time/timekeeping.h > index 1d91416..144af14 100644 > --- a/kernel/time/timekeeping.h > +++ b/kernel/time/timekeeping.h > @@ -15,7 +15,7 @@ extern u64 timekeeping_max_deferment(void); > extern int timekeeping_inject_offset(struct timespec *ts); > extern s32 timekeeping_get_tai_offset(void); > extern void timekeeping_set_tai_offset(s32 tai_offset); > -extern void timekeeping_clocktai(struct timespec *ts); > +extern void timekeeping_clocktai(struct timespec64 *ts); # git grep timekeeping_clocktai() is your friend. Thanks, tglx