All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Vatika Harlalka <vatikaharlalka@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	preeti@linux.vnet.ibm.com, mingo@redhat.com,
	rafael.j.wysocki@intel.com, schwidefsky@de.ibm.com,
	paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
	cl@linux.com, cmetcalf@ezchip.com, bitbucket@online.de
Subject: Re: [PATCH RESEND] nohz: Affining unpinned timers
Date: Mon, 6 Jul 2015 19:18:22 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1507061901580.3916@nanos> (raw)
In-Reply-To: <20150706165405.GD4981@lerouge>

On Mon, 6 Jul 2015, Frederic Weisbecker wrote:
> I hope everybody received the patch because there is a ";" after each address :-)
> 
> On Tue, Jun 23, 2015 at 02:01:33PM +0530, Vatika Harlalka wrote:
> > The problem addressed in this patch is about affining unpinned timers.
> > Adaptive or Full Dynticks CPUs should not be disturbed by unnecessary
> > jitter due to firing of such timers on them.
> > This patch will affine timers to online CPUs which are not Full Dynticks
> > in FULL_NOHZ configured systems. It will not bring about functional
> > changes if NOHZ_FULL is not configured, because is_housekeeping_cpu()
> > always returns true in CONFIG_NO_HZ_FULL=n.
> > 
> > Signed-off by: Vatika Harlalka <vatikaharlalka@gmail.com>
> 
> The patch looks good to me. Peter, Thomas, are you ok with it too?

By some definition of OK. The overhead of this is growing and growing.

We really need to make this a pull not a push model.

Thanks,

	tglx

  reply	other threads:[~2015-07-06 17:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150623083133.GA587@vatika-Inspiron-3443>
2015-06-24  7:17 ` [PATCH RESEND] nohz: Affining unpinned timers Preeti U Murthy
2015-07-06 16:54 ` Frederic Weisbecker
2015-07-06 17:18   ` Thomas Gleixner [this message]
2015-07-06 22:49     ` Frederic Weisbecker
2015-07-07  6:39       ` Thomas Gleixner
2015-08-02  9:35         ` Vatika Harlalka
2015-08-03 14:52           ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1507061901580.3916@nanos \
    --to=tglx@linutronix.de \
    --cc=bitbucket@online.de \
    --cc=cl@linux.com \
    --cc=cmetcalf@ezchip.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=preeti@linux.vnet.ibm.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=vatikaharlalka@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.