From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753645AbbG3OeN (ORCPT ); Thu, 30 Jul 2015 10:34:13 -0400 Received: from resqmta-ch2-01v.sys.comcast.net ([69.252.207.33]:40178 "EHLO resqmta-ch2-01v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753575AbbG3OeJ (ORCPT ); Thu, 30 Jul 2015 10:34:09 -0400 Date: Thu, 30 Jul 2015 09:33:59 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@east.gentwo.org To: Mel Gorman cc: Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , David Rientjes , Greg Thelen , "Aneesh Kumar K.V" , Pekka Enberg , Joonsoo Kim , Naoya Horiguchi Subject: Re: [RFC v2 1/4] mm: make alloc_pages_exact_node pass __GFP_THISNODE In-Reply-To: <20150729133043.GE19352@techsingularity.net> Message-ID: References: <1437749126-25867-1-git-send-email-vbabka@suse.cz> <20150729133043.GE19352@techsingularity.net> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Jul 2015, Mel Gorman wrote: > The change of what we have now is a good idea. What you have is a solid > improvement in my view but I see there are a few different suggestions > in the thread. Based on that I think it makes sense to just destroy > alloc_pages_exact_node. In the future "exact" in the allocator API will > mean "exactly this number of pages". Use your __alloc_pages_node helper > and specify __GFP_THISNODE if the caller requires that specific node. Yes please. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qg0-f49.google.com (mail-qg0-f49.google.com [209.85.192.49]) by kanga.kvack.org (Postfix) with ESMTP id 462826B0259 for ; Thu, 30 Jul 2015 10:34:10 -0400 (EDT) Received: by qgeh16 with SMTP id h16so25179551qge.3 for ; Thu, 30 Jul 2015 07:34:10 -0700 (PDT) Received: from resqmta-ch2-08v.sys.comcast.net (resqmta-ch2-08v.sys.comcast.net. [2001:558:fe21:29:69:252:207:40]) by mx.google.com with ESMTPS id h52si1387258qgf.43.2015.07.30.07.34.08 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 30 Jul 2015 07:34:09 -0700 (PDT) Date: Thu, 30 Jul 2015 09:33:59 -0500 (CDT) From: Christoph Lameter Subject: Re: [RFC v2 1/4] mm: make alloc_pages_exact_node pass __GFP_THISNODE In-Reply-To: <20150729133043.GE19352@techsingularity.net> Message-ID: References: <1437749126-25867-1-git-send-email-vbabka@suse.cz> <20150729133043.GE19352@techsingularity.net> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , David Rientjes , Greg Thelen , "Aneesh Kumar K.V" , Pekka Enberg , Joonsoo Kim , Naoya Horiguchi On Wed, 29 Jul 2015, Mel Gorman wrote: > The change of what we have now is a good idea. What you have is a solid > improvement in my view but I see there are a few different suggestions > in the thread. Based on that I think it makes sense to just destroy > alloc_pages_exact_node. In the future "exact" in the allocator API will > mean "exactly this number of pages". Use your __alloc_pages_node helper > and specify __GFP_THISNODE if the caller requires that specific node. Yes please. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org