From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, vince@deater.net,
eranian@google.com, Arnaldo Carvalho de Melo <acme@infradead.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH v1 2/5] perf/x86/intel/pt: IP filtering register/cpuid bits
Date: Fri, 22 Apr 2016 09:58:31 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1604220954260.3941@nanos> (raw)
In-Reply-To: <20160421203752.GL28821@pd.tnic>
On Thu, 21 Apr 2016, Borislav Petkov wrote:
> On Thu, Apr 21, 2016 at 08:55:38PM +0200, Thomas Gleixner wrote:
> > I have to disagree here. The MSRs itself can really go into msr-index.h while
> > the bit definitions might go elsewhere. What's wrong with having all MSRs at a
> > central place?
>
> Same reason as for pci_ids.h - to contain only MSRs which are used in
> multiple compilation units.
That's really not the same thing. pci ids are issued by a gazillion of vendors
for a bazillion of different devices. There is no consistent view for them.
MSRs on the other hand are x86 specific registers nicely defined in the
SDM/APM and having at least the MSR defines in a single header makes a lot of
sense.
Thanks,
tglx
next prev parent reply other threads:[~2016-04-22 8:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 15:16 [PATCH v1 0/5] perf: Introduce address range filtering Alexander Shishkin
2016-04-21 15:16 ` [PATCH v1 1/5] perf: Move set_filter() from behind EVENT_TRACING Alexander Shishkin
2016-04-21 15:17 ` [PATCH v1 2/5] perf/x86/intel/pt: IP filtering register/cpuid bits Alexander Shishkin
2016-04-21 17:48 ` Borislav Petkov
2016-04-21 18:55 ` Thomas Gleixner
2016-04-21 19:17 ` Peter Zijlstra
2016-04-21 20:39 ` Borislav Petkov
2016-04-21 20:37 ` Borislav Petkov
2016-04-22 7:58 ` Thomas Gleixner [this message]
2016-04-22 9:34 ` Borislav Petkov
2016-04-21 15:17 ` [PATCH v1 3/5] perf: Extend perf_event_aux_ctx() to optionally iterate through more events Alexander Shishkin
2016-04-21 15:17 ` [PATCH v1 4/5] perf: Introduce address range filtering Alexander Shishkin
2016-04-22 7:45 ` Peter Zijlstra
2016-04-22 16:19 ` Alexander Shishkin
2016-04-25 12:57 ` Peter Zijlstra
2016-04-25 15:41 ` Alexander Shishkin
2016-04-25 13:10 ` Peter Zijlstra
2016-04-25 13:36 ` Peter Zijlstra
2016-04-25 16:02 ` Alexander Shishkin
2016-04-25 13:19 ` Peter Zijlstra
2016-04-25 16:03 ` Alexander Shishkin
2016-04-25 14:14 ` Peter Zijlstra
2016-04-25 16:07 ` Alexander Shishkin
2016-04-25 14:25 ` Peter Zijlstra
2016-04-25 16:14 ` Alexander Shishkin
2016-04-26 14:35 ` Alexander Shishkin
2016-04-21 15:17 ` [PATCH v1 5/5] perf/x86/intel/pt: Add support for address range filtering in PT Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1604220954260.3941@nanos \
--to=tglx@linutronix.de \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.