All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: David Kershner <david.kershner@unisys.com>
Cc: nhorman@redhat.com, driverdev-devel@linuxdriverproject.org,
	david.binder@unisys.com, gregkh@linuxfoundation.org,
	sparmaintainer@unisys.com, jes.sorensen@redhat.com
Subject: Re: [PATCH RESEND 00/28] staging: unisys: fix visorbus & visorinput issues raised by tglx
Date: Sat, 11 Jun 2016 11:42:41 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1606111141190.5839@nanos> (raw)
In-Reply-To: <1465609706-15443-1-git-send-email-david.kershner@unisys.com>

On Fri, 10 Jun 2016, David Kershner wrote:
> Resending due to imcomplete distribution list. 
> 
> This patchset comprises the first 26 patches of the previously-submitted
> patchset (but retracted): 
> 
> 	[PATCH v4 00/29] Fixed issues raised by tglx, then move visorbus to
> 			 drivers/virt
> 
> then adds 2 patches to visorinput that:
> 	* fixes a device initialization race condition
> 	* converts a semaphore to a mutex
> 
> As described in the email NAKing the previously-submitted patchset,
> the reason we are re-submitting this now is to make things a bit
> cleaner by separating the fixes we need to make to the code in
> staging from the patchset that actually moves the code out of staging.
> 
> The intent of this patchset is to fix all known outstanding
> issues with code in drivers/staging/unisys/, so that subsequent
> patchsets can move these drivers out of staging.
> 
> tglx: The following patchset fixes issues you raised during your
> code review of visorbus on 5/18, and visorinput on 6/1. 
> 
> Converts visorbus to use a kernel timer for periodic device-specific
> callbacks instead of a workqueue, making the implementation in
> periodic_work.c and periodic_work.h no longer necessary.  These files
> are then deleted.
> 
> The visordriver_callback_lock has been switched to a mutex.
> 
> Several module parameters and structures were removed that were no
> longer being used.

My comments are addressed and the driver looks halfways reasonable now.

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2016-06-11  9:44 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-11  1:47 [PATCH RESEND 00/28] staging: unisys: fix visorbus & visorinput issues raised by tglx David Kershner
2016-06-11  1:47 ` [PATCH RESEND 01/28] staging: unisys: visorbus: remove return values for write_vbus functions David Kershner
2016-06-11  1:48 ` [PATCH RESEND 02/28] staging: unisys: visorbus: check parahotplug_request_complete_result David Kershner
2016-06-11  1:48 ` [PATCH RESEND 03/28] staging: unisys: visorbus: remove unused module parameters David Kershner
2016-06-11  1:48 ` [PATCH RESEND 04/28] staging: unisys: visorbus: remove unused struct David Kershner
2016-06-11  1:48 ` [PATCH RESEND 05/28] staging: unisys: visorbus: modify format string to match argument David Kershner
2016-06-11  1:48 ` [PATCH RESEND 06/28] staging: unisys: visornic: Correct comment spelling mistake David Kershner
2016-06-11  1:48 ` [PATCH RESEND 07/28] staging: unisys: include: Remove thread-related enum members David Kershner
2016-06-11  1:48 ` [PATCH RESEND 08/28] staging: unisys: visorbus: removed unused periodic_test_workqueue David Kershner
2016-06-11  1:48 ` [PATCH RESEND 09/28] staging: unisys: visorinput: remove unnecessary locking David Kershner
2016-06-11  1:48 ` [PATCH RESEND 10/28] staging: unisys: visorbus: use kernel timer instead of workqueue David Kershner
2016-06-11  1:48 ` [PATCH RESEND 11/28] staging: unisys: visorbus: remove periodic_work.h/.c David Kershner
2016-06-11  1:48 ` [PATCH RESEND 12/28] staging: unisys: visorbus: Make visordriver_callback_lock a mutex David Kershner
2016-06-11  1:48 ` [PATCH RESEND 13/28] staging: unisys: visorbus: Remove unnecessary EXPORT_SYMBOL statements David Kershner
2016-06-11  1:48 ` [PATCH RESEND 14/28] staging: unisys: visorbus: Remove unused functions David Kershner
2016-06-11  1:48 ` [PATCH RESEND 15/28] staging: unisys: Remove reference to unused STANDALONE_CLIENT David Kershner
2016-06-11  1:48 ` [PATCH RESEND 16/28] staging: unisys: visorbus: remove unused parameter from function David Kershner
2016-06-11  1:48 ` [PATCH RESEND 17/28] staging: unisys: visorbus: fix commenting in vbusdevinfo.h David Kershner
2016-06-11  1:48 ` [PATCH RESEND 18/28] staging: unisys: visorbus: fix commenting in visorbus_main.c David Kershner
2016-06-11  1:48 ` [PATCH RESEND 19/28] staging: unisys: visorbus: fix visorchannel.c comments David Kershner
2016-06-11  1:48 ` [PATCH RESEND 20/28] staging: unisys: visorbus: Rectify commenting in visorchipset.c David Kershner
2016-06-11  1:48 ` [PATCH RESEND 21/28] staging: unisys: visorbus: Move visorbus-unique functions to private header David Kershner
2016-06-11  1:48 ` [PATCH RESEND 22/28] staging: unisys: visorbus: rectify kerneldoc comment for struct David Kershner
2016-06-11  1:48 ` [PATCH RESEND 23/28] staging: unisys: visorbus: Remove notifier-related code from visorbus David Kershner
2016-06-11  1:48 ` [PATCH RESEND 24/28] staging: unisys: visorbus: Rename function to follow existing convention David Kershner
2016-06-11  1:48 ` [PATCH RESEND 25/28] staging: unisys: visorbus: fix visorbus_private.h comments David Kershner
2016-06-11  1:48 ` [PATCH RESEND 26/28] staging: unisys: Move vbushelper.h to visorbus directory David Kershner
2016-06-11  1:48 ` [PATCH RESEND 27/28] staging: unisys: visorinput: ensure proper locking wrt creation & ints David Kershner
2016-06-11  1:48 ` [PATCH RESEND 28/28] staging: unisys: visorinput: make lock_visor_dev a mutex David Kershner
2016-06-11  9:42 ` Thomas Gleixner [this message]
2016-06-14 13:26 ` [PATCH RESEND 00/28] staging: unisys: fix visorbus & visorinput issues raised by tglx Neil Horman
2016-06-16 17:35   ` Kershner, David A
2016-06-16 19:02     ` gregkh
2016-07-27 17:43       ` Kershner, David A
2016-07-27 18:02         ` gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1606111141190.5839@nanos \
    --to=tglx@linutronix.de \
    --cc=david.binder@unisys.com \
    --cc=david.kershner@unisys.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jes.sorensen@redhat.com \
    --cc=nhorman@redhat.com \
    --cc=sparmaintainer@unisys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.