[PATCH nf-next] ipset: remove unused function __ip_set_get_netlink

[PATCH nf-next] ipset: remove unused function __ip_set_get_netlink

[Aaron Conole]

There are no in-tree callers.

Signed-off-by: Aaron Conole <aconole@bytheb.org>
---
 net/netfilter/ipset/ip_set_core.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c
index c296f9b..68ba531 100644
--- a/net/netfilter/ipset/ip_set_core.c
+++ b/net/netfilter/ipset/ip_set_core.c
@@ -501,14 +501,6 @@ __ip_set_put(struct ip_set *set)
  * a separate reference counter
  */
 static inline void
-__ip_set_get_netlink(struct ip_set *set)
-{
-	write_lock_bh(&ip_set_ref_lock);
-	set->ref_netlink++;
-	write_unlock_bh(&ip_set_ref_lock);
-}
-
-static inline void
 __ip_set_put_netlink(struct ip_set *set)
 {
 	write_lock_bh(&ip_set_ref_lock);
-- 
2.9.3

Re: [PATCH nf-next] ipset: remove unused function __ip_set_get_netlink

[Pablo Neira Ayuso]

On Mon, Apr 10, 2017 at 03:52:37PM -0400, Aaron Conole wrote:
> There are no in-tree callers.

@Jozsef, let me know if I should just take this to save you a pull
request.

Thanks.

> Signed-off-by: Aaron Conole <aconole@bytheb.org>
> ---
>  net/netfilter/ipset/ip_set_core.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c
> index c296f9b..68ba531 100644
> --- a/net/netfilter/ipset/ip_set_core.c
> +++ b/net/netfilter/ipset/ip_set_core.c
> @@ -501,14 +501,6 @@ __ip_set_put(struct ip_set *set)
>   * a separate reference counter
>   */
>  static inline void
> -__ip_set_get_netlink(struct ip_set *set)
> -{
> -	write_lock_bh(&ip_set_ref_lock);
> -	set->ref_netlink++;
> -	write_unlock_bh(&ip_set_ref_lock);
> -}
> -
> -static inline void
>  __ip_set_put_netlink(struct ip_set *set)
>  {
>  	write_lock_bh(&ip_set_ref_lock);
> -- 
> 2.9.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH nf-next] ipset: remove unused function __ip_set_get_netlink

[Jozsef Kadlecsik]

Hi Pablo,

On Fri, 14 Apr 2017, Pablo Neira Ayuso wrote:

> On Mon, Apr 10, 2017 at 03:52:37PM -0400, Aaron Conole wrote:
> > There are no in-tree callers.
> 
> @Jozsef, let me know if I should just take this to save you a pull
> request.

Just take it, thank you.

Acked-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>

Best regards,
Jozsef

> > Signed-off-by: Aaron Conole <aconole@bytheb.org>
> > ---
> >  net/netfilter/ipset/ip_set_core.c | 8 --------
> >  1 file changed, 8 deletions(-)
> > 
> > diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c
> > index c296f9b..68ba531 100644
> > --- a/net/netfilter/ipset/ip_set_core.c
> > +++ b/net/netfilter/ipset/ip_set_core.c
> > @@ -501,14 +501,6 @@ __ip_set_put(struct ip_set *set)
> >   * a separate reference counter
> >   */
> >  static inline void
> > -__ip_set_get_netlink(struct ip_set *set)
> > -{
> > -	write_lock_bh(&ip_set_ref_lock);
> > -	set->ref_netlink++;
> > -	write_unlock_bh(&ip_set_ref_lock);
> > -}
> > -
> > -static inline void
> >  __ip_set_put_netlink(struct ip_set *set)
> >  {
> >  	write_lock_bh(&ip_set_ref_lock);
> > -- 
> > 2.9.3
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary

Re: [PATCH nf-next] ipset: remove unused function __ip_set_get_netlink

[Pablo Neira Ayuso]

On Fri, Apr 14, 2017 at 04:15:41PM +0200, Jozsef Kadlecsik wrote:
> Hi Pablo,
> 
> On Fri, 14 Apr 2017, Pablo Neira Ayuso wrote:
> 
> > On Mon, Apr 10, 2017 at 03:52:37PM -0400, Aaron Conole wrote:
> > > There are no in-tree callers.
> > 
> > @Jozsef, let me know if I should just take this to save you a pull
> > request.
> 
> Just take it, thank you.
> 
> Acked-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>

Applied, thanks Jozsef.