All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jeff King" <peff@peff.net>,
	git@vger.kernel.org, "Yaroslav Halchenko" <yoh@onerussian.com>,
	"SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH] commit: ensure correct permissions of the commit message
Date: Fri, 1 Jan 2016 16:04:25 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1601011604070.14434@virtualbox> (raw)
In-Reply-To: <xmqqfuyjczpv.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Wed, 30 Dec 2015, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > So maybe
> >
> > 	fcreate_or_truncate(const char *path)
> > 	{
> > 		 FILE *ret = fopen(path, "w");
> >
> > 		 if (!ret && errno == EPERM) {
> > 			 if (!unlink(path))
> > 				 ret = fopen(path, "w");
> > 			 else
> > 				 errno = EPERM;
> > 		 }
> > 		 return ret;
> > 	 }
> >
> > ?
> 
> I do not know fcreate_or_truncate() is a good name, though.

So what would be a good name?

Ciao,
Dscho

  reply	other threads:[~2016-01-01 15:04 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-19 18:21 [PATCH] commit: ensure correct permissions of the commit message Johannes Schindelin
2015-12-20  7:45 ` Jeff King
2015-12-20 14:21   ` Johannes Schindelin
2015-12-20 22:57     ` Torsten Bögershausen
2015-12-30 14:57       ` Johannes Schindelin
2015-12-21  1:31   ` Junio C Hamano
2015-12-21  6:59     ` Jeff King
2015-12-21 17:22       ` Junio C Hamano
2015-12-30 14:50         ` Johannes Schindelin
2015-12-30 22:56           ` Junio C Hamano
2016-01-01 15:04             ` Johannes Schindelin [this message]
2016-01-04 18:34               ` Junio C Hamano
2016-01-05 12:52                 ` Johannes Schindelin
2016-01-05 19:39                   ` Junio C Hamano
2016-01-06  8:20                     ` Johannes Schindelin
2016-01-06  8:23                       ` Jeff King
2016-01-06  8:50                         ` Johannes Schindelin
2016-01-15  1:12     ` SZEDER Gábor
2016-01-15  1:29       ` Junio C Hamano
2016-01-15  6:51         ` Johannes Schindelin
2016-01-15 10:51         ` SZEDER Gábor
2016-01-15 12:18           ` Johannes Schindelin
2016-01-06 13:09 ` [PATCH v2 0/2] Correctly handle transient files in shared repositories Johannes Schindelin
2016-01-06 13:09   ` [PATCH v2 1/2] commit: allow editing the commit message even in shared repos Johannes Schindelin
2016-01-07 12:41     ` Jeff King
2016-01-07 21:35       ` Junio C Hamano
2016-01-06 13:09   ` [PATCH v2 2/2] Handle more file writes correctly " Johannes Schindelin
2016-01-07 12:46     ` Jeff King
2016-01-08 16:04       ` Johannes Schindelin
2016-01-07 21:52     ` Junio C Hamano
2016-01-08 16:05       ` Johannes Schindelin
2016-01-08 17:59         ` Junio C Hamano
2016-01-11  9:28           ` Johannes Schindelin
2016-01-11 15:57             ` Junio C Hamano
2016-01-11 17:06               ` Junio C Hamano
2016-01-11 18:35   ` [PATCH v3 0/2] Correctly handle transient files in shared repositories Johannes Schindelin
2016-01-11 18:35     ` [PATCH v3 1/2] commit: allow editing the commit message even in shared repos Johannes Schindelin
2016-01-11 18:35     ` [PATCH v3 2/2] Handle more file writes correctly " Johannes Schindelin
2016-01-11 20:22     ` [PATCH v3 0/2] Correctly handle transient files in shared repositories Jeff King
2016-01-11 21:12     ` Junio C Hamano
2016-01-11 21:22       ` Junio C Hamano
2016-01-11 21:38         ` Jeff King
2016-01-11 21:54           ` Junio C Hamano
2016-01-11 22:06             ` Jeff King
2016-01-12  8:05               ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1601011604070.14434@virtualbox \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=szeder@ira.uka.de \
    --cc=yoh@onerussian.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.