From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Lameter Subject: Re: [PATCH 1/3] ib core: Make device counter infrastructure dynamic Date: Fri, 18 Mar 2016 09:33:28 -0500 (CDT) Message-ID: References: <20160315155441.222586021@linux.com> <20160315155455.173645653@linux.com> <20160317072354.GB25216@leon.nu> <20160317081716.GD25216@leon.nu> <20160318062009.GI25216@leon.nu> Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20160318062009.GI25216-2ukJVAZIZ/Y@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Bloch , Jason Gunthorpe , Steve Wise , Majd Dibbiny , alonvi-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Fri, 18 Mar 2016, Leon Romanovsky wrote: > It makes the stat.name check redundant. Do you have scenario in mind > where ret == 0 and stat.name == NULL as a result of call to the > function? This is a function provided by those writing the device drivers. Better check that the function filled out at least one required value. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html