From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932652AbcGHQVF (ORCPT ); Fri, 8 Jul 2016 12:21:05 -0400 Received: from resqmta-ch2-09v.sys.comcast.net ([69.252.207.41]:50822 "EHLO resqmta-ch2-09v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932745AbcGHQUv (ORCPT ); Fri, 8 Jul 2016 12:20:51 -0400 Date: Fri, 8 Jul 2016 11:20:47 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@east.gentwo.org To: Kees Cook cc: Michael Ellerman , "kernel-hardening@lists.openwall.com" , Jan Kara , Catalin Marinas , Will Deacon , Linux-MM , sparclinux , linux-ia64@vger.kernel.org, Andrea Arcangeli , linux-arch , "x86@kernel.org" , Russell King , PaX Team , Borislav Petkov , lin , Mathias Krause , Fenghua Yu , Rik van Riel , David Rientjes , Tony Luck , Andy Lutomirski , Joonsoo Kim , Dmitry Vyukov , Laura Abbott , Brad Spengler , Ard Biesheuvel , LKML , Pekka Enberg , Case y Schauf ler , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , "David S. Miller" Subject: Re: [kernel-hardening] Re: [PATCH 9/9] mm: SLUB hardened usercopy support In-Reply-To: Message-ID: References: <577f7e55.4668420a.84f17.5cb9SMTPIN_ADDED_MISSING@mx.google.com> Content-Type: text/plain; charset=US-ASCII X-CMAE-Envelope: MS4wfGkdobmjDyUANxkZ5pYKBF0a6TUchcIb/E97AlrPS1jwIMrHKQ47XR+hKg8k7URTWNTILHN0ClZBu44MlcBnq4MB4quHsTue+edU7d6j4TL1MPnJwUxN o9XCI0NpEb8041Agj3da3g7RCHumUJZsMg85K9jwR86R68NeyOZkWFKrnT2/THFB6hoXEQKxKR3oWx2UX3O36OOB8y2+aGxq+uGRtNKIkkVi5EPjHMMDnDBU HcVwaibVYZzODloKIMTQypx6iHRRZ8DrDbmv8yePXG0NxSVjf3kfEK8Z1xVLKPBar2KaAq+7NhvwNZ6Y4kp52UlwfL+x/2zdt2gYHIl/Zu0VzfltRj4YyYyn 6QrEvwpBhlRXC9/wJm1HfaVz85ukIHitv2KjeyuvB0HAfDn9MzVkTePxOwmp1z0D6JjwkMtij8Na2XoUDZfsfkLH21QfOVZrVwB4FxlZQ+R+CLf9T8Cv6GXK U2ueY6V5Z9AzQ6q9dudr90FQrcLfGJ5z3LgAE2M4fuRGm7+kku/Kx2gNzR0J4mcrp7AuhwPLgSJFDA1fEByJ+3fMDVs7n1VDU609y5YPCgUopFBnSuqRmwHL 1L2UHAm3idd6FzWDz5Rh+IRdIM7DJ0oFu8wjcIulb48qUpvqhqBU6ToVf5fU3EzthGGBilNtD051NcTd5/tSys6aAw//MfZI1ngkfDGrKy4cGMi2N9PbHgTI 0lKNKTZ427JcA9YKXv2m2zkzy7A45clSkW2nYHF1HrP8yY6OznwgnWncnIOj46y5PbRpdUtozn9v4M5OcNgf7UbXuyHFHPLtOQlP7SPkED46qHrgVWa1H1Cx ua6BomuueNGZ/CWhxWWt5G6fRu5m+hchHioaStuMdYwDPYvoMcnuFyLv8OKOMqXYACG7iJ4FilhImrJzP0GvM0tkNWpGF6LnWllp7kbirrzFg8quHjzi7jma 7BZCmkEgO01YllckSIVJo2dzD3hNI3GBy9sMEv+hQMtAsb+ZAgBvzdscOD2zDgnkPo2JfuQfr/qkDgPusLLFssK2v2YuTy9VbqDb4Zqe5JqUhjLeJ1p9uuWo wSmJXX00ZwnehY7j9ioDkD0awf+NACLUYI2Rk3gciGgbRLGuZkUuVKdxM9JmQIqPWHiOQQnOYLy1+8P7Zj9uFQchlczRARusksgpyhG18jDySVDmZ84m4na3 Wx5SaPAMRWG713Jw+14KtYYCTdAKkbUUm5H2MwX5tmnoEjeYRad/sgUtb/Dqvlsb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Jul 2016, Kees Cook wrote: > Is check_valid_pointer() making sure the pointer is within the usable > size? It seemed like it was checking that it was within the slub > object (checks against s->size, wants it above base after moving > pointer to include redzone, etc). check_valid_pointer verifies that a pointer is pointing to the start of an object. It is used to verify the internal points that SLUB used and should not be modified to do anything different. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Lameter Subject: Re: Re: [PATCH 9/9] mm: SLUB hardened usercopy support Date: Fri, 8 Jul 2016 11:20:47 -0500 (CDT) Message-ID: References: <577f7e55.4668420a.84f17.5cb9SMTPIN_ADDED_MISSING@mx.google.com> Reply-To: kernel-hardening@lists.openwall.com Content-Type: text/plain; charset=US-ASCII Return-path: List-Post: List-Help: List-Unsubscribe: List-Subscribe: In-Reply-To: To: Kees Cook Cc: Michael Ellerman , "kernel-hardening@lists.openwall.com" , Jan Kara , Catalin Marinas , Will Deacon , Linux-MM , sparclinux , linux-ia64@vger.kernel.org, Andrea Arcangeli , linux-arch , "x86@kernel.org" , Russell King , PaX Team , Borislav Petkov , lin , Mathias Krause , Fenghua Yu , Rik van Riel , David Rientjes , Tony Luck , Andy Lutomirski , Joonsoo Kim , Dmitry List-Id: linux-arch.vger.kernel.org On Fri, 8 Jul 2016, Kees Cook wrote: > Is check_valid_pointer() making sure the pointer is within the usable > size? It seemed like it was checking that it was within the slub > object (checks against s->size, wants it above base after moving > pointer to include redzone, etc). check_valid_pointer verifies that a pointer is pointing to the start of an object. It is used to verify the internal points that SLUB used and should not be modified to do anything different. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from resqmta-ch2-04v.sys.comcast.net ([69.252.207.36]:58922 "EHLO resqmta-ch2-04v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932731AbcGHQUv (ORCPT ); Fri, 8 Jul 2016 12:20:51 -0400 Date: Fri, 8 Jul 2016 11:20:47 -0500 (CDT) From: Christoph Lameter Subject: Re: [kernel-hardening] Re: [PATCH 9/9] mm: SLUB hardened usercopy support In-Reply-To: Message-ID: References: <577f7e55.4668420a.84f17.5cb9SMTPIN_ADDED_MISSING@mx.google.com> Content-Type: text/plain; charset=US-ASCII Sender: linux-arch-owner@vger.kernel.org List-ID: To: Kees Cook Cc: Michael Ellerman , "kernel-hardening@lists.openwall.com" , Jan Kara , Catalin Marinas , Will Deacon , Linux-MM , sparclinux , linux-ia64@vger.kernel.org, Andrea Arcangeli , linux-arch , "x86@kernel.org" , Russell King , PaX Team , Borislav Petkov , lin , Mathias Krause , Fenghua Yu , Rik van Riel , David Rientjes , Tony Luck , Andy Lutomirski , Joonsoo Kim , Dmitry Vyukov , Laura Abbott , Brad Spengler , Ard Biesheuvel , LKML , Pekka Enberg , Case y Schauf ler , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , "David S. Miller" Message-ID: <20160708162047.CXqzrgEcSFlZ11DsL666nCXsa2ZE736aYhppsNimPvM@z> On Fri, 8 Jul 2016, Kees Cook wrote: > Is check_valid_pointer() making sure the pointer is within the usable > size? It seemed like it was checking that it was within the slub > object (checks against s->size, wants it above base after moving > pointer to include redzone, etc). check_valid_pointer verifies that a pointer is pointing to the start of an object. It is used to verify the internal points that SLUB used and should not be modified to do anything different. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Lameter Date: Fri, 08 Jul 2016 16:20:47 +0000 Subject: Re: [kernel-hardening] Re: [PATCH 9/9] mm: SLUB hardened usercopy support Message-Id: List-Id: References: <577f7e55.4668420a.84f17.5cb9SMTPIN_ADDED_MISSING@mx.google.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kees Cook Cc: Michael Ellerman , "kernel-hardening@lists.openwall.com" , Jan Kara , Catalin Marinas , Will Deacon , Linux-MM , sparclinux , linux-ia64@vger.kernel.org, Andrea Arcangeli , linux-arch , "x86@kernel.org" , Russell King , PaX Team , Borislav Petkov , lin , Mathias Krause , Fenghua Yu , Rik van Riel , David Rientjes , Tony Luck , Andy Lutomirski , Joonsoo Kim , Dmitry Vyukov , Laura Abbott , Brad Spengler , Ard Biesheuvel , LKML , Pekka Enberg , Case y Schauf ler , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , "David S. Miller" On Fri, 8 Jul 2016, Kees Cook wrote: > Is check_valid_pointer() making sure the pointer is within the usable > size? It seemed like it was checking that it was within the slub > object (checks against s->size, wants it above base after moving > pointer to include redzone, etc). check_valid_pointer verifies that a pointer is pointing to the start of an object. It is used to verify the internal points that SLUB used and should not be modified to do anything different. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f197.google.com (mail-ob0-f197.google.com [209.85.214.197]) by kanga.kvack.org (Postfix) with ESMTP id 48BBE6B0005 for ; Fri, 8 Jul 2016 12:20:51 -0400 (EDT) Received: by mail-ob0-f197.google.com with SMTP id t8so54836289obs.2 for ; Fri, 08 Jul 2016 09:20:51 -0700 (PDT) Received: from resqmta-ch2-04v.sys.comcast.net (resqmta-ch2-04v.sys.comcast.net. [2001:558:fe21:29:69:252:207:36]) by mx.google.com with ESMTPS id p9si3215235itd.38.2016.07.08.09.20.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Jul 2016 09:20:50 -0700 (PDT) Date: Fri, 8 Jul 2016 11:20:47 -0500 (CDT) From: Christoph Lameter Subject: Re: [kernel-hardening] Re: [PATCH 9/9] mm: SLUB hardened usercopy support In-Reply-To: Message-ID: References: <577f7e55.4668420a.84f17.5cb9SMTPIN_ADDED_MISSING@mx.google.com> Content-Type: text/plain; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Kees Cook Cc: Michael Ellerman , "kernel-hardening@lists.openwall.com" , Jan Kara , Catalin Marinas , Will Deacon , Linux-MM , sparclinux , linux-ia64@vger.kernel.org, Andrea Arcangeli , linux-arch , "x86@kernel.org" , Russell King , PaX Team , Borislav Petkov , lin , Mathias Krause , Fenghua Yu , Rik van Riel , David Rientjes , Tony Luck , Andy Lutomirski , Joonsoo Kim , Dmitry Vyukov , Laura Abbott , Brad Spengler , Ard Biesheuvel , LKML , Pekka Enberg , Case y Schauf ler , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , "David S. Miller" On Fri, 8 Jul 2016, Kees Cook wrote: > Is check_valid_pointer() making sure the pointer is within the usable > size? It seemed like it was checking that it was within the slub > object (checks against s->size, wants it above base after moving > pointer to include redzone, etc). check_valid_pointer verifies that a pointer is pointing to the start of an object. It is used to verify the internal points that SLUB used and should not be modified to do anything different. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org