From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay1.mentorg.com ([192.94.38.131]:48927 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752353AbcHQPof (ORCPT ); Wed, 17 Aug 2016 11:44:35 -0400 Date: Wed, 17 Aug 2016 15:44:08 +0000 From: Joseph Myers To: Jeff Layton CC: , , Michael Kerrisk , Carlos O'Donell , Yuriy Kolerov Subject: Re: [glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64 In-Reply-To: <1471445251-2450-1-git-send-email-jlayton@redhat.com> Message-ID: References: <1471445251-2450-1-git-send-email-jlayton@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 17 Aug 2016, Jeff Layton wrote: > +# if __WORDSIZE != 32 || defined __USE_FILE_OFFSET64 Are you sure __WORDSIZE is always defined here? I don't see an include of in this header. Are you sure __WORDSIZE != 32 is the right condition on all architectures for the flock and flock64 structures being the same? Wordsize is not a particularly well-defined concept all cases. More specific tests tend to be preferred, e.g. __OFF_T_MATCHES_OFF64_T in bits/typesizes.h (so this would indicate having a new macro __FLOCK_MATCHES_FLOCK64 and arranging for it to be defined to 1 or 0 correctly in all cases - or at least a careful analysis of all architectures using this file to show that some other conditional is always correct). -- Joseph S. Myers joseph@codesourcery.com