From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754355AbcIJGNg (ORCPT ); Sat, 10 Sep 2016 02:13:36 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:50732 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753117AbcIJGNe (ORCPT ); Sat, 10 Sep 2016 02:13:34 -0400 Date: Sat, 10 Sep 2016 08:10:59 +0200 (CEST) From: Thomas Gleixner To: Mark Brown cc: Binoy Jayan , Carsten Emde , "Steven Rostedt (Red Hat)" , Ingo Molnar , Daniel Wagner , Arnd Bergmann , Linux kernel mailing list , Masami Subject: Re: [PATCH v6 4/4] tracing: Histogram for delayed hrtimer offsets In-Reply-To: <20160909171004.GU27946@sirena.org.uk> Message-ID: References: <1473246835-30075-1-git-send-email-binoy.jayan@linaro.org> <1473246835-30075-5-git-send-email-binoy.jayan@linaro.org> <20160909171004.GU27946@sirena.org.uk> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Sep 2016, Mark Brown wrote: > On Thu, Sep 08, 2016 at 03:09:36PM +0530, Binoy Jayan wrote: > > On 8 September 2016 at 12:40, Thomas Gleixner wrote: > > > On Wed, 7 Sep 2016, Binoy Jayan wrote: > > > >> +#ifdef CONFIG_DELAYED_TIMER_OFFSETS_HIST > > >> + ktime_t praecox; > > >> +#endif > > > > And of course documenting new struct members is optional, correct? I'm > > > really looking forward for the explanation of that variable name. > > > It marks the start time when a process is scheduled to be woken up as > > the result > > of expiry of the hrtimer. Will be mentioning it in the comments. > > Even with an appropriate comment I'm not sure that the term praecox is > sufficiently widely understood to be a clear variable name. For those who understand it and know the main use case of this term it certainly has entertainment value. Thanks, tglx