From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755598AbcIUMdD (ORCPT ); Wed, 21 Sep 2016 08:33:03 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:34384 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755170AbcIUMdB (ORCPT ); Wed, 21 Sep 2016 08:33:01 -0400 Date: Wed, 21 Sep 2016 14:30:32 +0200 (CEST) From: Thomas Gleixner To: Andi Kleen cc: x86@kernel.org, LKML , Andi Kleen , hmh@hmh.eng.br, bp@alien8.de Subject: Re: [PATCH] x86: Report Intel platform_id in /proc/cpuinfo In-Reply-To: <20160602155127.76987-1-andi@firstfloor.org> Message-ID: References: <20160602155127.76987-1-andi@firstfloor.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2 Jun 2016, Andi Kleen wrote: Sorry for answering late. This got stuck in my backlog forever. > diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c > index ee81c54..bcd3f59 100644 > --- a/arch/x86/kernel/cpu/microcode/intel.c > +++ b/arch/x86/kernel/cpu/microcode/intel.c > @@ -812,6 +812,8 @@ static int collect_cpu_info(int cpu_num, struct cpu_signature *csig) > /* get processor flags from MSR 0x17 */ > rdmsr(MSR_IA32_PLATFORM_ID, val[0], val[1]); > csig->pf = 1 << ((val[1] >> 18) & 7); > + cpu_data(cpu_num).platform_id = (val[1] >> 18) & 7; > + cpu_data(cpu_num).has_platform_id = true; Please move that evaluation to arch/x86/kernel/cpu/intel.c and let the micro code driver use the information from cpu_data. Thanks, tglx