From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965022AbcIWIPG (ORCPT ); Fri, 23 Sep 2016 04:15:06 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:40445 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934293AbcIWIPB (ORCPT ); Fri, 23 Sep 2016 04:15:01 -0400 Date: Fri, 23 Sep 2016 10:12:31 +0200 (CEST) From: Thomas Gleixner To: Andi Kleen cc: x86@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen , hmh@hmh.eng.br Subject: Re: [PATCH] x86: Report Intel platform_id in /proc/cpuinfo In-Reply-To: <1474591707-18587-1-git-send-email-andi@firstfloor.org> Message-ID: References: <1474591707-18587-1-git-send-email-andi@firstfloor.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Sep 2016, Andi Kleen wrote: > The processor flags are already used in the microcode driver. > The MSR can be also accessed through /dev/cpu/*/msr, but that > requires root and is awkward. > > This patch just exports the value retrieved by the microcode > driver in /proc/cpuinfo. If the microcode driver is disabled > it won't be shown, but that seems reasonable. The patch is fine, but these two paragraphs are describing something else. Thanks, tglx