From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752213AbcJDOWg (ORCPT ); Tue, 4 Oct 2016 10:22:36 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:36576 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbcJDOWf (ORCPT ); Tue, 4 Oct 2016 10:22:35 -0400 Date: Tue, 4 Oct 2016 16:19:59 +0200 (CEST) From: Thomas Gleixner To: Jiri Olsa cc: Prarit Bhargava , linux-kernel@vger.kernel.org, Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Peter Zijlstra , Len Brown , Borislav Petkov , Andi Kleen , Juergen Gross , dyoung@redhat.com, Eric Biederman , kexec@lists.infradead.org Subject: Re: [PATCH] arch/x86: Fix kdump on x86 with physically hotadded CPUs In-Reply-To: <20161004122717.GA4998@krava> Message-ID: References: <1475514432-27682-1-git-send-email-prarit@redhat.com> <20161004122717.GA4998@krava> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Oct 2016, Jiri Olsa wrote: > On Tue, Oct 04, 2016 at 12:58:04PM +0200, Thomas Gleixner wrote: > > > pmu->boxes[pkg] is garbage because pkg was returned as 0xffff. > > > > And that's what needs to be fixed in the first place. > > right, I'll check on that.. but I think we need this fix as well That's right. > I was wondering if acpi_boot_init was a better place for that, but then > Prarit suggested in our discussion that the prefill_possible_map() call > seems to be a hotplug cleanup.. so it seemed to fit It's the right place for it. Thanks, tglx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galois.linutronix.de ([2a01:7a0:2:106d:700::1]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1brQdZ-0000Eq-Ic for kexec@lists.infradead.org; Tue, 04 Oct 2016 14:24:06 +0000 Date: Tue, 4 Oct 2016 16:19:59 +0200 (CEST) From: Thomas Gleixner Subject: Re: [PATCH] arch/x86: Fix kdump on x86 with physically hotadded CPUs In-Reply-To: <20161004122717.GA4998@krava> Message-ID: References: <1475514432-27682-1-git-send-email-prarit@redhat.com> <20161004122717.GA4998@krava> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Jiri Olsa Cc: Prarit Bhargava , Len Brown , Andi Kleen , Juergen Gross , Peter Zijlstra , x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Ingo Molnar , Eric Biederman , "H. Peter Anvin" , Borislav Petkov , dyoung@redhat.com On Tue, 4 Oct 2016, Jiri Olsa wrote: > On Tue, Oct 04, 2016 at 12:58:04PM +0200, Thomas Gleixner wrote: > > > pmu->boxes[pkg] is garbage because pkg was returned as 0xffff. > > > > And that's what needs to be fixed in the first place. > > right, I'll check on that.. but I think we need this fix as well That's right. > I was wondering if acpi_boot_init was a better place for that, but then > Prarit suggested in our discussion that the prefill_possible_map() call > seems to be a hotplug cleanup.. so it seemed to fit It's the right place for it. Thanks, tglx _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec