Re: [Outreachy kernel] [PATCH] staging: rtl8188eu: core: constify local structure

[Julia Lawall <julia.lawall@lip6.fr>]

On Sun, 16 Oct 2016, Elizabeth Ferdman wrote:

> Constify the static struct RTW_CHANNEL_PLAN_MAP_REALTEK_DEFINE.
>
> The only other instance was one of its properties being assigned to a
> variable:
> Index2G = RTW_CHANNEL_PLAN_MAP_REALTEK_DEFINE.Index2G;
>
> Therefore this is a good candidate for constification.
>
> Running size did not show any difference:
> Before/After:
> text    data     bss     dec     hex filename
> 44122     408    2974   47504    b990

This is not a good sign.  It suggests that you have not actually compiled
the lines of code that you changed.

It is a little bit strange that a structure is declared to only contain
the number 3.

I wonder if something else is going on?

julia

>
> Lastly, break up the long line to fix the checkpatch warning and conform
> to kernel coding style.
>
> Signed-off-by: Elizabeth Ferdman <gnudevliz@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> index fb13df5..c94700c 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> @@ -133,7 +133,9 @@ static struct rt_channel_plan_map	RTW_ChannelPlanMap[RT_CHANNEL_DOMAIN_MAX] = {
>  	{0x03},	/* 0x41, RT_CHANNEL_DOMAIN_GLOBAL_DOAMIN_2G */
>  };
>
> -static struct rt_channel_plan_map RTW_CHANNEL_PLAN_MAP_REALTEK_DEFINE = {0x03}; /* use the combination for max channel numbers */
> +static const struct rt_channel_plan_map RTW_CHANNEL_PLAN_MAP_REALTEK_DEFINE = {
> +	0x03
> +}; /* use the combination for max channel numbers */
>
>  /*
>   * Search the @param channel_num in given @param channel_set
> --
> 2.1.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161017064620.GA21653%40localhost.
> For more options, visit https://groups.google.com/d/optout.
>