From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754818AbcKJKZF (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Nov 2016 05:25:05 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:60972 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754183AbcKJKZE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Nov 2016 05:25:04 -0500
Date: Thu, 10 Nov 2016 11:22:22 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
cc: "Luck, Tony" <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rt@linutronix.de" <rt@linutronix.de>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH 22/25] x86/mcheck: Do the init in one place
In-Reply-To: <20161110090037.apohiqnqgbymbq6j@linutronix.de>
Message-ID: <alpine.DEB.2.20.1611101121310.3501@nanos>
References: <20161103145021.28528-1-bigeasy@linutronix.de> <20161103145021.28528-23-bigeasy@linutronix.de> <20161107184532.xj6wzdjlzwhshcmf@pd.tnic> <20161107185524.GA2536@intel.com> <20161107201224.7xazmhgm7bogkrw5@pd.tnic> <20161108092302.wraci5m2cxqozlew@pd.tnic>
 <20161109142221.3r6xwhkxbckuv3bh@linutronix.de> <20161109153807.7mv7b5f4oqfijq2h@pd.tnic> <3908561D78D1C84285E8C5FCA982C28F3A229E6C@ORSMSX114.amr.corp.intel.com> <20161110090037.apohiqnqgbymbq6j@linutronix.de>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 10 Nov 2016, Sebastian Andrzej Siewior wrote:

> On 2016-11-09 18:37:23 [+0000], Luck, Tony wrote:
> > > That's why the hotplug callback mce_disable_cpu() doesn't fiddle with
> > > CR4 - it only clears the bits in MCi_CTL. And I think we should remain
> > > that way.
> > 
> > N.B. See vendor_disable_error_reporting() ... on Intel we don't clear MCi_CTL.
> 
> okay. So I had a discussion with Boris and we agreed that we don't do
> the init part in one place only the timer stuff will be moved.
> If I understand Tony correctly then we undo something in
> vendor_disable_error_reporting() (on !INTEL CPUs) that we enable in
> identify_cpu().

Why on earth do we enable MCE stuff in identify_cpu() ?

Thanks,

	tglx