From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752933AbcKUI6n (ORCPT ); Mon, 21 Nov 2016 03:58:43 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:55766 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798AbcKUI6n (ORCPT ); Mon, 21 Nov 2016 03:58:43 -0500 Date: Mon, 21 Nov 2016 09:56:00 +0100 (CET) From: Thomas Gleixner To: Baolin Wang cc: Ingo Molnar , John Stultz , lkml , Richard Cochran , Steven Rostedt Subject: Re: [PATCH 1/4] time: alarmtimer: Add the trcepoints for alarmtimer In-Reply-To: Message-ID: References: <1479531014-25264-1-git-send-email-john.stultz@linaro.org> <1479531014-25264-2-git-send-email-john.stultz@linaro.org> <20161121081301.GA14231@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Nov 2016, Baolin Wang wrote: > On 21 November 2016 at 16:13, Ingo Molnar wrote: > > Hm, there's a weirdness here: if freezer_delta != 0 when alarmtimer_suspend() is > > called then type might be '0', although it's not alarm_bases[0] this value is > > picked up from. > > > > Wouldn't it be better to initialize 'type' to -1 instead? (And rename it to > > min_type or so.) > > Make sense. I will send out new patch to fix this. Thanks for your comments. Can you please fix the subject line while at it? 'trcepoints' does not look right Thanks, tglx