From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932551AbcKYTK0 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 25 Nov 2016 14:10:26 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:41889 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755665AbcKYTKR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 25 Nov 2016 14:10:17 -0500
Date: Fri, 25 Nov 2016 20:06:04 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Ingo Molnar <mingo@kernel.org>
cc: peterz@infradead.org, tim.c.chen@linux.intel.com, hpa@zytor.com,
        srinivas.pandruvada@linux.intel.com, linux-kernel@vger.kernel.org,
        linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/core] x86: Enable Intel Turbo Boost Max Technology
 3.0
In-Reply-To: <20161125081946.GA24513@gmail.com>
Message-ID: <alpine.DEB.2.20.1611251951360.3602@nanos>
References: <cd401ccdff88f88c8349314febdc25d51f7c48f7.1479844244.git.tim.c.chen@linux.intel.com> <tip-5e76b2ab36b40ca33023e78725bdc69eafd63134@git.kernel.org> <20161125081946.GA24513@gmail.com>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 25 Nov 2016, Ingo Molnar wrote:

> 
> * tip-bot for Tim Chen <tipbot@zytor.com> wrote:
> 
> > Commit-ID:  5e76b2ab36b40ca33023e78725bdc69eafd63134
> > Gitweb:     http://git.kernel.org/tip/5e76b2ab36b40ca33023e78725bdc69eafd63134
> > Author:     Tim Chen <tim.c.chen@linux.intel.com>
> > AuthorDate: Tue, 22 Nov 2016 12:23:55 -0800
> > Committer:  Thomas Gleixner <tglx@linutronix.de>
> > CommitDate: Thu, 24 Nov 2016 20:44:19 +0100
> > 
> > x86: Enable Intel Turbo Boost Max Technology 3.0
> 
> This patch doesn't build:
> 
> Note that this patch has to be redone anyway, as it won't even build:

The branch where I merged it to builds fine. 

Though, yes I missed the asm/mutex.h include which obviously should be
linux/mutex.h

> > +#include <linux/sched.h>
> > +#include <linux/cpumask.h>
> > +#include <linux/cpuset.h>
> > +#include <asm/mutex.h>
> > +#include <linux/sched.h>
> > +#include <linux/sysctl.h>
> > +#include <linux/nodemask.h>
> 
> arch/x86/kernel/itmt.c:26:23: fatal error: asm/mutex.h: No such file or directory
> 
> > +config SCHED_ITMT
> > +	bool "Intel Turbo Boost Max Technology (ITMT) scheduler support"
> > +	depends on SCHED_MC && CPU_SUP_INTEL && X86_INTEL_PSTATE
> > +	---help---
> > +	  ITMT enabled scheduler support improves the CPU scheduler's decision
> > +	  to move tasks to cpu core that can be boosted to a higher frequency
> > +	  than others. It will have better performance at a cost of slightly
> > +	  increased overhead in task migrations. If unsure say N here.
> 
> Argh, so the 'itmt' name really sucks as well - could we please make it something 
> more obvious - like SCHED_INTEL_TURBO or so - and similarly rename the file as 
> well?
>
> The sched_intel_turbo.c file could thus host all things related to scheduler 
> support of turbo frequencies - it shouldn't be named after the Intel acronym of 
> the day...

It would be nice to come up with such nitpicks during review. This thing
went through 8 iterations, but nothing came up and I didn't mind the itmt
naming.

Thanks,

	tglx