From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753883AbcK1Rcd (ORCPT <rfc822;w@1wt.eu>);
        Mon, 28 Nov 2016 12:32:33 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:46536 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753585AbcK1RcV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 28 Nov 2016 12:32:21 -0500
Date: Mon, 28 Nov 2016 18:29:41 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
cc: linux-kernel@vger.kernel.org, rt@linutronix.de,
        Len Brown <lenb@kernel.org>, linux-pm@vger.kernel.org
Subject: Re: [PATCH 04/22] idle/intel: Convert to hotplug state machine
In-Reply-To: <20161126231350.10321-5-bigeasy@linutronix.de>
Message-ID: <alpine.DEB.2.20.1611281828050.3512@nanos>
References: <20161126231350.10321-1-bigeasy@linutronix.de> <20161126231350.10321-5-bigeasy@linutronix.de>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 27 Nov 2016, Sebastian Andrzej Siewior wrote:
> +static enum cpuhp_state hp_online;
> +
>  static int __init intel_idle_init(void)
>  {
...

> -	cpu_notifier_register_done();
> +	retval = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "idle/intel:online",
> +				   intel_idle_cpu_online, NULL);
> +	if (retval < 0)
> +		goto hp_setup_fail;
> +	hp_online = retval;

Why do you want to store that. There is no exit function AFAICT.

Thanks,

	tglx