From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Jakub Narębski" <jnareb@gmail.com>
Subject: Re: [PATCH v2 1/1] reset: support the --stdin option
Date: Fri, 27 Jan 2017 18:34:46 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1701271832270.3469@virtualbox> (raw)
In-Reply-To: <20170127170422.lvpghp6jdud37zxx@sigill.intra.peff.net>
Hi Peff,
On Fri, 27 Jan 2017, Jeff King wrote:
> On Fri, Jan 27, 2017 at 01:38:55PM +0100, Johannes Schindelin wrote:
>
> A few minor suggestions:
>
> > +--stdin::
> > + Instead of taking list of paths from the command line,
> > + read list of paths from the standard input. Paths are
> > + separated by LF (i.e. one path per line) by default.
> > +
> > +-z::
> > + Only meaningful with `--stdin`; paths are separated with
> > + NUL character instead of LF.
>
> Is it worth clarifying that these are paths, not pathspecs? The word
> "paths" is used to refer to the pathspecs on the command-line elsewhere
> in the document.
>
> It might also be worth mentioning the quoting rules for the non-z case.
I think this would be overkill. In reality, --stdin without -z does not
make much sense, anyway.
If you feel strongly about it, I encourage you to submit a follow-up
patch.
The rest of your suggestions have been implemented in v3.
Ciao,
Johannes
next prev parent reply other threads:[~2017-01-27 17:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 16:08 [PATCH 0/2] Support `git reset --stdin` Johannes Schindelin
2016-10-11 16:09 ` [PATCH 1/2] reset: fix usage Johannes Schindelin
2016-10-11 16:09 ` [PATCH 2/2] reset: support the --stdin option Johannes Schindelin
2016-10-11 17:53 ` Junio C Hamano
2016-10-12 12:57 ` Johannes Schindelin
2016-10-11 20:49 ` Jakub Narębski
2016-10-12 12:39 ` Johannes Schindelin
2016-10-11 18:34 ` [PATCH 0/2] Support `git reset --stdin` Jeff King
2016-10-11 19:27 ` Junio C Hamano
2016-10-11 21:26 ` Jeff King
2016-10-11 21:36 ` Junio C Hamano
2016-10-11 21:47 ` Jeff King
2016-10-11 21:49 ` Junio C Hamano
2017-01-27 12:38 ` [PATCH v2 0/1] " Johannes Schindelin
2017-01-27 12:38 ` [PATCH v2 1/1] reset: support the --stdin option Johannes Schindelin
2017-01-27 17:04 ` Jeff King
2017-01-27 17:34 ` Johannes Schindelin [this message]
2017-01-27 17:54 ` Jeff King
2017-01-27 18:30 ` Junio C Hamano
2017-01-27 22:12 ` Jeff King
2017-01-28 0:20 ` Junio C Hamano
2017-01-27 17:30 ` [PATCH v3 0/1] Support `git reset --stdin` Johannes Schindelin
2017-01-27 17:30 ` [PATCH v3 1/1] reset: support the --stdin option Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1701271832270.3469@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.