All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	kbuild test robot <lkp@intel.com>,
	kbuild-all@01.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	David Rientjes <rientjes@google.com>,
	Pekka Enberg <penberg@kernel.org>,
	Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size>
Date: Wed, 8 Feb 2017 09:13:14 -0600 (CST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1702080912560.3955@east.gentwo.org> (raw)
In-Reply-To: <d3a1f708-efdd-98c3-9c26-dab600501679@suse.cz>

On Wed, 8 Feb 2017, Vlastimil Babka wrote:

> I was going to implement Christoph's suggestion and export the whole structure
> in mm/slab.h, but gcc was complaining that I'm redefining it, until I created a
> typedef first. Is it worth the trouble? Below is how it would look like.

Looks good to me.

WARNING: multiple messages have this Message-ID
From: Christoph Lameter <cl@linux.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	kbuild test robot <lkp@intel.com>,
	kbuild-all@01.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	David Rientjes <rientjes@google.com>,
	Pekka Enberg <penberg@kernel.org>,
	Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size>
Date: Wed, 8 Feb 2017 09:13:14 -0600 (CST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1702080912560.3955@east.gentwo.org> (raw)
In-Reply-To: <d3a1f708-efdd-98c3-9c26-dab600501679@suse.cz>

On Wed, 8 Feb 2017, Vlastimil Babka wrote:

> I was going to implement Christoph's suggestion and export the whole structure
> in mm/slab.h, but gcc was complaining that I'm redefining it, until I created a
> typedef first. Is it worth the trouble? Below is how it would look like.

Looks good to me.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2017-02-08 15:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-03 18:10 Vlastimil Babka
2017-02-03 18:10 ` Vlastimil Babka
2017-02-04  2:26 ` kbuild test robot
2017-02-04  2:26   ` kbuild test robot
2017-02-04  8:27   ` Vlastimil Babka
2017-02-04  8:27     ` Vlastimil Babka
2017-02-06 14:47 ` Christoph Lameter
2017-02-06 14:47   ` Christoph Lameter
2017-02-06 14:52 ` Matthew Wilcox
2017-02-06 14:52   ` Matthew Wilcox
2017-02-06 14:55   ` Christoph Lameter
2017-02-06 14:55     ` Christoph Lameter
2017-02-07 17:15 ` kbuild test robot
2017-02-07 17:15   ` kbuild test robot
2017-02-07 21:38   ` Andrew Morton
2017-02-07 21:38     ` Andrew Morton
2017-02-08  9:12     ` Vlastimil Babka
2017-02-08  9:12       ` Vlastimil Babka
2017-02-08  9:26       ` Vlastimil Babka
2017-02-08  9:26         ` Vlastimil Babka
2017-02-08 15:13       ` Christoph Lameter [this message]
2017-02-08 15:13         ` Christoph Lameter
2017-02-08 21:54       ` Andrew Morton
2017-02-08 21:54         ` Andrew Morton
2017-02-09  9:12         ` Vlastimil Babka
2017-02-09  9:12           ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1702080912560.3955@east.gentwo.org \
    --to=cl@linux.com \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    --cc=willy@linux.intel.com \
    --subject='Re: [PATCH] mm, slab: rename kmalloc-node cache to kmalloc-<size>' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.