[PATCH] staging: wlan-ng: add blank line after declaration

[PATCH] staging: wlan-ng: add blank line after declaration

[Gargi Sharma]

add blank line after struct declaration to fix the checkpatch issue, add
blank line after declarations.

Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
 drivers/staging/wlan-ng/hfa384x.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 5f1851c..f199847 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
 	enum ctlx_state state;	/* Tracks running state */
 
 	struct completion done;
+
 	volatile int reapable;	/* Food for the reaper task */
 
 	ctlx_cmdcb_t cmdcb;	/* Async command callback */
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] staging: wlan-ng: add blank line after declaration

[Julia Lawall]

On Thu, 16 Feb 2017, Gargi Sharma wrote:

> add blank line after struct declaration to fix the checkpatch issue, add
> blank line after declarations.

This does not look right.  The code before and the code after are all
declarations.  I think that checkpatch is misinterpreting the code.  This
warning is normally targeted at local variables in functions.

The code is fine as is.

julia

> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
>  drivers/staging/wlan-ng/hfa384x.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 5f1851c..f199847 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
>  	enum ctlx_state state;	/* Tracks running state */
>
>  	struct completion done;
> +
>  	volatile int reapable;	/* Food for the reaper task */
>
>  	ctlx_cmdcb_t cmdcb;	/* Async command callback */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1487239937-26115-1-git-send-email-gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] staging: wlan-ng: add blank line after declaration

[Gargi Sharma]

[-- Attachment #1: Type: text/plain, Size: 1748 bytes --]

On Thu, Feb 16, 2017 at 3:49 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
>
> On Thu, 16 Feb 2017, Gargi Sharma wrote:
>
> > add blank line after struct declaration to fix the checkpatch issue, add
> > blank line after declarations.
>
> This does not look right.  The code before and the code after are all
> declarations.  I think that checkpatch is misinterpreting the code.  This

Okay, will revert this commit.

Thanks,
Gargi

> warning is normally targeted at local variables in functions.
>
> The code is fine as is.
>
> julia
>
> > Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> > ---
> >  drivers/staging/wlan-ng/hfa384x.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/wlan-ng/hfa384x.h
b/drivers/staging/wlan-ng/hfa384x.h
> > index 5f1851c..f199847 100644
> > --- a/drivers/staging/wlan-ng/hfa384x.h
> > +++ b/drivers/staging/wlan-ng/hfa384x.h
> > @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
> >       enum ctlx_state state;  /* Tracks running state */
> >
> >       struct completion done;
> > +
> >       volatile int reapable;  /* Food for the reaper task */
> >
> >       ctlx_cmdcb_t cmdcb;     /* Async command callback */
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google
Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/
msgid/outreachy-kernel/1487239937-26115-1-git-send-
email-gs051095%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >

[-- Attachment #2: Type: text/html, Size: 2738 bytes --]

Re: [Outreachy kernel] [PATCH] staging: wlan-ng: add blank line after declaration

[Julia Lawall]

On Thu, 16 Feb 2017, Gargi Sharma wrote:

> add blank line after struct declaration to fix the checkpatch issue, add
> blank line after declarations.

This does not look appropriate.  They are all structure field
declarations.

julia

>
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
>  drivers/staging/wlan-ng/hfa384x.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 5f1851c..f199847 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1175,6 +1175,7 @@ struct hfa384x_usbctlx {
>  	enum ctlx_state state;	/* Tracks running state */
>
>  	struct completion done;
> +
>  	volatile int reapable;	/* Food for the reaper task */
>
>  	ctlx_cmdcb_t cmdcb;	/* Async command callback */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1487264190-6768-1-git-send-email-gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>