From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6391852583766458368 X-Received: by 10.223.162.155 with SMTP id s27mr486355wra.7.1488230141109; Mon, 27 Feb 2017 13:15:41 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.28.52.193 with SMTP id b184ls1282387wma.2.gmail; Mon, 27 Feb 2017 13:15:40 -0800 (PST) X-Received: by 10.28.144.142 with SMTP id s136mr454645wmd.16.1488230140223; Mon, 27 Feb 2017 13:15:40 -0800 (PST) Return-Path: Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr. [192.134.164.104]) by gmr-mx.google.com with ESMTPS id h62si639170wme.2.2017.02.27.13.15.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Feb 2017 13:15:40 -0800 (PST) Received-SPF: neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) client-ip=192.134.164.104; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.134.164.104 is neither permitted nor denied by domain of julia.lawall@lip6.fr) smtp.mailfrom=julia.lawall@lip6.fr X-IronPort-AV: E=Sophos;i="5.35,215,1484002800"; d="scan'208";a="214920364" Received: from 198.67.28.109.rev.sfr.net (HELO hadrien) ([109.28.67.198]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2017 22:15:39 +0100 Date: Mon, 27 Feb 2017 22:15:38 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: simran singhal cc: gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH 4/5] staging: sm750fb: Remove unnecessary else after return In-Reply-To: <1488219268-3006-4-git-send-email-singhalsimran0@gmail.com> Message-ID: References: <1488219268-3006-1-git-send-email-singhalsimran0@gmail.com> <1488219268-3006-4-git-send-email-singhalsimran0@gmail.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 27 Feb 2017, simran singhal wrote: > This patch fixes the checkpatch warning that else is not generally > useful after a break or return. > > This was done using Coccinelle: > @@ > expression e2; > statement s1; > @@ > if(e2) { ... return ...; } > -else > s1 > > Signed-off-by: simran singhal > --- > drivers/staging/sm750fb/ddk750_sii164.c | 6 ++---- > drivers/staging/sm750fb/ddk750_swi2c.c | 6 ++---- > 2 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c > index 259006a..6906598 100644 > --- a/drivers/staging/sm750fb/ddk750_sii164.c > +++ b/drivers/staging/sm750fb/ddk750_sii164.c > @@ -368,8 +368,7 @@ unsigned char sii164IsConnected(void) > hotPlugValue = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT) & SII164_DETECT_HOT_PLUG_STATUS_MASK; > if (hotPlugValue == SII164_DETECT_HOT_PLUG_STATUS_ON) > return 1; > - else > - return 0; > + return 0; Totally unrelated to what you are doing, but I wonder if these return values should be true and false? Perhaps it would help to see how the return values are used at the calling context. julia > } > > /* > @@ -387,8 +386,7 @@ unsigned char sii164CheckInterrupt(void) > detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT) & SII164_DETECT_MONITOR_STATE_MASK; > if (detectReg == SII164_DETECT_MONITOR_STATE_CHANGE) > return 1; > - else > - return 0; > + return 0; > } > > /* > diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c > index a4ac07c..5997349 100644 > --- a/drivers/staging/sm750fb/ddk750_swi2c.c > +++ b/drivers/staging/sm750fb/ddk750_swi2c.c > @@ -199,8 +199,7 @@ static unsigned char sw_i2c_read_sda(void) > gpio_data = peek32(sw_i2c_data_gpio_data_reg); > if (gpio_data & (1 << sw_i2c_data_gpio)) > return 1; > - else > - return 0; > + return 0; > } > > /* > @@ -295,8 +294,7 @@ static long sw_i2c_write_byte(unsigned char data) > > if (i < 0xff) > return 0; > - else > - return -1; > + return -1; > } > > /* > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1488219268-3006-4-git-send-email-singhalsimran0%40gmail.com. > For more options, visit https://groups.google.com/d/optout. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Mon, 27 Feb 2017 21:15:38 +0000 Subject: Re: [Outreachy kernel] [PATCH 4/5] staging: sm750fb: Remove unnecessary else after return Message-Id: List-Id: References: <1488219268-3006-1-git-send-email-singhalsimran0@gmail.com> <1488219268-3006-4-git-send-email-singhalsimran0@gmail.com> In-Reply-To: <1488219268-3006-4-git-send-email-singhalsimran0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: simran singhal Cc: gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, outreachy-kernel@googlegroups.com On Mon, 27 Feb 2017, simran singhal wrote: > This patch fixes the checkpatch warning that else is not generally > useful after a break or return. > > This was done using Coccinelle: > @@ > expression e2; > statement s1; > @@ > if(e2) { ... return ...; } > -else > s1 > > Signed-off-by: simran singhal > --- > drivers/staging/sm750fb/ddk750_sii164.c | 6 ++---- > drivers/staging/sm750fb/ddk750_swi2c.c | 6 ++---- > 2 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c > index 259006a..6906598 100644 > --- a/drivers/staging/sm750fb/ddk750_sii164.c > +++ b/drivers/staging/sm750fb/ddk750_sii164.c > @@ -368,8 +368,7 @@ unsigned char sii164IsConnected(void) > hotPlugValue = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT) & SII164_DETECT_HOT_PLUG_STATUS_MASK; > if (hotPlugValue = SII164_DETECT_HOT_PLUG_STATUS_ON) > return 1; > - else > - return 0; > + return 0; Totally unrelated to what you are doing, but I wonder if these return values should be true and false? Perhaps it would help to see how the return values are used at the calling context. julia > } > > /* > @@ -387,8 +386,7 @@ unsigned char sii164CheckInterrupt(void) > detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT) & SII164_DETECT_MONITOR_STATE_MASK; > if (detectReg = SII164_DETECT_MONITOR_STATE_CHANGE) > return 1; > - else > - return 0; > + return 0; > } > > /* > diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c > index a4ac07c..5997349 100644 > --- a/drivers/staging/sm750fb/ddk750_swi2c.c > +++ b/drivers/staging/sm750fb/ddk750_swi2c.c > @@ -199,8 +199,7 @@ static unsigned char sw_i2c_read_sda(void) > gpio_data = peek32(sw_i2c_data_gpio_data_reg); > if (gpio_data & (1 << sw_i2c_data_gpio)) > return 1; > - else > - return 0; > + return 0; > } > > /* > @@ -295,8 +294,7 @@ static long sw_i2c_write_byte(unsigned char data) > > if (i < 0xff) > return 0; > - else > - return -1; > + return -1; > } > > /* > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1488219268-3006-4-git-send-email-singhalsimran0%40gmail.com. > For more options, visit https://groups.google.com/d/optout. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Mon, 27 Feb 2017 22:15:38 +0100 (CET) Subject: [lustre-devel] [Outreachy kernel] [PATCH 4/5] staging: sm750fb: Remove unnecessary else after return In-Reply-To: <1488219268-3006-4-git-send-email-singhalsimran0@gmail.com> References: <1488219268-3006-1-git-send-email-singhalsimran0@gmail.com> <1488219268-3006-4-git-send-email-singhalsimran0@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: simran singhal Cc: gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, outreachy-kernel@googlegroups.com On Mon, 27 Feb 2017, simran singhal wrote: > This patch fixes the checkpatch warning that else is not generally > useful after a break or return. > > This was done using Coccinelle: > @@ > expression e2; > statement s1; > @@ > if(e2) { ... return ...; } > -else > s1 > > Signed-off-by: simran singhal > --- > drivers/staging/sm750fb/ddk750_sii164.c | 6 ++---- > drivers/staging/sm750fb/ddk750_swi2c.c | 6 ++---- > 2 files changed, 4 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c > index 259006a..6906598 100644 > --- a/drivers/staging/sm750fb/ddk750_sii164.c > +++ b/drivers/staging/sm750fb/ddk750_sii164.c > @@ -368,8 +368,7 @@ unsigned char sii164IsConnected(void) > hotPlugValue = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT) & SII164_DETECT_HOT_PLUG_STATUS_MASK; > if (hotPlugValue == SII164_DETECT_HOT_PLUG_STATUS_ON) > return 1; > - else > - return 0; > + return 0; Totally unrelated to what you are doing, but I wonder if these return values should be true and false? Perhaps it would help to see how the return values are used at the calling context. julia > } > > /* > @@ -387,8 +386,7 @@ unsigned char sii164CheckInterrupt(void) > detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT) & SII164_DETECT_MONITOR_STATE_MASK; > if (detectReg == SII164_DETECT_MONITOR_STATE_CHANGE) > return 1; > - else > - return 0; > + return 0; > } > > /* > diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c > index a4ac07c..5997349 100644 > --- a/drivers/staging/sm750fb/ddk750_swi2c.c > +++ b/drivers/staging/sm750fb/ddk750_swi2c.c > @@ -199,8 +199,7 @@ static unsigned char sw_i2c_read_sda(void) > gpio_data = peek32(sw_i2c_data_gpio_data_reg); > if (gpio_data & (1 << sw_i2c_data_gpio)) > return 1; > - else > - return 0; > + return 0; > } > > /* > @@ -295,8 +294,7 @@ static long sw_i2c_write_byte(unsigned char data) > > if (i < 0xff) > return 0; > - else > - return -1; > + return -1; > } > > /* > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe at googlegroups.com. > To post to this group, send email to outreachy-kernel at googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1488219268-3006-4-git-send-email-singhalsimran0%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >