All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org
Subject: Re: [Outreachy kernel] [PATCH] media:atomisp:pci: Use error codes instead of bool variables
Date: Tue, 7 Mar 2017 22:39:36 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1703072237220.2292@hadrien> (raw)
In-Reply-To: <20170307213044.GA11835@fireworks>

> -	return true;
> +	return INPUT_SYSTEM_ERR_NO_ERROR;
> +
> +exit:
> +	return INPUT_SYSTEM_ERR_CREATE_CHANNEL_FAIL;

Oh...  I was hoping for standard kernel values like -ENOMEM, -EINVAL, etc.

Also, watch your subject lines.  Normally there is a space after each :.
In any case, you should pick what has been commonly used for this driver.

julia


  parent reply	other threads:[~2017-03-07 21:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07 21:30 [PATCH] media:atomisp:pci: Use error codes instead of bool variables Georgiana Rodica Chelu
2017-03-07 21:32 ` Georgiana Chelu
2017-03-07 21:39 ` Julia Lawall [this message]
2017-03-07 22:02   ` [Outreachy kernel] " Georgiana Chelu
2017-03-07 22:05     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1703072237220.2292@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=georgiana.chelu93@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.