Re: [PATCH 1/3] t7504: document regression: reword no longer calls commit-msg

From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Sebastian Schuberth <sschuberth@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 1/3] t7504: document regression: reword no longer calls commit-msg
Date: Thu, 23 Mar 2017 15:43:35 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1703231541180.3767@virtualbox> (raw)
In-Reply-To: <xmqqefxpkwjf.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Wed, 22 Mar 2017, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > In any case, this is *test* code. So I'd prefer to have the changes to
> > the C code scrutinized a bit more, not the test code as long as it is
> > obvious what it does.
> 
> [...] People have strengths in different areas, and those who can spot
> issues in tests better than the C code should not be discouraged from
> suggesting improvements by getting scolded like this.

I know Sebastian well, and I would hope that he lends his substantial
competence to making sure that the changes that affect end users are
correct and that I do not introduce another regression.

Besides, he is German, so I tried to spell it out clearly what I wish him
to do in return for my addressing his problem.

That was the entire reasoning behind my "scolding". I am sorry that you
understood it to be meant negatively. It was not.

Ciao,
Johannes